Re: RFR: 8213622 - Windows VS2013 build failure - "'snprintf': identifier not found"

Hi Jc, On 13/11/2018 10:50 AM, JC Beyler wrote: Hi David, Yes sorry, I had not seen that Mark Ludwig had only sent to me his comment that included this part: "if you're going to bother with strlen(), you know exactly how many bytes to copy, so don't use any strXXX API at all - just

Re: RFR: 8213622 - Windows VS2013 build failure - "'snprintf': identifier not found"

Hi David, Yes sorry, I had not seen that Mark Ludwig had only sent to me his comment that included this part: "if you're going to bother with strlen(), you know exactly how many bytes to copy, so don't use any strXXX API at all - just memcpy()." Does that make sense? Thanks, Jc On Mon, Nov 12,

Re: RFR: 8213622 - Windows VS2013 build failure - "'snprintf': identifier not found"

Hi Jc, On 13/11/2018 10:08 AM, JC Beyler wrote: Hi all, @Mark: good point, fixed in the new webrev I assume this was the strncpy -> memcpy change as I haven't see any email from Mark. What was the issue? Update is fine anyway. Thanks, David - @David: also good point, just because

Re: [PATCH] Add optimization flags for ARM926EJ-S

Hi Jakub, Build file changes have to be reviewed on build-dev - cc'd. Thanks, David On 13/11/2018 8:57 AM, Jakub Vaněk wrote: Hi, This patch adds a new ARM ABI option for ARM926EJ-S. The reason is not because of ABI breakage, but it is because of GCC -mcpu flags specifically for this CPU. We

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

BTW there were also a few minor grammar issues in javadoc eg 41 * the option named "-singleton" must be specified on jpackager command line. "the jpackager" 84 * Registers {@code SingleInstanceListener} for current process. and 96 * Registers {@code SingleInstanceListener}

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

On 11/12/2018 4:54 PM, Philip Race wrote: On 11/12/18, 1:45 PM, Andy Herrick wrote: On 11/12/2018 3:22 PM, Philip Race wrote: Adding build-dev back .. I noticed that module jdk.jpackager.runtime requires java.desktop on all platforms So far as I can tell this is for a Mac-only support

Re: RFR: 8213622 - Windows VS2013 build failure - "'snprintf': identifier not found"

Hi Jc, This seems okay to me. Only minor query is why you do the +1 (presumably for terminating NUL) on the return_len instead of len ? Thanks, David On 13/11/2018 7:11 AM, JC Beyler wrote: Hi all, I created this change instead: http://cr.openjdk.java.net/~jcbeyler/8213622/webrev.00/

Re: RFR: 8213569: Bump minimum boot jdk to JDK 11

Hi Mikael, Looks good. Thanks, David On 12/11/2018 5:30 PM, Mikael Vidstedt wrote: Please review this change which bumps the minimum boot jdk to JDK 11 (see [1] for Boot-JDK policy). bug: https://bugs.openjdk.java.net/browse/JDK-8213569

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

On 11/12/18, 1:45 PM, Andy Herrick wrote: On 11/12/2018 3:22 PM, Philip Race wrote: Adding build-dev back .. I noticed that module jdk.jpackager.runtime requires java.desktop on all platforms So far as I can tell this is for a Mac-only support for receiving and handling file open events.

Re: RFR: 8213569: Bump minimum boot jdk to JDK 11

Mikael: Please review this change which bumps the minimum boot jdk to JDK 11 (see [1] for Boot-JDK policy). bug:https://bugs.openjdk.java.net/browse/JDK-8213569

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

On 11/12/2018 3:22 PM, Philip Race wrote: Adding build-dev back .. I noticed that module jdk.jpackager.runtime requires java.desktop on all platforms So far as I can tell this is for a Mac-only support for receiving and handling file open events. Probably it only makes sense or gets used

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

74 75 static String getTmpDir() { 76 String os = System.getProperty("os.name").toLowerCase(); 77 if (os.contains("win")) { 78 return System.getProperty("user.home") 79 + "\\AppData\\LocalLow\\Sun\\Java\\JPackager\\tmp"; 80

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

SingleInstanceService. registerSingleInstance() says If the {@code SingleInstanceListener} object is already registered, or 98 * {@code slistener} is {@code null}, then the registration is skipped. I don't see how that can be working as every call to registerSingleInstanceForId creates

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

Adding build-dev back .. I noticed that module jdk.jpackager.runtime requires java.desktop on all platforms So far as I can tell this is for a Mac-only support for receiving and handling file open events. Probably it only makes sense or gets used when the API is used from a running desktop

RFR(S): 8213698: Improve devkit creation and add support for linux/ppc64/ppc64le/s390x

linux-gnu s390x-linux-gnu" and get the following devkits under "build/devkit/result": sdk-x86_64-unknown-linux-gnu-to-ppc64le-linux-gnu-20181112.tar.gz sdk-x86_64-unknown-linux-gnu-to-ppc64-linux-gnu-20181112.tar.gz sdk-x86_64-unknown-linux-gnu-to-s390x-linux-gnu-20181112.tar.gz x86_6

Re: jdk HEAD fails to build?

On Mon, 2018-11-12 at 10:52 +, Andrew Haley wrote: > On 11/12/2018 10:41 AM, Severin Gehwolf wrote: > > make/Main.gmk:1056: *** target pattern contains no '%'. Stop. > > > > But I'm not sure that error message is very telling. It might be a red > > herring. > > > > I'll keep looking. > >

Re: jdk HEAD fails to build?

On 11/12/2018 10:41 AM, Severin Gehwolf wrote: > make/Main.gmk:1056: *** target pattern contains no '%'. Stop. > > But I'm not sure that error message is very telling. It might be a red > herring. > > I'll keep looking. Does "hg status" reveal anything that shouldn't be there? -- Andrew Haley

Re: jdk HEAD fails to build?

Hi Adrian, On Mon, 2018-11-12 at 11:14 +0100, John Paul Adrian Glaubitz wrote: > Hi Severin! > > On 11/12/18 11:05 AM, Severin Gehwolf wrote: > > Is anybody else seing this? > > I just pulled the latest revision and was able to built HEAD > just fine. Thanks for checking! It must be something

Re: jdk HEAD fails to build?

Hi Severin! On 11/12/18 11:05 AM, Severin Gehwolf wrote: > Is anybody else seing this? I just pulled the latest revision and was able to built HEAD just fine. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin -

jdk HEAD fails to build?

Hi, I'm seing a strange build failure on F28 of jdk HEAD[1] after JDK- 8210958: https://bugs.openjdk.java.net/browse/JDK-8213736 Is anybody else seing this? Thanks, Severin [1] http://hg.openjdk.java.net/jdk/jdk/