Hi Jakub,
I have filed:
https://bugs.openjdk.java.net/browse/JDK-8214332
for this issue.
On 27/11/2018 6:51 am, Jakub Vaněk wrote:
Hi all,
I updated the original patch to address some issues.
* The option is documented to work only on Linux, BSD, AIX.
* Autoconf code now checks if this oper
Hi Kim,
- taskqueue.hpp has some small adjustments to enable subclassing
Why this change instead of JDK-8204947? As the description from that RFE says:
"The ShenandoahTaskTerminator from the Shenandoah project is a much better
implementation of a task terminator.”
We were busy on pre
A few quick comments (not a real review).
> On Nov 26, 2018, at 4:39 PM, Roman Kennke wrote:
>
> Sections to review (at this point) are the following:
>
> *) shared-gc
> - This is mostly boilerplate that is common to any GC
> - referenceProcessor.cpp has a little change to make one ass
/Magnus
> 26 nov. 2018 kl. 23:14 skrev David Holmes :
>
> Hi Magnus,
>
> I'm still rather confused by this JEP. IIUC this is mainly the infrastructure
> work needed to support manpages, but the actual manpages present in the
> sources are completely out of date and not in sync with the onli
Hi Roman,
You need to check if shenandoahgc is disabled first - check
DISABLED_JVM_FEATURES list (see code for jvmci).
Do you support 32-bit x86? You have OPENJDK_TARGET_CPU == xx86 check.
Do you support all x86 OSs?
Why you set VM CFLAGS when shenandoahgc is not enabled? It is in
JvmFeature
Hi,
On 11/19/18 3:37 PM, Roger Riggs wrote:
Raw::xxx_NDX are initialized to 1 + previous_NDX. It's a general
good approach to increment the index but I find it error-prone and
hard to catch mistake since the (adjacent) variable names look
so alike. Perhaps some form of verification or assertion
Build changes look ok to me.
/Erik
On 2018-11-26 13:39, Roman Kennke wrote:
Hi,
This is the first round of changes for including Shenandoah GC into
mainline.
I divided the review into parts that roughly correspond to the mailing lists
that would normally review it, and I divided it into 'share
Looks good to me.
/Erik
On 2018-11-26 13:19, Jakub Vaněk wrote:
On 2018-11-26 at 13:04 -0800, Erik Joelsson wrote:
Hello,
It's still not handling the bad yes/no values.
/Erik
Hi Erik,
I added the check now.
Thanks,
Jakub
# HG changeset patch
# User Jakub Vaněk
# Date 1543266969 -3600
Hi Magnus,
I'm still rather confused by this JEP. IIUC this is mainly the
infrastructure work needed to support manpages, but the actual manpages
present in the sources are completely out of date and not in sync with
the online documentation. Correct?
Thanks,
David
On 27/11/2018 4:57 am, Ma
Side note, I wondered whether IBM does anything original in their
openj9 (the jdk parts they forked off OpenJDK) since they are
targetting AIX too and must be having the same build error. But I
cannot find anything they did:
---
thomas@t450:/shared/projects/openjdk/j9/openj9-openjdk-jdk$ git log -
Hi,
This is the first round of changes for including Shenandoah GC into
mainline.
I divided the review into parts that roughly correspond to the mailing lists
that would normally review it, and I divided it into 'shared' code
changes and
'shenandoah' code changes (actually, mostly additions). The
On 2018-11-26 at 13:04 -0800, Erik Joelsson wrote:
> Hello,
>
> It's still not handling the bad yes/no values.
>
> /Erik
Hi Erik,
I added the check now.
Thanks,
Jakub
# HG changeset patch
# User Jakub Vaněk
# Date 1543266969 -3600
# Mon Nov 26 22:16:09 2018 +0100
# Node ID 0e938f324f9
Hello,
It's still not handling the bad yes/no values.
/Erik
On 2018-11-26 12:51, Jakub Vaněk wrote:
Hi all,
I updated the original patch to address some issues.
* The option is documented to work only on Linux, BSD, AIX.
* Autoconf code now checks if this operation is supported on the targe
Hi all,
I updated the original patch to address some issues.
* The option is documented to work only on Linux, BSD, AIX.
* Autoconf code now checks if this operation is supported on the target
platform* Autoconf code is moved to jdk-options.m4, where it mirrors how
--with-cacerts-file option
Well .. I see this was pushed whilst I was on vacation.
I would not have voted for the fix in its current form. The
"HAVE_XRANDR" would
have been less bad. If (say) HPUX has the same issue you
haven't really helped them with an AIX specific change in the source file.
It would have been better t
Nice to see this finally happening!
ProcessMarkdown.gmk: Looks like indentation got messed up on lines 79
and 98. Looks good otherwise.
/Erik
On 2018-11-26 10:57, Magnus Ihse Bursie wrote:
This patch will finally implement the last part of JEP 299, moving man
pages into the prescribed locati
This patch will finally implement the last part of JEP 299, moving man
pages into the prescribed location in the source tree.
This patch also prepares for supplying man pages in markdown format,
which will be converted to troff (standard man page format) during the
build. Currently, such markd
Hello,
Looks reasonable. In hotspot.m4, we usually add explicit error messages
for configure parameters having the values "yes" or "no", which are the
default values if the user just provides "--with-hotspot-libpath" or
"--without-hotspot-libpath". Then we print something like
"--with-hotspot
I think this looks reasonable.
/Erik
On 2018-11-25 07:49, Jakub Vaněk wrote:
Hi,
This patch is a redo of the ARM926EJ-S patch. It adds a mechanism of
passing ARM CPU-specific flags to the assembler. This is achieved
through sharing variables between ABI setup and ASFLAGS setup. Then
this patc
On 26/11/2018 09:08, Nick Gasson wrote:
Hi Alan,
I've done this here:
http://cr.openjdk.java.net/~njian/8214077/webrev.3/
This looks good and I think means we no longer have any stat usages in
libjava.
-Alan
> If you can then it would be great, if only to save others from looking
> at it and wondering if it should also be changed. Maybe for another
> issue but there are several other usages in the java launcher that
> should be looked at.
Hi Alan,
I've done this here:
http://cr.openjdk.java.net/~nji
21 matches
Mail list logo
