RE: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

Hi Alan, Martin, Do you want me to make any more changes to this patch, or is it OK to go in with just the modified #ifdef? Thanks, Nick From: Martin Buchholz Sent: 28 November 2018 11:33 To: Nick Gasson Cc: Alan Bateman ; Magnus Ihse Bursie ; build-dev ; core-libs-...@openjdk.java.net; nd

Re: [12] Review Request: 8212680 (JDK12b14/Solaris-sparc) SplashScreen::getSplashScreen call fails with ULE: "libsplashscreen.so: ld.so.1: java: fatal: libz.so.1: open failed: No such file o

Then it can be simplified further: http://cr.openjdk.java.net/~serb/8212680/webrev.01 I added the new option since I am not sure how important the usage of "PNG_MAXIMUM_INFLATE_WINDOW or PNG_SKIP_sRGB_CHECK_PROFILE" As I said, I don't see anything important ... -- Best regards, Sergey.

Re: [12] Review Request: 8212680 (JDK12b14/Solaris-sparc) SplashScreen::getSplashScreen call fails with ULE: "libsplashscreen.so: ld.so.1: java: fatal: libz.so.1: open failed: No such file o

+1 from me. -phil. On 11/29/18, 7:27 PM, Sergey Bylokhov wrote: Then it can be simplified further: http://cr.openjdk.java.net/~serb/8212680/webrev.01 I added the new option since I am not sure how important the usage of "PNG_MAXIMUM_INFLATE_WINDOW or PNG_SKIP_sRGB_CHECK_PROFILE" As I said, I

Re: [12] Review Request: 8212680 (JDK12b14/Solaris-sparc) SplashScreen::getSplashScreen call fails with ULE: "libsplashscreen.so: ld.so.1: java: fatal: libz.so.1: open failed: No such file o

On 11/29/18, 9:38 AM, Sergey Bylokhov wrote: On 28/11/2018 20:24, Philip Race wrote: Not something we want to do if there's any way out of it. can we just disable PNG_SET_OPTION_SUPPORTED in pnglibconfig.h which is something that is "generated" and not part of the png source ? I don't see

RFR (round 3), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hello all, Thanks so far for all the reviews and support! I forgot to update the 'round' yesterday. We are in round 3 now :-) Also, I fixed the numbering of my webrevs to match the review-round. ;-) Things we've changed today: - We moved shenandoah-specific code out of .ad files into our own .ad

Re: RFR 8214309: Enhance makefiles to allow generating JCov instrumented build

Looks good to me. /Erik On 2018-11-27 14:58, Alexandre (Shura) Iline wrote: Hi. Please take a look on a suggested change in OpenJDK make system which allows to generate an image instrumented for code coverage analysis with JCov. There will need to be follow-on changes making it possible to r

Re: [12] Review Request: 8212680 (JDK12b14/Solaris-sparc) SplashScreen::getSplashScreen call fails with ULE: "libsplashscreen.so: ld.so.1: java: fatal: libz.so.1: open failed: No such file o

On 28/11/2018 20:24, Philip Race wrote: Not something we want to do if there's any way out of it. can we just disable PNG_SET_OPTION_SUPPORTED in pnglibconfig.h which is something that is "generated" and not part of the png source ? I don't see anything that is important enabled by that option

Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags

Hi All, The build passed on xlC 13.1 with the makefile patch I proposed (good catch on the comments Volkar!). With Volkar, Erik, Matthias, and Magnus all approving the change, it sounds like we're good to merge! Volkar, can you do the honours? Best Regards Adam Farley IBM Runtimes P.S. I a

Re: RFR (round 1), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Oh, I filed a bug [1] and sent out a fix for review, before noticing Jini's mail. [1] https://bugs.openjdk.java.net/browse/JDK-8214484 /Per On 11/29/18 5:39 AM, Jini George wrote: Hi Roman, The SA tests which iterate over the heap (ClhsdbJhisto.java, TestHeapDumpFor*.java) fail if ZGC is pa

Re: RFR (round 1), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hi Roman, On 11/28/18 11:29 PM, Roman Kennke wrote: [...] Per: Disabling the SA part for heapdumping makes 2 tests fail: - test/hotspot/jtreg/serviceability/sa/ClhsdbJhisto.java - test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java we filter them for Shenandoah now. I'm wonderin

Re: RFR: 8214476: ZGC: Build ZGC by default

Thanks Magnus! /Per On 11/29/18 3:15 PM, Magnus Ihse Bursie wrote: Looks good to me. /Magnus 29 nov. 2018 kl. 13:35 skrev Per Liden : At one point, it was decided that experimental VM features (such as ZGC) should be not be built by default. This policy was later changed/abandoned, so we

Re: RFR: 8214476: ZGC: Build ZGC by default

Looks good to me. /Magnus > 29 nov. 2018 kl. 13:35 skrev Per Liden : > > At one point, it was decided that experimental VM features (such as ZGC) > should be not be built by default. This policy was later changed/abandoned, > so we should enable building of ZGC by default. > > Bug: https://b

Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

Hello Alan & Magnus. Sorry for you confusion. I did many copy actions and rename actions. So you may see, I added unexpected code into non AIX platform. I think I should not put 2 kind of modification. For this bug id, I'll handle IBM964 and IBM33722. (also SimpleEUCEncoder.java is required) I

Re: RFR: 8214476: ZGC: Build ZGC by default

Thanks for reviewing, Roman! /Per On 11/29/18 2:16 PM, Roman Kennke wrote: Yes! Great! Patch looks good! Roman At one point, it was decided that experimental VM features (such as ZGC) should be not be built by default. This policy was later changed/abandoned, so we should enable building of

Re: RFR: 8214476: ZGC: Build ZGC by default

Yes! Great! Patch looks good! Roman > At one point, it was decided that experimental VM features (such as ZGC) > should be not be built by default. This policy was later > changed/abandoned, so we should enable building of ZGC by default. > > Bug: https://bugs.openjdk.java.net/browse/JDK-821447

Re: RFR: 8214476: ZGC: Build ZGC by default

Also, if that's not already the plan, please consider backporting it to jdk11u. This would help downstream builders (like us) not to miss ZGC there (like we did). -Aleksey On 11/29/18 1:40 PM, Per Liden wrote: > Thanks for reviewing, Aleksey. > > cheers, > Per > > On 11/29/18 1:38 PM, Aleksey

Re: RFR: 8214476: ZGC: Build ZGC by default

Thanks for reviewing, Aleksey. cheers, Per On 11/29/18 1:38 PM, Aleksey Shipilev wrote: On 11/29/18 1:35 PM, Per Liden wrote: At one point, it was decided that experimental VM features (such as ZGC) should be not be built by default. This policy was later changed/abandoned, so we should enabl

Re: RFR: 8214476: ZGC: Build ZGC by default

On 11/29/18 1:35 PM, Per Liden wrote: > At one point, it was decided that experimental VM features (such as ZGC) > should be not be built by > default. This policy was later changed/abandoned, so we should enable > building of ZGC by default. > > Bug: https://bugs.openjdk.java.net/browse/JDK-821

Re: [PATCH v3] 8214332: Add a flag for overriding default JNI library search path

Hi David, Thanks! Jakub On 2018-11-29 at 13:20 +1000, David Holmes wrote: > Sponsoring. :) > > Thanks, > David

RFR: 8214476: ZGC: Build ZGC by default

At one point, it was decided that experimental VM features (such as ZGC) should be not be built by default. This policy was later changed/abandoned, so we should enable building of ZGC by default. Bug: https://bugs.openjdk.java.net/browse/JDK-8214476 Webrev: http://cr.openjdk.java.net/~pliden/8

Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags

On Thu, Nov 29, 2018 at 12:20 PM Magnus Ihse Bursie wrote: > > On 2018-11-27 16:33, Volker Simonis wrote: > > > Hi, > > > > can I please have a review for the following trivial change which > > simply disables the symbol visibility flags on AIX: > > > > http://cr.openjdk.java.net/~simonis/webrevs/

Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags

On 2018-11-27 16:33, Volker Simonis wrote: Hi, can I please have a review for the following trivial change which simply disables the symbol visibility flags on AIX: http://cr.openjdk.java.net/~simonis/webrevs/2018/8214063/ https://bugs.openjdk.java.net/browse/JDK-8214063 Looks good to me. I am

Re: RFR (round 1), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Thanks, Per! I will do this. Check out round 3 when it arrives. ;-) Roman Am 29.11.18 um 12:07 schrieb Per Liden: > Small comment on the build changes. Instead of checking for zero variant > here: > > +  # Only enable Shenandoah on supported arches > +  AC_MSG_CHECKING([if shenandoah can be bui

Re: RFR (round 1), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Thanks, Magnus, this makes sense. I'll incorporate that simplification. Thanks, Roman Am 29.11.18 um 11:53 schrieb Magnus Ihse Bursie: > On 2018-11-26 23:47, Erik Joelsson wrote: > >> Build changes look ok to me. > I agree, but I'd like to point out a (possible) style improvement. In > hotspot.

Re: RFR (round 1), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Small comment on the build changes. Instead of checking for zero variant here: + # Only enable Shenandoah on supported arches + AC_MSG_CHECKING([if shenandoah can be built]) + if HOTSPOT_CHECK_JVM_VARIANT(zero); then +DISABLED_JVM_FEATURES="$DISABLED_JVM_FEATURES shenandoahgc" +AC_MSG

Re: [12] Review Request: 8212680 (JDK12b14/Solaris-sparc) SplashScreen::getSplashScreen call fails with ULE: "libsplashscreen.so: ld.so.1: java: fatal: libz.so.1: open failed: No such file o

On 2018-11-29 00:11, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8212680 Webrev: http://cr.openjdk.java.net/~serb/8212680/webrev.00 Hi Sergey, I understand the change in png.h and why it fixes the issue. But I, like Erik, am

Re: RFR (round 1), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

On 2018-11-26 23:47, Erik Joelsson wrote: Build changes look ok to me. I agree, but I'd like to point out a (possible) style improvement. In hotspot.m4, if test "x$OPENJDK_TARGET_CPU" = "xx86_64" || test "x$OPENJDK_TARGET_CPU" = "xaarch64" || test "x$OPENJDK_TARGET_CPU" == "xx86"; then ca

Re: RFR (round 1), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hi Jini, > The SA tests which iterate over the heap (ClhsdbJhisto.java, > TestHeapDumpFor*.java) fail if ZGC is passed as an option to these also > (Am planning on fixing these). It might be better to avoid invoking > those tests for Shenandoah now with an @requires tag. Thanks for clarifying. Ye

Re: RFR (round 1), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hi Vladimir, thanks for reviewing! > .ad files. I am thinking may be we should put new code in separate > _shenandoah.ad files and merge them only if Shenandoah is included > in built [1]. I don't like #ifdefs - you still generate this mach nodes > even without Shenandoah. We're looking into imp