Hi,
I attached the latest patch, which now can use Windows paths. The new
instructions to build are (assuming 8.3 paths are enabled on your system...):
1. wsl must be started from a Windows Developer command prompt. To ensure the
correct environment variables are propagated from Windows to WS
On 13/12/2018 10:28 am, Kim Barrett wrote:
On Dec 12, 2018, at 5:17 PM, David Holmes wrote:
Hi Magnus,
What did -Xa do?
From the documentation for -Xa:
The -X options cannot be used if the -std has been specified.
The -X options specify varying degress of compliance to the 1990 and 1999
I
> On Dec 12, 2018, at 5:17 PM, David Holmes wrote:
>
> Hi Magnus,
>
> What did -Xa do?
From the documentation for -Xa:
The -X options cannot be used if the -std has been specified.
The -X options specify varying degress of compliance to the 1990 and 1999
ISO C standard. ...
-Xa
ISO C plus K&
Hi Magnus,
What did -Xa do?
Do AWT folk need to check this. I find it hard to understand the
connection between:
-xc99=no_lib
and
-D_XPG6
??
Thanks,
David
On 13/12/2018 7:02 am, Magnus Ihse Bursie wrote:
On 2018-12-12 20:08, Magnus Ihse Bursie wrote:
On 2018-12-12 19:12, Magnus Ihs
Looks ok to me.
/Erik
On 2018-12-12 13:02, Magnus Ihse Bursie wrote:
On 2018-12-12 20:08, Magnus Ihse Bursie wrote:
On 2018-12-12 19:12, Magnus Ihse Bursie wrote:
From the bug report:
"Currently we disable C99 in the Solaris build by setting
-xc99=%none%.
This differs from a lot of othe
On 2018-12-12 20:08, Magnus Ihse Bursie wrote:
On 2018-12-12 19:12, Magnus Ihse Bursie wrote:
From the bug report:
"Currently we disable C99 in the Solaris build by setting -xc99=%none%.
This differs from a lot of other build environments like gcc/Linux or
VS2013/2017 on Windows where C99
On 2018-12-12 19:12, Magnus Ihse Bursie wrote:
From the bug report:
"Currently we disable C99 in the Solaris build by setting -xc99=%none%.
This differs from a lot of other build environments like gcc/Linux or
VS2013/2017 on Windows where C99 features work.
We should remove this difference o
On 2018-12-12 18:30, Erik Joelsson wrote:
Hello,
I had the same trouble you describe trying to call cmd to create a
short path from WSL with an inline script. I managed to it working by
creating a script file like this:
shortName.cmd:
---
@ECHO OFF
if '%1' NEQ '' echo %~s1
---
$ /mnt/c/Win
Change looks good to me.
/Erik
On 2018-12-12 10:12, Magnus Ihse Bursie wrote:
From the bug report:
"Currently we disable C99 in the Solaris build by setting -xc99=%none%.
This differs from a lot of other build environments like gcc/Linux or
VS2013/2017 on Windows where C99 features work.
We s
Looks good.
/Erik
On 2018-12-12 10:00, Magnus Ihse Bursie wrote:
The target docs-jdk-index has dependencies that are quite
heavyweight, and are not needed. They should just be removed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8215304
Patch inline:
diff --git a/make/Main.gmk b/make/Main.
From the bug report:
"Currently we disable C99 in the Solaris build by setting -xc99=%none%.
This differs from a lot of other build environments like gcc/Linux or
VS2013/2017 on Windows where C99 features work.
We should remove this difference on Solaris and remove or replace the
setting.
Kim
Looks OK Magnus
> On Dec 12, 2018, at 1:00 PM, Magnus Ihse Bursie
> wrote:
>
> The target docs-jdk-index has dependencies that are quite heavyweight, and
> are not needed. They should just be removed.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8215304
> Patch inline:
> diff --git a/ma
The target docs-jdk-index has dependencies that are quite heavyweight,
and are not needed. They should just be removed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8215304
Patch inline:
diff --git a/make/Main.gmk b/make/Main.gmk
--- a/make/Main.gmk
+++ b/make/Main.gmk
@@ -862,8 +862,6 @@
d
Looks good.
/Erik
On 2018-12-12 08:31, Magnus Ihse Bursie wrote:
The top level index file is primarily a redirect file, and is never
seen directly.
However, it shows up in reports as not having a element and
element, which makes it illegal HTML, and not having a
copyright line.
build/li
Hello,
I had the same trouble you describe trying to call cmd to create a short
path from WSL with an inline script. I managed to it working by creating
a script file like this:
shortName.cmd:
---
@ECHO OFF
if '%1' NEQ '' echo %~s1
---
$ /mnt/c/Windows/System32/cmd.exe /c shortName.cmd "C:\
On 12/12/2018 16:52, Magnus Ihse Bursie wrote:
On 2018-12-12 16:34, Alexey Ivanov wrote:
On 12/12/2018 12:58, Magnus Ihse Bursie wrote:
On 2018-12-12 12:35, Alan Bateman wrote:
On 12/12/2018 11:14, Magnus Ihse Bursie wrote:
:
I searched the code for "jdwpTransport_On" to see of there
> On Dec 12, 2018, at 6:39 AM, Magnus Ihse Bursie
> wrote:
>
> Yes, the requirement for docs-jdk-index is indeed incorrect. Probably some
> remnant from when I splitted up the single monolitical "docs" target, that
> depended on exploded-image.
>
> Dan, please try if this patch helps you:
> -
On 2018-12-12 16:34, Alexey Ivanov wrote:
On 12/12/2018 12:58, Magnus Ihse Bursie wrote:
On 2018-12-12 12:35, Alan Bateman wrote:
On 12/12/2018 11:14, Magnus Ihse Bursie wrote:
:
I searched the code for "jdwpTransport_On" to see of there was any
corresponding OnUnload function (or other)
On 2018-12-12 17:38, Alexey Ivanov wrote:
Hi all,
I have updated the summary of JDK-8214122 and the subject accordingly.
Could you please review the following fix?
https://bugs.openjdk.java.net/browse/JDK-8214122
webrev: http://cr.openjdk.java.net/~aivanov/8214122/webrev.01/
Looks good to
Hi all,
I have updated the summary of JDK-8214122 and the subject accordingly.
Could you please review the following fix?
https://bugs.openjdk.java.net/browse/JDK-8214122
webrev: http://cr.openjdk.java.net/~aivanov/8214122/webrev.01/
*Root cause*
jdwpTransport_OnLoad is exported as _jdwpTransp
The top level index file is primarily a redirect file, and is never seen
directly.
However, it shows up in reports as not having a element and
element, which makes it illegal HTML, and not having a copyright
line.
build/linux-x86_64-server-release/images/docs/index.html:1:108: Warning:
di
Forgot to add the link:
On 12/12/2018 16:10, Alexey Ivanov wrote:
Ali has scanned the code base, he says, “couldn’t find (hopefully tbh)
other occurrences of such mismatches.”
http://mail.openjdk.java.net/pipermail/build-dev/2018-December/024358.html
On 10/12/2018 10:45, Magnus Ihse Bursie
Thank you, Ali, for doing this!
On 10/12/2018 21:13, Ali İnce wrote:
Hi Alexey,
I’ve searched for |GetProcAddress| usages across source code and
couldn’t find (hopefully tbh) other occurrences of such mismatches.
Regards,
Ali
Ali has scanned the code base, he says, “couldn’t find (hopefully tbh)
other occurrences of such mismatches.”
On 10/12/2018 10:45, Magnus Ihse Bursie wrote:
It might be worthwhile to scan the entire code base for JNICALL and
verify that we have no more mismatches. In general, JNICALL should be
Hello, I created :
https://bugs.openjdk.java.net/browse/JDK-8215296
8215296: do not disable c99 on Solaris
Best regards, Matthias
> -Original Message-
> From: Kim Barrett
> Sent: Mittwoch, 12. Dezember 2018 16:41
> To: Magnus Ihse Bursie
> Cc: Baesken, Matthias ; David Holmes
> ; E
Hi Simon,
I'd like to clarify some points…
Please see my comments inline:
On 11/12/2018 17:16, Alexey Ivanov wrote:
Hi Simon,
Thank you for your comments.
The updated webrev:
http://cr.openjdk.java.net/~aivanov/8214122/webrev.01/
Indeed, it looks much cleaner.
Regards,
Alexey
On 11/12/2018
Hi Bob,
Thank you for the pointers on how the same situation is handled in
Hotspot for *_OnLoad* functions.
At this time, we're dealing with one symbol only. If other symbols are
added in the future, we should definitely use this approach.
Regards,
Alexey
On 11/12/2018 17:22, Bob Vandette
> On Dec 12, 2018, at 9:11 AM, Magnus Ihse Bursie
> wrote:
>
>
>
> On 2018-12-12 14:29, Baesken, Matthias wrote:
>>> I'd recommend a separate change to remove the -xc99=%none%. That's
>>> trivial and can be done immediately, to the benefit of everyone. Getting
>>> C++14 working is not happenin
On 12/12/2018 12:58, Magnus Ihse Bursie wrote:
On 2018-12-12 12:35, Alan Bateman wrote:
On 12/12/2018 11:14, Magnus Ihse Bursie wrote:
:
I searched the code for "jdwpTransport_On" to see of there was any
corresponding OnUnload function (or other), but could not find any.
That's right, an
> On Dec 12, 2018, at 8:21 AM, Magnus Ihse Bursie
> wrote:
>
> On 2018-12-12 09:24, Baesken, Matthias wrote:
>>> FWIW, in my in-development patch set for JEP 347
>>> (https://bugs.openjdk.java.net/browse/JDK-8208089)
>>>
>>> the -xc99=%none% option has been removed and -std=c99 added (for C
>>>
Hi Erik,
On 2018-12-12 at 15:41 +0300, Boris Ulasevich wrote:
> Hi Jakub,
>
> I do not understand why you use memcpy in softfloat_arm.cpp.
> If type cast is the only reason why don't you use reinterpret_cast?
>
> regards,
> Boris
I'm using memcpy there because float32_t is a struct containing a
On 2018-12-12 14:29, Baesken, Matthias wrote:
I'd recommend a separate change to remove the -xc99=%none%. That's
trivial and can be done immediately, to the benefit of everyone. Getting
C++14 working is not happening quickly.
Ok, do you prefer just removing the old setting or setting
https:/
On 2018-12-12 02:47, Dan Smith wrote:
On Dec 11, 2018, at 5:28 PM, Erik Joelsson wrote:
- Can we similarly eliminate dependencies from 'make docs'? Right now, the
javadoc invocation requires compiled classes to be available, but I don't know
if that's necessary. Maybe it will work just as we
On 2018-12-12 01:28, Erik Joelsson wrote:
Hello Dan,
On 2018-12-11 15:43, Dan Smith wrote:
Would it be possible to adjust the build system's handling of docs so
that it is not necessary to do a complete compilation before the docs
can be generated?
I'm working with specs, and the followin
> I'd recommend a separate change to remove the -xc99=%none%. That's
> trivial and can be done immediately, to the benefit of everyone. Getting
> C++14 working is not happening quickly.
Ok, do you prefer just removing the old setting or setting
https://docs.oracle.com/cd/E37069_01/html/E37074/bj
On 2018-12-12 09:24, Baesken, Matthias wrote:
FWIW, in my in-development patch set for JEP 347
(https://bugs.openjdk.java.net/browse/JDK-8208089)
the -xc99=%none% option has been removed and -std=c99 added (for C
code). (C++14 includes C99 by reference, so I made that change for
consistency in c
On 2018-12-12 12:35, Alan Bateman wrote:
On 12/12/2018 11:14, Magnus Ihse Bursie wrote:
:
I searched the code for "jdwpTransport_On" to see of there was any
corresponding OnUnload function (or other), but could not find any.
That's right, an unload wasn't needed when that SPI was originally
Hi Jakub,
I do not understand why you use memcpy in softfloat_arm.cpp.
If type cast is the only reason why don't you use reinterpret_cast?
regards,
Boris
On 10.12.2018 23:23, Jakub Vaněk wrote:
Hi Erik,
On 2018-12-10 at 09:39 -0800, Erik Joelsson wrote:
The build changes look ok to me.
I do
Okay I went away and did some homework ...
Let me back up a bit and see if I have the evolution of this correctly.
The native implementation of Java methods should be declared and defined
with JNIEXPORT and JNICALL.
JNIEXPORT controls the export visibility so they can be linked.
JNICALL cont
On 12/12/2018 11:14, Magnus Ihse Bursie wrote:
:
I searched the code for "jdwpTransport_On" to see of there was any
corresponding OnUnload function (or other), but could not find any.
That's right, an unload wasn't needed when that SPI was originally added
but could be added in the event that
On 2018-12-12 01:01, Erik Joelsson wrote:
If something goes wrong in the recipe for creating the jdk image, make
will automatically delete the target of the recipe, which happens to
be bin/java in the image. This is unfortunate, because that file is
rather useful when troubleshooting what we
On 2018-12-11 18:16, Alexey Ivanov wrote:
Hi Simon,
Thank you for your comments.
The updated webrev:
http://cr.openjdk.java.net/~aivanov/8214122/webrev.01/
Indeed, it looks much cleaner.
Yes! This seems like the correct fix.
Ship it! :)
/Magnus
Regards,
Alexey
On 11/12/2018 16:43, Si
On 2018-12-11 18:22, Bob Vandette wrote:
Hotspot has had support for decorated and non-decorated names for the JNI_OnLoad
functions. Perhaps you should just follow the same procedure for the debug
library.
#define JNI_ONLOAD_SYMBOLS {"_JNI_OnLoad@8", "JNI_OnLoad"}
#define JNI_ONUNLOAD_SYMBOLS
On 2018-12-11 23:47, David Holmes wrote:
On 12/12/2018 12:34 am, Magnus Ihse Bursie wrote:
On 2018-12-11 00:23, David Holmes wrote:
Hi Magnus,
On 10/12/2018 11:19 pm, Magnus Ihse Bursie wrote:
I propose that we introduce a new define, available to all JDK
native files (Hotspot included),
On 2018-12-12 09:40, David Holmes wrote:
On 12/12/2018 5:44 pm, Volker Simonis wrote:
On Tue, Dec 11, 2018 at 11:47 PM David Holmes
wrote:
On 12/12/2018 12:34 am, Magnus Ihse Bursie wrote:
On 2018-12-11 00:23, David Holmes wrote:
Hi Magnus,
On 10/12/2018 11:19 pm, Magnus Ihse Bursie w
On 12/12/2018 5:44 pm, Volker Simonis wrote:
On Tue, Dec 11, 2018 at 11:47 PM David Holmes wrote:
On 12/12/2018 12:34 am, Magnus Ihse Bursie wrote:
On 2018-12-11 00:23, David Holmes wrote:
Hi Magnus,
On 10/12/2018 11:19 pm, Magnus Ihse Bursie wrote:
I propose that we introduce a new defi
>
>FWIW, in my in-development patch set for JEP 347
>(https://bugs.openjdk.java.net/browse/JDK-8208089)
>
>the -xc99=%none% option has been removed and -std=c99 added (for C
>code). (C++14 includes C99 by reference, so I made that change for
>consistency in case there were any ABI differences.)
>
47 matches
Mail list logo
