17 dec. 2018 kl. 16:24 skrev Baesken, Matthias :
>> Sounds like a simpler change, at least for now. Does it pass jdk-submit? Do
>> you intend to push to 12 or 13?
>
> Hi Magus, thanks for the review.
> I think it is safer to go for 13 , what's your opinion ?
Agree.
/Magnus
>
> I put it into
(moving to build-dev)
Hi,
As of version 2018.2 [1], as an alternative to CMakeLists.txt, CLion can make
use of compile_commands.json [2] as well. After configuring your build, you can
generate such a file with the JDK make system:
$ make compile-commands
Or alternatively, if you are only
Our internal builds pass okay.
David
On 18/12/2018 8:02 am, David Holmes wrote:
Hi Matthias,
On 17/12/2018 11:12 pm, Baesken, Matthias wrote:
Hello, please review
http://cr.openjdk.java.net/~mbaesken/webrevs/8215296.0/
in my change just -xc99=%none is removed, so we do not forbid c99
Hi Matthias,
On 17/12/2018 11:12 pm, Baesken, Matthias wrote:
Hello, please review
http://cr.openjdk.java.net/~mbaesken/webrevs/8215296.0/
in my change just -xc99=%none is removed, so we do not forbid c99 coding.
The -Xa compile flag is kept, no special additional settings are needed to
Thanks Volker! That was what I wanted to hear. :)
The inability to build in parallel was what turned us off mingw/msys way
back when you introduced it. Without concurrency, we certainly did not
see any improvement in performance.
/Erik
On 2018-12-15 09:34, Volker Simonis wrote:
It is a long
Regarding msys2, some years ago, I got it working on my Windows laptop.
It didn't require much then. IIRC it just identified itself a bit
differently. It didn't improve build performance over Cygwin however, so
I never committed those changes.
It is my understanding that msys2 is the
Hello Andrew,
On 2018-12-16 00:01, Andrew Luo wrote:
For me, /mnt/c was already mounted case insensitive. Maybe this is only the
default for the C:\ drive though (or perhaps depends on your Windows/WSL
version?)
I think the default is "dir", which will cause any new directory created
from
> Sounds like a simpler change, at least for now. Does it pass jdk-submit? Do
> you intend to push to 12 or 13?
Hi Magus, thanks for the review.
I think it is safer to go for 13 , what's your opinion ?
I put it into our internal build+test queue first , after this is fine , I
will go for
Sounds like a simpler change, at least for now. Does it pass jdk-submit? Do you
intend to push to 12 or 13?
Looks good to me, as long as it doesn't break anything.
/Magnus
> 17 dec. 2018 kl. 14:12 skrev Baesken, Matthias :
>
>
> Hello, please review
>
>
Hello, please review
http://cr.openjdk.java.net/~mbaesken/webrevs/8215296.0/
in my change just -xc99=%none is removed, so we do not forbid c99 coding.
The -Xa compile flag is kept, no special additional settings are needed to
compile png/awt .
Thanks, Matthias
>
10 matches
Mail list logo
