Re: RFR 8215729: Enhance makefiles to allow collecting code coverage with JCov

2019-01-08 Thread David Holmes
Hi Shura, Sorry not a review just a comment on one thing ... On 9/01/2019 4:35 am, Alexandre (Shura) Iline wrote: Hi, Could you please take a look on a change which allows to run tests while collecting code coverage with JCov. This is a continuation of work done in JDK-8214309: Enhance makefi

RFR: XXS: JDK-8215308: pandoc-html-manpage-filter.js does not work for [un]pack200

2019-01-08 Thread Jonathan Gibbons
Please review a small edit to a regular expression used to detect the name of a tool in a man page. Here's the inline version of the patch: $ hg diff -R open diff -r 28ec06beb091 make/scripts/pandoc-html-manpage-filter.js --- a/make/scripts/pandoc-html-manpage-filter.js Tue Jan 08 13:04:04 201

RFR 8215729: Enhance makefiles to allow collecting code coverage with JCov

2019-01-08 Thread Alexandre (Shura) Iline
Hi, Could you please take a look on a change which allows to run tests while collecting code coverage with JCov. This is a continuation of work done in JDK-8214309: Enhance makefiles to allow generating JCov instrumented build. This adds make targets jcov-test and others like jcov-test-tier1 et