Erik,
I have pushed a version of Andrew's patch for jtreg into the jtreg repo.
With regard to Andrew's proposed patch for make/RunTests.gmk, the name
of the option to use for jtreg is now just "-wsl'.
-- Jon
On 01/07/2019 01:10 AM, Erik Joelsson wrote:
Hello Andrew,
If the patch gets accep
On 10/01/2019 5:46 am, Alexandre (Shura) Iline wrote:
David,
At least these tests appear to be failing because of extra lines in the error
output (showing test names with a line or two from jtr file):
Thanks. I think the difference here compared to 8196741 is that these
tests fail due to ext
David,
At least these tests appear to be failing because of extra lines in the error
output (showing test names with a line or two from jtr file):
java/io/File/DeleteOnExitNPE.java
java.lang.RuntimeException: Failed: No output should have been received
from the process
java/lang/Process
Hello,
On 2019-01-09 11:29, Andrew Luo wrote:
Hi Erik,
Looks good to me also (not a reviewer though, thought I'd chime in since I've
worked a bit with WSL)
Thanks, I appreciate your input!
One question:
This line: MAKE_EXPECTED_ENV='x86_64-.*-linux-gnu' - what other strings did you
see oth
Hi Erik,
Looks good to me also (not a reviewer though, thought I'd chime in since I've
worked a bit with WSL)
One question:
This line: MAKE_EXPECTED_ENV='x86_64-.*-linux-gnu' - what other strings did you
see other than -pc- - just asking out of curiosity.
Thanks,
-Andrew
-Original Messa
Erik:
Looks good to me.
/Tim
On 01/09/19 10:14, Erik Joelsson wrote:
The WSL support in the build does not currently work with devkits. This
prevents us from using Jib to configure a WSL build. This patch fixes
configure to work with devkits when building for Windows in WSL.
(For Oracle users
The WSL support in the build does not currently work with devkits. This
prevents us from using Jib to configure a WSL build. This patch fixes
configure to work with devkits when building for Windows in WSL.
(For Oracle users, I also managed to get Jib working in WSL, and able to
configure both
Looks good to me.
/Erik
On 2019-01-08 10:35, Alexandre (Shura) Iline wrote:
Hi,
Could you please take a look on a change which allows to run tests while
collecting code coverage with JCov. This is a continuation of work done in
JDK-8214309: Enhance makefiles to allow generating JCov instrumen
Looks good.
/Erik
On 2019-01-08 23:11, Jonathan Gibbons wrote:
Please review a small edit to a regular expression used to detect the
name of a tool in a man page.
Here's the inline version of the patch:
$ hg diff -R open
diff -r 28ec06beb091 make/scripts/pandoc-html-manpage-filter.js
--- a/m
