Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

+1 Thanks Vladimir > On Jan 18, 2019, at 5:29 PM, Igor Ignatev wrote: > > Still looks good to me. > > — Igor > >> On Jan 18, 2019, at 5:26 PM, Vladimir Ivanov >> wrote: >> >> Updated webrev: >> http://cr.openjdk.java.net/~vlivanov/8217404/webrev.01 >> >> Verified that it works as expec

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

Still looks good to me. — Igor > On Jan 18, 2019, at 5:26 PM, Vladimir Ivanov > wrote: > > Updated webrev: > http://cr.openjdk.java.net/~vlivanov/8217404/webrev.01 > > Verified that it works as expected on Linux, Windows, MacOS, and Solaris. > > Best regards, > Vladimir Ivanov > >> On 18/

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

Updated webrev: http://cr.openjdk.java.net/~vlivanov/8217404/webrev.01 Verified that it works as expected on Linux, Windows, MacOS, and Solaris. Best regards, Vladimir Ivanov On 18/01/2019 16:39, Vladimir Ivanov wrote: Thanks, Igor. overall your fix looks reasonable, but w/ it we can get u

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

Thanks, Igor. overall your fix looks reasonable, but w/ it we can get unintentionally disabled features (b/c grep doesn't do full word match). although this problem wasn't really introduced by your fix, I think it's be better to fix it as a part of your patch. I see two possible solutions:

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

Thanks, Vladimir. I usually used --with-jvm-features=-aot,-jvmci,-graal Did not work in this case too? I didn't know it supports comma-separated list, but it doesn't work as well: $ bash configure --with-jvm-features="-aot,-jvmci,-graal" checking if jvmci module jdk.internal.vm.ci should

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

Hi Vladimir, overall your fix looks reasonable, but w/ it we can get unintentionally disabled features (b/c grep doesn't do full word match). although this problem wasn't really introduced by your fix, I think it's be better to fix it as a part of your patch. I see two possible solutions: - a

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

I usually used --with-jvm-features=-aot,-jvmci,-graal Did not work in this case too? Anyway your fix is good. Thanks, Vladimir On 1/18/19 3:33 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8217404/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8217404 --with-jvm-featur

[13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

http://cr.openjdk.java.net/~vlivanov/8217404/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8217404 --with-jvm-features doesn't work properly when multiple features are explicitly disabled: $ bash configure --with-jvm-features="-aot -jvmci -graal" ... checking if jvmci module jdk.internal

RFR 8217357: Implement JCov jib profiles

Hi. Please take a look on a change which is adding new jib profiles to support make changes introduced by JDK-8214309. Bug: https://bugs.openjdk.java.net/browse/JDK-8217357 Webrev: http://cr.openjdk.java.net/~shurailine/8217357/webrev.02/ Thank you. Shura

Re: OpenJDK 11.0.2 cannot build on Solaris 11.4

On 2019-01-18 10:17, Rob Petti wrote: Thanks, Erik! I tried the createSolarisDevkit12.4.sh script, but none of the packages in that list exist in the package manager at those specific versions, so it just fails. I basically had to make my own list of packag

Re: OpenJDK 11.0.2 cannot build on Solaris 11.4

Thanks, Erik! I tried the createSolarisDevkit12.4.sh script, but none of the packages in that list exist in the package manager at those specific versions, so it just fails. I basically had to make my own list of packages from scratch using the existing one as a guideline. Zones sound like a clea

Re: OpenJDK 11.0.2 cannot build on Solaris 11.4

Hello Rob, On 2019-01-17 13:57, Rob Petti wrote: Hey Folks, I've discovered that OpenJDK 11 cannot be built on Solaris 11.4. Normally we would just try to rebuild our system as 11.1, but that's not possible since media for that base release is no longer available. Are there plans to support co

Re: RFR(13): JDK-8216263: Add historical data for JDK 12

Adding build-dev. Jan On 17.1.2019 19:53, Jan Lahoda wrote: On 17.1.2019 17:58, Jonathan Gibbons wrote: Re: 36 # The checkout must not have any local changes that could interfere with the new data. In particular, 37 # there must be absolutely no changed, new or removed files under t

Re: RFR: JDK-8217335: Add a script to generate --release data

Hi Magnus, Thanks for the comments, an updated webrev: http://cr.openjdk.java.net/~jlahoda/8217335/webrev.01/ (Includes changes suggested by Joe was well). Jan On 18.1.2019 13:59, Magnus Ihse Bursie wrote: On 2019-01-17 19:51, Jan Lahoda wrote: Hi, As suggested here: https://mail.openjdk.ja

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation (update 2)

On 2019-01-17 16:06, Andy Herrick wrote: If I remove the line -nologo from lib-jdk.jpackage.gmk: 69 LDFLAGS_windows := -nologo, \ I get the logo during build (same with console andnon-console version): Microsoft (R) Incremental Linker Version 14.12.25835.0 Copyright (C) Microsoft Corp

Re: RFR: JDK-8217335: Add a script to generate --release data

On 2019-01-17 19:51, Jan Lahoda wrote: Hi, As suggested here: https://mail.openjdk.java.net/pipermail/compiler-dev/2019-January/012876.html This is a separate patch that adds a script to generate --release N data. Webrev: http://cr.openjdk.java.net/~jlahoda/8217335/webrev.00/ JBS: https://b