RFR: JDK-8217317 : Create jpackage native library for windows

2019-01-31 Thread Alexander Matveev
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - jpackage launcher will now build same as Linux and OS X using SetupBuildLauncher. - jpackage.dll was added based on Windows jpackage.exe launcher

Re: RFR : 8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

2019-01-31 Thread David Holmes
Hi Matthias, On 1/02/2019 12:50 am, Baesken, Matthias wrote: Please review this small webrev . It contains a few changes for building hotspot on AIX with xlclang++ / xlc16 . ( most likely switching to xlclang++ / xlc16will be a must once we introduce C++11/14 features ) Some

Re: RFR: JDK-8218177: Bump jib format_version to support new devkit archive layout

2019-01-31 Thread Tim Bell
Erik: With the new devkits I deployed recently (Oracle internal), the file layout changed as a top level directory inside the tar archive was introduced. This works in most cases, but there are certain situations where jib does not handle this well. This causes AOT testing on Linux to stop

Re: RFR: JDK-8218177: Bump jib format_version to support new devkit archive layout

2019-01-31 Thread Christian Tornqvist
Looks good. Thanks, Christian > On Jan 31, 2019, at 4:23 PM, Erik Joelsson wrote: > > With the new devkits I deployed recently (Oracle internal), the file layout > changed as a top level directory inside the tar archive was introduced. This > works in most cases, but there are certain

RFR: JDK-8218177: Bump jib format_version to support new devkit archive layout

2019-01-31 Thread Erik Joelsson
With the new devkits I deployed recently (Oracle internal), the file layout changed as a top level directory inside the tar archive was introduced. This works in most cases, but there are certain situations where jib does not handle this well. This causes AOT testing on Linux to stop working

Re: RFR : 8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

2019-01-31 Thread Magnus Ihse Bursie
Ah, IBM is starting to use clang? That's nice! From what I understand after a quick search, this also means that gcc/clang options are available, and recommended [1] to use. It would be really nice if we could align the xlc options more closely to gcc/clang. /Magnus [1]

Re: Proposal: JDK-8217896: Make better use of LCPUs when building on AIX

2019-01-31 Thread Magnus Ihse Bursie
> 31 jan. 2019 kl. 16:01 skrev Andrew Leonard : > > Hiya, > I've created and tested a new webrev using lparstat and following your > guidelines, webrev.01 is here: > http://cr.openjdk.java.net/~aleonard/8217896/webrev.01/ > If someone is happy to sponsor and review please? This looks

Re: Proposal: JDK-8217896: Make better use of LCPUs when building on AIX

2019-01-31 Thread Andrew Leonard
Hiya, I've created and tested a new webrev using lparstat and following your guidelines, webrev.01 is here: http://cr.openjdk.java.net/~aleonard/8217896/webrev.01/ If someone is happy to sponsor and review please? Many thanks Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM

RFR : 8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

2019-01-31 Thread Baesken, Matthias
Please review this small webrev . It contains a few changes for building hotspot on AIX with xlclang++ / xlc16 . ( most likely switching to xlclang++ / xlc16will be a must once we introduce C++11/14 features ) Some comments on the changes : - porting_aix.cpp : workaround

Re: RFR: JDK-8204564: Need better error output when GenerateLinkOptData fails

2019-01-31 Thread Magnus Ihse Bursie
On 2019-01-30 19:45, Erik Joelsson wrote: Here is a new webrev: http://cr.openjdk.java.net/~erikj/8204564/webrev.02/ Looks good to me! /Magnus /Erik On 2019-01-30 08:52, Erik Joelsson wrote: Hello, On 2019-01-30 01:51, Magnus Ihse Bursie wrote: On 2019-01-30 02:18, Erik Joelsson wrote: