Looks fine.
On 28/02/2019 17:55, Philip Race wrote:
Oh yes we should :-). Good catch.
The license isn't changed so its a small matter of changing what version we
list in the file.
http://cr.openjdk.java.net/~prr/8210782.1
-phil.
On 2/28/19, 4:58 PM, Sergey Bylokhov wrote:
Hi, Phil.
Should we
Thanks Magnus and Andrew Dinn for your kind review.
On 2019年03月01日 22:47, Magnus Ihse Bursie wrote:
On 2019-03-01 15:39, Andrew Dinn wrote:
On 01/03/2019 14:25, Magnus Ihse Bursie wrote:
On 2019-02-27 03:25, Jie Fu wrote:
It's a bit difficult for me to test this patch since I don't have a
sp
That's great!
Thanks Adrian.
On 2019年03月01日 22:29, John Paul Adrian Glaubitz wrote:
Hello!
On 3/1/19 3:25 PM, Magnus Ihse Bursie wrote:
It's a bit difficult for me to test this patch since I don't have a sparc or
arm machine.
Both SPARC and AArch64 machines running Linux can be accessed th
Erik:
This change bumps the Windows devkit version used for Oracle internal
builds of the JDK to one based on Visual Studio 2017 15.9.6. In the
generator script, I removed the conditionals around subsections to force
the script to always generate the full kit. I've also made it a bit more
automa
Erik:
This change bumps the Macosx devkit version used for Oracle internal
builds of the JDK to one based on Xcode 10.1. I've also made the
generator script a bit more automatic in detecting the versions. The old
generator script for Xcode 6 is hardly relevant anymore so removing that.
Bug: htt
On 03/01/2019 05:32 AM, Magnus Ihse Bursie wrote:
I think we should really get rid of sjavac since the relevant
benefits are already present in the default build, with the javac
server and the dependency plugin. The only possible benefit of sjavac
today would be more fine grained increment
On 2/27/19 3:51 PM, Erik Joelsson wrote:
> The server is started lazily by the first javac invocation that needs
> it. There is a parameter given to javac that describes how it should be
> started, but to get the exact command line, you would have to instrument
> javac java source. You should be
This change bumps the Windows devkit version used for Oracle internal
builds of the JDK to one based on Visual Studio 2017 15.9.6. In the
generator script, I removed the conditionals around subsections to force
the script to always generate the full kit. I've also made it a bit more
automatic i
This change bumps the Macosx devkit version used for Oracle internal
builds of the JDK to one based on Xcode 10.1. I've also made the
generator script a bit more automatic in detecting the versions. The old
generator script for Xcode 6 is hardly relevant anymore so removing that.
Bug: https://
Hello Magnus,
This looks really nice! The only thing I would wish for would be that
you took some of the documentation you provided in this review mail and
added it to Execute.gmk.
Concerning the future "chmod" post commands, I think those should just
be add as something like " ; chmod $$@ "
Build changes look good.
/Erik
On 2019-02-28 16:12, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8210782
Webrev: http://cr.openjdk.java.net/~prr/8210782/
This change upgrades JDK 13 from using harfbuzz v 1.8.1 to v 2.3.1
which is currently the latest release of harfbuzz
On 2019-03-01 15:39, Andrew Dinn wrote:
On 01/03/2019 14:25, Magnus Ihse Bursie wrote:
On 2019-02-27 03:25, Jie Fu wrote:
It's a bit difficult for me to test this patch since I don't have a
sparc or arm machine.
I've analyzed the adlc processing logic in
make/hotspot/gensrc/GensrcAdlc.gmk findi
On 01/03/2019 14:25, Magnus Ihse Bursie wrote:
> On 2019-02-27 03:25, Jie Fu wrote:
>> It's a bit difficult for me to test this patch since I don't have a
>> sparc or arm machine.
>> I've analyzed the adlc processing logic in
>> make/hotspot/gensrc/GensrcAdlc.gmk finding that ad-files under
>> ./sr
On 2019-03-01 15:20, Baesken, Matthias wrote:
* I suspect we should stop referring to using the system package
installer for the boot jdk, and instead
* point to http://jdk.java.netfor the core platforms, and
https://adoptopenjdk.net/for the rest.
Hi Magnus , for OpenJDK11 (11u)
Hello!
On 3/1/19 3:25 PM, Magnus Ihse Bursie wrote:
>> It's a bit difficult for me to test this patch since I don't have a sparc or
>> arm machine.
Both SPARC and AArch64 machines running Linux can be accessed through the gcc
compile farm. Any open source developer can request an account for thes
On 2019-02-27 03:25, Jie Fu wrote:
Hi Tobias,
Thanks a lot for your review.
It's a bit difficult for me to test this patch since I don't have a
sparc or arm machine.
I've analyzed the adlc processing logic in
make/hotspot/gensrc/GensrcAdlc.gmk finding that ad-files under
./src/hotspot/os_cpu
* I suspect we should stop referring to using the system package installer
for the boot jdk, and instead
* point to http://jdk.java.net for the core platforms, and
https://adoptopenjdk.net/ for the rest.
Hi Magnus , for OpenJDK11 (11u) we might mention the packages . For the
jdk
Hi Magnus ,
* Have you verified that this actually works? E.g. by starting in a fresh
SUSE installation, running configure,
* and then running the corresponding line and noticing that this helped
configure get further on? Or did you just copy the yum/apt package names?
A bit of both
On 2019-03-01 14:46, Magnus Ihse Bursie wrote:
On 2019-03-01 09:48, Baesken, Matthias wrote:
Btw. Speaking about help.m4 help output , the mentioning of
openjdk-8-jdk in the various package-installer help outputs seems
to be outdated and misleading to me :
88 apt_help() {
89 cas
On 2019-03-01 09:48, Baesken, Matthias wrote:
Btw. Speaking about help.m4 help output , the mentioning of openjdk-8-jdk
in the various package-installer help outputs seems to be outdated and
misleading to me :
88 apt_help() {
89 case $1 in
. . .
94 openjdk)
95
On 2019-02-28 13:53, Baesken, Matthias wrote:
Hello, please review the following change .
Currently the configure-step outputs help for a number of packages +
related installation calls in case of missing dependencies (like cups / alsa
etc.) .
This help output step covers a few to
On 2019-02-28 09:13, Ao Qi wrote:
Hi,
Test jobs setting for sparc is different with x86 (JDK-8211727).
Besides, test jobs setting is based on memory size (JDK-8214003). The
test documentation fails to mention these and needs update.
Bug: https://bugs.openjdk.java.net/browse/JDK-8219906
Webrev:
On 2019-02-27 16:51, Erik Joelsson wrote:
Hello Andrew,
On 2019-02-26 12:09, Andrew Haley wrote:
I'm seeing a crash in the javac server while building openjdk.
We are seeing this too intermittently.
I want to run the exact same command that started the server running,
but even with LOG=debug
On 2019-03-01 01:12, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8210782
Webrev: http://cr.openjdk.java.net/~prr/8210782/
Looks good from a build PoV.
/Magnus
This change upgrades JDK 13 from using harfbuzz v 1.8.1 to v 2.3.1
which is currently the latest release of har
The most important operations performed by the build system is
generalized into various Setup functionality, which forms the API
on top of which the rest of the build system is erected.
However, we have a long tail with various small operations, calling a
specific build tool, etc, that are don
Hi Phil , are you aware of any minimum compiler version requirements coming
with HarfBuzz 2.3.1 ?
Best regards, Matthias
> From: Philip Race
> To: 2d-dev <[email protected]>, build-dev
>
> Subject: RFR: 8210782: Upgrade HarfBuzz to the latest 2.3.1
> Message-ID: <5c787909.
Btw. Speaking about help.m4 help output , the mentioning of openjdk-8-jdk
in the various package-installer help outputs seems to be outdated and
misleading to me :
88 apt_help() {
89 case $1 in
. . .
94 openjdk)
95 PKGHANDLER_COMMAND="sudo apt-get install openjdk
27 matches
Mail list logo
