Re: RFR: JDK-8220383: Incremental build is broken and inefficient

2019-03-11 Thread Tim Bell
Erik: Looks good to me. Tim Our incremental build performance has degraded a lot recently. On Windows it's especially bad (as usual). There are multiple issues. Some cases of running way too many find/grep during rule setup. Some files get rebuilt on every incremental build. With all these cha

RFR: JDK-8220379: Fix doclint handling of headings

2019-03-11 Thread Jonathan Gibbons
Please review a moderately simple fix to improve doclint's checking of headings in doc comments. Build folk: by default, the improved checking causes build issues until the doc comments in some modules can be updated. To workaround that, the doclint options in the build have been modified. It

Re: RFR: JDK-8220379: Fix doclint handling of headings

2019-03-11 Thread Jonathan Gibbons
On 03/11/2019 02:11 PM, Jonathan Gibbons wrote: Please review a moderately simple fix to improve doclint's checking of headings in doc comments. Build folk: by default, the improved checking causes build issues until the doc comments in some modules can be updated. To workaround that, the

RFR: JDK-8220383: Incremental build is broken and inefficient

2019-03-11 Thread Erik Joelsson
Our incremental build performance has degraded a lot recently. On Windows it's especially bad (as usual). There are multiple issues. Some cases of running way too many find/grep during rule setup. Some files get rebuilt on every incremental build. With all these changes, the incremental build w

Re: [PATCH] Support for side by side MSVC Toolset versions

2019-03-11 Thread Ali Ince
Hi Erik, Thanks for sponsoring this improvement. I think it will improve build environments for different versions of OpenJDK. Yes, I have signed OCA. Sorry for the typos, and it definitely looks ok to me. Best regards, Ali > On 11 Mar 2019, at 17:26, Erik Joelsson wrote: > > Hello Ali, >

Re: [PATCH] Support for side by side MSVC Toolset versions

2019-03-11 Thread Erik Joelsson
Hello Ali, This looks like an excellent improvement! I had no idea of this ability in Visual Studio and am very pleased to learn of it. First of all, have you signed the OCA? I took your patch for a spin. I noticed that line 256 looked weird and corrected it to refer to the variable with_msv

Re: [8u] RFR: 8219772: EXTRA_CFLAGS not being picked up for assembler files

2019-03-11 Thread Severin Gehwolf
On Mon, 2019-03-11 at 09:27 -0700, Erik Joelsson wrote: > I think that's ok. Thanks for the review, Erik! Cheers, Severin > /Erik > > On 2019-03-11 03:45, Severin Gehwolf wrote: > > Hi, > > > > Could somebody please review this one-liner change for the 8u (OpenJDK) > > build system? The issue

Re: RFR (S) 8220363: hotspot-ide project fails

2019-03-11 Thread Erik Joelsson
Looks good, thanks for finding and fixing it! /Erik On 2019-03-11 05:21, Schmelter, Ralf wrote: Hi, the introduction of SetupExecute broke the hotspot-ide-project target on Windows. Webrev: http://cr.openjdk.java.net/~rschmelter/webrevs/8220363/webrev.0/ Bug: https://bugs.openjdk.java.net/br

Re: [8u] RFR: 8219772: EXTRA_CFLAGS not being picked up for assembler files

2019-03-11 Thread Erik Joelsson
I think that's ok. /Erik On 2019-03-11 03:45, Severin Gehwolf wrote: Hi, Could somebody please review this one-liner change for the 8u (OpenJDK) build system? The issue at hand is that for assembler source files extra C flags are not being passed to the compiler (GCC in the Linux case). This i

Re: Move definition of JAVA_VERSION_INFO_RESOURCE to Launcher-java.base.gmk?

2019-03-11 Thread Erik Joelsson
I hadn't realized that it was only used there, but since it is, I wouldn't mind moving the definition. /Erik On 2019-03-11 01:43, Langer, Christoph wrote: Hi, I found that the variable JAVA_VERSION_INFO_RESOURCE gets defined in make/launcher/LauncherCommon.gmk, while it is only used in make

RE: RFR (S) 8220363: hotspot-ide project fails

2019-03-11 Thread Langer, Christoph
Hi Ralf, thanks for proposing this fix. It looks good to me. Someone from the build group should review it, too. I can then push it. Best regards Christoph > -Original Message- > From: build-dev On Behalf Of > Schmelter, Ralf > Sent: Montag, 11. März 2019 13:22 > To: build-dev@openjd

RFR (S) 8220363: hotspot-ide project fails

2019-03-11 Thread Schmelter, Ralf
Hi, the introduction of SetupExecute broke the hotspot-ide-project target on Windows. Webrev: http://cr.openjdk.java.net/~rschmelter/webrevs/8220363/webrev.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8220363 Best regards, Ralf

Re: RFR (S) 8074817: Resolve disabled warnings for libverify

2019-03-11 Thread Aleksey Shipilev
On 3/10/19 1:17 PM, Alan Bateman wrote: > On 08/03/2019 17:35, Aleksey Shipilev wrote: >> Bug: >>    https://bugs.openjdk.java.net/browse/JDK-8074817 >> >> Fix: >>    http://cr.openjdk.java.net/~shade/8074817/webrev.03/ >> >> This hopefully resolves warnings in libverify. See bug report for warning

[8u] RFR: 8219772: EXTRA_CFLAGS not being picked up for assembler files

2019-03-11 Thread Severin Gehwolf
Hi, Could somebody please review this one-liner change for the 8u (OpenJDK) build system? The issue at hand is that for assembler source files extra C flags are not being passed to the compiler (GCC in the Linux case). This is a problem for instrumented builds to facilitate checks on produced bina

Move definition of JAVA_VERSION_INFO_RESOURCE to Launcher-java.base.gmk?

2019-03-11 Thread Langer, Christoph
Hi, I found that the variable JAVA_VERSION_INFO_RESOURCE gets defined in make/launcher/LauncherCommon.gmk, while it is only used in make/launcher/Launcher-java.base.gmk for the java and javaw launchers. I thought it would make sense to move its definition into Launcher-java.base.gmk to keep it