Erik:
Looks good.
Tim
In JDK-8220529 I managed to break the test image build. This patch fixes
that. It's still being verified as I'm sending this.
In JDK-8220529 I moved some of the logic in JtregNative*.gmk into
conditionals to avoid re-evaluating those expensive parts when building
images.
In JDK-8220529 I managed to break the test image build. This patch fixes
that. It's still being verified as I'm sending this.
In JDK-8220529 I moved some of the logic in JtregNative*.gmk into
conditionals to avoid re-evaluating those expensive parts when building
images. The problem with this
Thanks, Erik, for the review.
/Christoph
From: Erik Joelsson
Sent: Dienstag, 12. März 2019 15:53
To: Langer, Christoph ; [email protected]
Subject: Re: RFR(XS): 8220504: Move definition of JAVA_VERSION_INFO_RESOURCE to
Launcher-java.base.gmk
Looks good.
/Erik
On 2019-03-12 07:15, La
Looks good.
/Erik
On 2019-03-12 07:15, Langer, Christoph wrote:
Hi,
as per the mail discussion yesterday
(https://mail.openjdk.java.net/pipermail/build-dev/2019-March/025127.html),
please review the change to move the definition of
JAVA_VERSION_INFO_RESOURCE to Launcher-java.base.gmk.
Bu
Build change looks ok.
/Erik
On 2019-03-11 14:12, Jonathan Gibbons wrote:
On 03/11/2019 02:11 PM, Jonathan Gibbons wrote:
Please review a moderately simple fix to improve doclint's checking
of headings in doc comments.
Build folk: by default, the improved checking causes build issues
unti
Hi,
as per the mail discussion yesterday
(https://mail.openjdk.java.net/pipermail/build-dev/2019-March/025127.html),
please review the change to move the definition of JAVA_VERSION_INFO_RESOURCE
to Launcher-java.base.gmk.
Bug: https://bugs.openjdk.java.net/browse/JDK-8220504
Webrev: http://cr.