Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-22 Thread Leslie Zhai
Hi, JBS: https://bugs.openjdk.java.net/browse/JDK-8221357 Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.00/ Cheers, Leslie Zhai 在 2019年03月22日 15:10, jingtian 写道: Hi, `cd test && make` is not supported any more. It might be better to update jdk/doc . Cheers, JingTian

Re: RFR: JDK-8220445: Support for side by side MSVC Toolset versions

2019-03-22 Thread Tim Bell
Erik: Sorry, forgot about this. Since I modified that patch, I need another reviewer before I can push it. So, anyone interested in reviewing this? Webrev: http://cr.openjdk.java.net/~erikj/8220445/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8220445 Looks good. Tim /Erik On

Re: RFR: JDK-8220445: Support for side by side MSVC Toolset versions

2019-03-22 Thread Tim Bell
Erik: Sorry, forgot about this. Since I modified that patch, I need another reviewer before I can push it. So, anyone interested in reviewing this? Webrev: http://cr.openjdk.java.net/~erikj/8220445/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8220445 /Erik On 2019-03-19 13

Re: RFR: JDK-8221179: Zero builds fail when linking with gold and bundling libffi.so

2019-03-22 Thread Tim Bell
Erik: On 03/22/19 02:17, Severin Gehwolf wrote: On Thu, 2019-03-21 at 09:05 -0700, Erik Joelsson wrote: This patch adds a missing RPATH to libjvm.so which is needed when bundling libffi.so for zero builds. The rpath is only added when building zero and bundling of libffi is enabled. When linkin

RE: RFR [11u] : 8221318: [11u] do not disable c99 on Solaris

2019-03-22 Thread Lindenmaier, Goetz
Looks good to me, thanks for downporting. Best regards, Goetz. > -Original Message- > From: jdk-updates-dev On > Behalf Of Langer, Christoph > Sent: Freitag, 22. März 2019 10:32 > To: Baesken, Matthias ; 'build- > [email protected]' ; jdk-updates- > [email protected] > Subject:

RE: RFR [11u] : 8221318: [11u] do not disable c99 on Solaris

2019-03-22 Thread Baesken, Matthias
> I assume you have run it through our build/test infrastructure and see no > regressions... Yes it is in our build+test queue for jdk11u-dev . > For your case, I've set fix version of JDK-8221318 to 11-pool. Then hgupdater > will pick it up and resolve it for the right release. Maybe you ping

RE: RFR [11u] : 8221318: [11u] do not disable c99 on Solaris

2019-03-22 Thread Langer, Christoph
Hi Matthias, first of all: The change looks good to me, +1. I assume you have run it through our build/test infrastructure and see no regressions... As for the process: In your case, you want to backport a change and the original patch does not apply cleanly. For that scenario, you don't have t

Re: RFR: JDK-8221179: Zero builds fail when linking with gold and bundling libffi.so

2019-03-22 Thread Severin Gehwolf
On Thu, 2019-03-21 at 09:05 -0700, Erik Joelsson wrote: > This patch adds a missing RPATH to libjvm.so which is needed when > bundling libffi.so for zero builds. The rpath is only added when > building zero and bundling of libffi is enabled. When linking with bfd > (the old binutils linker), it

RFR [11u] : 8221318: [11u] do not disable c99 on Solaris

2019-03-22 Thread Baesken, Matthias
Hello, please review this change. It is a downport of jdk13 change https://bugs.openjdk.java.net/browse/JDK-8215710 to 11u . JDK-8215710 removed the disabling of C99 on Solaris in jdk13. Reason was : "Currently we disable C99 in the Solaris build by setting -xc99=%none%. This differs

RFC: Update test documentation by deleting "cd test && make"

2019-03-22 Thread jingtian
Hi, `cd test && make` is not supported any more. It might be better to update  jdk/doc . Cheers, JingTian