On 25/03/2019 4:23 pm, Jing Tian wrote:
Hi David,
Thanks for your review.
Could you please sponsor it for me?
Sure - once someone from the build team also gives the okay.
David
Thanks a lot.
Cheers,
JingTian
在 2019/3/25 11:59, David Holmes 写道:
Looks good to me!
Thanks,
David
-
On
Hi David,
Thanks for your review.
Could you please sponsor it for me?
Thanks a lot.
Cheers,
JingTian
在 2019/3/25 11:59, David Holmes 写道:
Looks good to me!
Thanks,
David
-
On 25/03/2019 1:41 pm, Leslie Zhai wrote:
Hi David,
Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.01/
Looks good to me!
Thanks,
David
-
On 25/03/2019 1:41 pm, Leslie Zhai wrote:
Hi David,
Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.01/
A patch by Jing Tian
He also fixed two existing grammar issues.
Please review it.
Thanks,
Leslie Zhai
Hi David,
Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.01/
A patch by Jing Tian
He also fixed two existing grammar issues.
Please review it.
Thanks,
Leslie Zhai
Hi David,
Thanks for your kind response!
> Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.00/
A patch by Jing Tian
I just help him to host his patch on my cr.openjdk.java.net.
> That seems fine to me. Could I ask you to also fix two existing
grammar issues...
Thanks for your revi
Hi Leslie,
On 23/03/2019 12:21 pm, Leslie Zhai wrote:
Hi,
JBS: https://bugs.openjdk.java.net/browse/JDK-8221357
Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.00/
That seems fine to me. Could I ask you to also fix two existing grammar
issues in the first line please:
Previousl
Hi,
Please review the fix for jdk 13.
bug: https://bugs.openjdk.java.net/browse/JDK-8217707
webrev: http://cr.openjdk.java.net/~aivanov/8217707/webrev.0/
Description:
Splash screen functionality is broken in 32 bit Windows. It's because
the functions in splashscreen.dll are exported with decor
