RE: [RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2019-03-26 Thread Langer, Christoph
Hi Andrew, thanks for doing this backport. I agree, Severin's finding needs to be added to hotspot's Unix/Posix vm.make files. Also, the additional printing of those variables in the Unixish buildtree.make files should be added to windows' make/windows/build.make in target $(variantDir)\local.

Re: [RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2019-03-26 Thread Severin Gehwolf
Hi Andrew, On Tue, 2019-03-26 at 01:59 +, Andrew John Hughes wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8189761 > Webrev(s): > https://cr.openjdk.java.net/~andrew/openjdk8/8189761/hotspot/ 105 CXXFLAGS/vm_version.o += ${JRE_VERSION} 106 CXXFLAGS/arguments.o += ${VERSION_CFLAGS}