Hi Erik and David,
Thank you for your review.
Erik, could you please sponsor it?
Thanks a lot.
Best regards,
Jie
On 2019/4/8 下午9:57, Erik Joelsson wrote:
Looks good to me.
/Erik
On 2019-04-08 00:48, Jie Fu wrote:
Hi David and Erik,
Thank you for your review and very nice suggestions.
Here
Hi Erik,
On 9/04/2019 8:08 am, Erik Joelsson wrote:
New webrev with "_simple_basename":
http://cr.openjdk.java.net/~erikj/8221851/webrev.05/
Given the usage is typically of the form:
Exceptions::_throw(THREAD_AND_LOCATION, e);
which will expand to:
Exceptions::_throw(THREAD, _simple_basen
Looks good - thanks for the updates, much clearer.
David
On 8/04/2019 5:48 pm, Jie Fu wrote:
Hi David and Erik,
Thank you for your review and very nice suggestions.
Here is the latest version:
http://cr.openjdk.java.net/~jiefu/8221894/webrev.03/
Please see comments inline and review.
Thanks
New webrev with "_simple_basename":
http://cr.openjdk.java.net/~erikj/8221851/webrev.05/
/Erik
On 2019-04-08 12:20, Erik Joelsson wrote:
On 2019-04-08 11:40, Kim Barrett wrote:
On Apr 8, 2019, at 10:28 AM, Erik Joelsson
wrote:
Hello,
On 2019-04-05 15:46, Kim Barrett wrote:
Assuming all t
Hi,
Could you please take a look on this enhancement which makes it easy to get
code coverage for a part of JDK code.
This change introduces “JCOV_FILTERS” make variable and also
"--with-jcov-filters” configuration option.
With that one is free to use any of JCov filtering options to limit
On 2019-04-08 11:40, Kim Barrett wrote:
On Apr 8, 2019, at 10:28 AM, Erik Joelsson wrote:
Hello,
On 2019-04-05 15:46, Kim Barrett wrote:
Assuming all that, consider instead putting this_file_helper in
exceptions.hpp (perhaps with a better name?), don't bother with
THIS_FILE, and define THREAD
Looks fine.
On 24/03/2019 12:18, Alexey Ivanov wrote:
Hi,
Please review the fix for jdk 13.
bug: https://bugs.openjdk.java.net/browse/JDK-8217707
webrev: http://cr.openjdk.java.net/~aivanov/8217707/webrev.0/
Description:
Splash screen functionality is broken in 32 bit Windows. It's because th
> On Apr 8, 2019, at 10:28 AM, Erik Joelsson wrote:
>
> Hello,
>
> On 2019-04-05 15:46, Kim Barrett wrote:
>> Assuming all that, consider instead putting this_file_helper in
>> exceptions.hpp (perhaps with a better name?), don't bother with
>> THIS_FILE, and define THREAD_AND_LOCATION as
>>
>>
On 04/08/19 07:28, Erik Joelsson wrote:
> I'm now looking for another Hotspot reviewer.
>
> http://cr.openjdk.java.net/~erikj/8221851/webrev.04/
I'm not a Hotspot Reviewer, however the build changes look good FWIW.
Tim
Hello,
On 2019-04-05 15:46, Kim Barrett wrote:
On Apr 5, 2019, at 11:09
Hello,
On 2019-04-05 15:46, Kim Barrett wrote:
On Apr 5, 2019, at 11:09 AM, Erik Joelsson wrote:
So to make it clear. This patch now does the following:
* Removes the setting of -DTHIS_FILE=... from all compilation units involved in
building Hotspot.
* Introduces THIS_FILE as a macro in Hots
Looks good to me.
/Erik
On 2019-04-08 00:48, Jie Fu wrote:
Hi David and Erik,
Thank you for your review and very nice suggestions.
Here is the latest version:
http://cr.openjdk.java.net/~jiefu/8221894/webrev.03/
Please see comments inline and review.
Thanks a lot.
I have two comments on th
On 4/8/19 9:36 AM, Roman Kennke wrote:
> On 4/7/19 7:18 PM, Roman Kennke wrote:
>>> On 4/2/19 10:12 PM, Roman Kennke wrote:
> - No more need for object equals barriers.
I'm pleased about that. I really hated the AArch64 Shenandoah
CAS!
>>>
>>> I'm sorry to disappoint you, but the
On 4/7/19 7:18 PM, Roman Kennke wrote:
> > On 4/2/19 10:12 PM, Roman Kennke wrote:
> > > > - No more need for object equals barriers.
> > >
> > > I'm pleased about that. I really hated the AArch64 Shenandoah
> > > CAS!
> >
> > I'm sorry to disappoint you, but the CAS barrier is still needed.
> >
On 4/7/19 7:18 PM, Roman Kennke wrote:
> On 4/2/19 10:12 PM, Roman Kennke wrote:
>>> - No more need for object equals barriers.
>>
>> I'm pleased about that. I really hated the AArch64 Shenandoah CAS!
>
> I'm sorry to disappoint you, but the CAS barrier is still needed. The
> memory location may s
Hi David and Erik,
Thank you for your review and very nice suggestions.
Here is the latest version:
http://cr.openjdk.java.net/~jiefu/8221894/webrev.03/
Please see comments inline and review.
Thanks a lot.
I have two comments on the proposed text:
1. I think "oraclelinux" should be "Oracle L
15 matches
Mail list logo
