Re: RFR 8221857: Collect code coverage for a subset of code

Ok, thanks for clarifying, I agree and the current webrev looks good! /Erik On 2019-04-10 14:25, Alexandre (Shura) Iline wrote: Erik, JCOV_FILTERS variable is also used while building an instrumented image - with "jcov-image” make target. To completely prevent make form complaining, it looks

Re: RFR 8221857: Collect code coverage for a subset of code

Erik, JCOV_FILTERS variable is also used while building an instrumented image - with "jcov-image” make target. To completely prevent make form complaining, it looks like the variable would need to be added it to MAKE_CONTROL_VARIABLES in make/InitSupport.gmk. Which we could do, but, judging by

RE: RFR (S) Windows incremental build is broken with JDK-8217728

And done. 😊 > -Original Message- > From: Langer, Christoph > Sent: Mittwoch, 10. April 2019 17:13 > To: Erik Joelsson ; Schmelter, Ralf > ; [email protected] > Subject: RE: RFR (S) Windows incremental build is broken with JDK-8217728 > > Ok, about to do it now... > > > -Orig

RE: RFR (S) Windows incremental build is broken with JDK-8217728

Ok, about to do it now... > -Original Message- > From: Erik Joelsson > Sent: Mittwoch, 10. April 2019 17:03 > To: Langer, Christoph ; Schmelter, Ralf > ; [email protected] > Subject: Re: RFR (S) Windows incremental build is broken with JDK-8217728 > > This seems to be affecting

Re: RFR (S) Windows incremental build is broken with JDK-8217728

This seems to be affecting people quite severely already so please push this ASAP if possible. /Erik On 2019-04-10 07:17, Langer, Christoph wrote: Hi Ralf, looks good. I'll sponsor it for you. Best regards Christoph -Original Message- From: build-dev On Behalf Of Schmelter, Ralf S

RE: RFR (S) Windows incremental build is broken with JDK-8217728

Hi Ralf, looks good. I'll sponsor it for you. Best regards Christoph > -Original Message- > From: build-dev On Behalf Of > Schmelter, Ralf > Sent: Mittwoch, 10. April 2019 14:23 > To: [email protected] > Subject: [CAUTION] RFR (S) Windows incremental build is broken with JDK- >

Re: bash configure: result from running a microsoft compiler was empty string

Hello Vitaly, When configure fails recognize the version of CL it usually means that either CL didn't launch correctly or that a non English locale is used so we don't recognize the output. In this case, since the recorded output is empty, I'm guessing the former. The failing wslpath line coul

Re: RFR (S) Windows incremental build is broken with JDK-8217728

Looks good, thanks for finding and fixing this! /Erik On 2019-04-10 05:22, Schmelter, Ralf wrote: Hi, please review this small change which fixes the incremental build on Windows. I makes sure, that the generated dependency files can be concatenated into one big dependency file. webrev: htt

Re: bash configure: result from running a microsoft compiler was empty string

Hi Vitaly, I can build jdk/jdk on my WSL as following: - A new configuration has been successfully created in /mnt/c/OpenJDK/jdk/build/windows-x86_64-server-fastdebug using configure arguments '--enable-debug --disable-hotspot-gtest --with-boot-jdk=/mnt/c/jdk-12'. Configuration summary

RFR (S) Windows incremental build is broken with JDK-8217728

Hi, please review this small change which fixes the incremental build on Windows. I makes sure, that the generated dependency files can be concatenated into one big dependency file. webrev: http://cr.openjdk.java.net/~rschmelter/webrevs/864/ bugreport: https://bugs.openjdk.java.net/browse/J

RE: RFR (S): 8221979: Cleanups for building Windows resources

Thanks, Erik. I already checked and will check carefully once again before pushing. /Christoph > -Original Message- > From: Erik Joelsson > Sent: Dienstag, 9. April 2019 15:22 > To: Langer, Christoph ; build- > [email protected]; [email protected]; core-libs-dev > > Subj

Re: bash configure: result from running a microsoft compiler was empty string

HI David, Andrew, Thanks for the reply I ran /mnt/c/Tools/VS/2017/Community/VC/Tools/MSVC/14.16.27023/bin/Hostx64/x64/cl.exe directly, it produced the following log: $ /mnt/c/Tools/VS/2017/Community/VC/Tools/MSVC/14.16.27023/bin/Hostx64/x64/cl.exe Microsoft (R) C/C++ Optimizing Compiler Versi