Re: RFR: 8130017: use _FORTIFY_SOURCE in gcc fastdebug builds - was : RE: gcc FORTIFY_SOURCE application security flags

2019-05-08 Thread sgehwolf
Hi Matthias, For some background about the -O2 -ffp-contract=off flags for sharedRuntimeTrig.cpp and sharedRuntimeTrans.cpp see: https://bugs.openjdk.java.net/browse/JDK-8210425 My understanding is that if there is a per-file override of the optimization level, the compilation command will end up

Re: RFR: 8130017: use _FORTIFY_SOURCE in gcc fastdebug builds - was : RE: gcc FORTIFY_SOURCE application security flags

2019-05-08 Thread Erik Joelsson
Hello Matthias, On 2019-05-08 06:27, Baesken, Matthias wrote: Hello,I looked a bit more into it . It seems to me , that when -ffp-contract=off is available which is the case with current gcc versions , we want to optimize the 2 special files ( sharedRuntimeTrig.cpp / sharedRunti

RE: RFR: 8130017: use _FORTIFY_SOURCE in gcc fastdebug builds - was : RE: gcc FORTIFY_SOURCE application security flags

2019-05-08 Thread Baesken, Matthias
Hello,I looked a bit more into it . It seems to me , that when -ffp-contract=off is available which is the case with current gcc versions , we want to optimize the 2 special files ( sharedRuntimeTrig.cpp / sharedRuntimeTrans.cpp ). see the following comments : jdk/make/hotspot/li

RE: RFR: 8130017: use _FORTIFY_SOURCE in gcc fastdebug builds - was : RE: gcc FORTIFY_SOURCE application security flags

2019-05-08 Thread Baesken, Matthias
Hi David, thanks for the comment . Currently I do not see the issue in our fastdebug builds . So I think the opt-flag filtering got changed/removed in the years after the issues were reported . https://bugs.openjdk.java.net/browse/JDK-8047952 mentions special O-level settings for share

Re: RFR: 8130017: use _FORTIFY_SOURCE in gcc fastdebug builds - was : RE: gcc FORTIFY_SOURCE application security flags

2019-05-08 Thread David Holmes
Hi Matthias, On 8/05/2019 6:05 pm, Baesken, Matthias wrote: Hello, here is a webrev, I used the existing bug "JDK-8130017 : use _FORTIFY_SOURCE in gcc fastdebug builds" Hope that’s fine . That is fine, but please add a comment to the bug explaining exactly how you fixed the issue and how

RFR: 8130017: use _FORTIFY_SOURCE in gcc fastdebug builds - was : RE: gcc FORTIFY_SOURCE application security flags

2019-05-08 Thread Baesken, Matthias
Hello, here is a webrev, I used the existing bug "JDK-8130017 : use _FORTIFY_SOURCE in gcc fastdebug builds" Hope that’s fine . https://bugs.openjdk.java.net/browse/JDK-8130017 http://cr.openjdk.java.net/~mbaesken/webrevs/8130017.0/ Our internal OpenJDK Linux (x86_64, ppc64, ppc64le ,