Does this fix really work? If you do this in a shell then you lose the
second option:
> export ASAN_OPTIONS=handle_segv=0 detect_leaks=0
> echo $ASAN_OPTIONS
handle_segv=0
??
David
On 11/05/2019 10:43 am, Man Cao wrote:
Looks good.
-Man
*From: *Erik Joelsson
*Date: *Fri, May 10, 2019 at
Looks good.
/Erik
On 2019-05-10 09:02, Arthur Eubanks wrote:
Do you really need to use $(SPACE)? I would expect it to work with
just
removing the quotes.
You're right, no need for $(SPACE).
Updated webrev:
http://cr.openjdk.java.net/~aeubanks/8223667/webrev.01/index.html
Looks good!
Thanks,
Volker
On Fri, May 10, 2019 at 12:23 PM Baesken, Matthias
wrote:
>
> Hello, please review this small AIX - specific change .
>
> Currently we use by default the bundled zlib (= zlib coming with OpenJDK)
> on Windows, on other platforms the system zlib.
> However it is po
Looks good. Bonus points if you could also replace the ellipsis (...) in
the comment with a simple comma (,).
/Erik
On 2019-05-10 03:23, Baesken, Matthias wrote:
Hello, please review this small AIX - specific change .
Currently we use by default the bundled zlib (= zlib coming with OpenJDK)
Hello Matthias,
I think just -U_FORTIFY_SOURCE should be enough to unset it, no need to
also set it to 0. Also, I think it would be good to use an extra set of
variables to avoid repeating the flag, like this:
ENABLE_FORTIFY_CFLAGS="-D_FORTIFY_SOURCE=2"
DISABLE_FORTIFY_CFLAGS="-U_FORTIFY_SOUR
Hello Arthur,
Do you really need to use $(SPACE)? I would expect it to work with just
removing the quotes.
/Erik
On 2019-05-09 18:14, Arthur Eubanks wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8223667
Webrev: http://cr.openjdk.java.net/~aeubanks/8223667/webrev.00/index.html
The ASA
Hello, I wonder if some people already have looked into using Windows
"control flow guard" in OpenJDK,
and can share the info they got.
See :
https://docs.microsoft.com/en-us/windows/desktop/SecBP/control-flow-guard
"Control Flow Guard (CFG) is a highly-optimized platform security feature tha
Hello, please review this small AIX - specific change .
Currently we use by default the bundled zlib (= zlib coming with OpenJDK) on
Windows, on other platforms the system zlib.
However it is possible to switch to the bundled zlib in the configure process .
We had some build issues on AIX
