RFR: JDK-8224257 : fix issues in files generated by pandoc

2019-05-29 Thread Jonathan Gibbons
Please review a fix to provide a new build-time tool to fix up the output generated by the "pandoc" tool, which generates output that fails to meet all of our documentation standards. Post-processing the output was deemed a better solution than trying to modify the tool itself. Most of the wor

Re: RFR (XXS) 8224790: Remove Xusage.txt file

2019-05-29 Thread David Holmes
Thanks Mandy! David On 30/05/2019 7:19 am, Mandy Chung wrote: Looks good to me. Mandy On 5/25/19 1:49 PM, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8224790 webrev: http://cr.openjdk.java.net/~dholmes/8224790/webrev/ Before Java 7 the Xusage.txt file was used to print

Re: Failure buiilding OPEN JDK 11 on windows cygwin with VC 2017

2019-05-29 Thread David Holmes
Can you provide the configuration summary produced by configure? It's an issue with precompiled headers but I've no idea what. David On 30/05/2019 5:21 am, Moshe Zuisman wrote: I  thought, that may be probleem ressults form some specific configuration on my  machine (for example I have 2 versi

Re: RFR (XXS) 8224790: Remove Xusage.txt file

2019-05-29 Thread Mandy Chung
Looks good to me. Mandy On 5/25/19 1:49 PM, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8224790 webrev: http://cr.openjdk.java.net/~dholmes/8224790/webrev/ Before Java 7 the Xusage.txt file was used to print the "java -X" help information in English. From Java 7 this inf

Re: RFR: JDK-8224011: Failure handling in ExecuteWithLog fails in run-test-prebuilt

2019-05-29 Thread Tim Bell
Erik: When running tests using "make run-test-prebuilt", we bypass a lot of Init.gmk. One of the things we skip is initialization of the make-support/failure-logs dir. This causes make to print errors about failing to copy files into that directory if for example the AOT compilation fails, partl

RFR: JDK-8224011: Failure handling in ExecuteWithLog fails in run-test-prebuilt

2019-05-29 Thread Erik Joelsson
When running tests using "make run-test-prebuilt", we bypass a lot of Init.gmk. One of the things we skip is initialization of the make-support/failure-logs dir. This causes make to print errors about failing to copy files into that directory if for example the AOT compilation fails, partly hid

Re: Failure buiilding OPEN JDK 11 on windows cygwin with VC 2017

2019-05-29 Thread Moshe Zuisman
I thought, that may be probleem ressults form some specific configuration on my machine (for example I have 2 version of MSVCc - 2012 and 2017. So I created clean VmWare Virtual machine and installed their only MSVC 2017 and cygwin. And tried to build OPEN JDK theeir. and got exactly same failure

Re: RFR: 8223678: Add Visual Studio Code workspace generation support (for native code)

2019-05-29 Thread Erik Joelsson
Thanks, looks good! /Erik On 2019-05-29 06:52, Robin Westberg wrote: Hi Erik, Thanks for taking a look! On 28 May 2019, at 15:52, Erik Joelsson wrote: Hello Robin, Looks good. Adding of ide.md is very nice, but could you try to format it like testing.md and building.md in regards to lin

Re: RFR: 8224851: AArch64: fix warnings and errors with Clang and GCC 8.3

2019-05-29 Thread Kim Barrett
Not a review, just briefly jumping in because I noticed one thing to correct. > On May 29, 2019, at 9:12 AM, Andrew Haley wrote: > > On 5/29/19 11:26 AM, Nick Gasson wrote: > > Oh dear. Experience has shown me (and probably you, too) that this is > one of the most error-prone parts of software

Re: RFR: 8223678: Add Visual Studio Code workspace generation support (for native code)

2019-05-29 Thread Volker Simonis
On Wed, May 29, 2019 at 3:43 PM Robin Westberg wrote: > > Hi Volker, > > > On 28 May 2019, at 17:33, Volker Simonis wrote: > > > > Hi Robin, > > > > thanks a lot for doing this! > > > > I have just a quick question. Do you know if any of the VSC indexers > > (default, clangd) support call hierarc

Re: RFR: 8223678: Add Visual Studio Code workspace generation support (for native code)

2019-05-29 Thread Robin Westberg
Hi Erik, Thanks for taking a look! > On 28 May 2019, at 15:52, Erik Joelsson wrote: > > Hello Robin, > > Looks good. > > Adding of ide.md is very nice, but could you try to format it like testing.md > and building.md in regards to line lengths? I believe we are trying for 80 > chars in thos

Re: RFR: 8223678: Add Visual Studio Code workspace generation support (for native code)

2019-05-29 Thread Robin Westberg
Hi Volker, > On 28 May 2019, at 17:33, Volker Simonis wrote: > > Hi Robin, > > thanks a lot for doing this! > > I have just a quick question. Do you know if any of the VSC indexers > (default, clangd) support call hierarchies (i.e. "called by", > "callers" of a function/method) and "used by" f

RFR: 8224851: AArch64: fix warnings and errors with Clang and GCC 8.3

2019-05-29 Thread Andrew Haley
On 5/29/19 11:26 AM, Nick Gasson wrote: > Please review this set of fixes to building hotspot with GCC 8.3 or > Clang 7.0 on AArch64. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8224851 > Webrev: http://cr.openjdk.java.net/~ngasson/8224851/webrev.0/ > > Ran jtreg with no new failures. Oh

Re: RFR: 8224851: AArch64: fix warnings and errors with Clang and GCC 8.3

2019-05-29 Thread Andrew Haley
On 5/29/19 11:26 AM, Nick Gasson wrote: > Please review this set of fixes to building hotspot with GCC 8.3 or > Clang 7.0 on AArch64. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8224851 > Webrev: http://cr.openjdk.java.net/~ngasson/8224851/webrev.0/ > > Ran jtreg with no new failures. Oh

RFR: 8224851: AArch64: fix warnings and errors with Clang and GCC 8.3

2019-05-29 Thread Nick Gasson
Hi, Please review this set of fixes to building hotspot with GCC 8.3 or Clang 7.0 on AArch64. Bug: https://bugs.openjdk.java.net/browse/JDK-8224851 Webrev: http://cr.openjdk.java.net/~ngasson/8224851/webrev.0/ Ran jtreg with no new failures. This first one is with GCC 8.3: /home/nicgas01/jdk/