RFR: JDK-8223080: Build team code review requests.

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8223080 [2] http://cr.openjdk.java.net/~herrick/8223080/ /Andy

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

On Thu, Jun 6, 2019 at 10:49 AM Ao Qi wrote: > > On Thu, Jun 6, 2019 at 4:46 AM Erik Joelsson wrote: > > > > Here is a new webrev: http://cr.openjdk.java.net/~erikj/8217739/webrev.03 Another question: should "[bootcycle] " be displayed during make bootcycle-images? If yes, should we remove line

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

On Thu, Jun 6, 2019 at 4:46 AM Erik Joelsson wrote: > > Here is a new webrev: http://cr.openjdk.java.net/~erikj/8217739/webrev.03 I (as an Author) am ok with this fix. mips64el zero cross build passed and javac (to test open a file) worked. UnixConstants.java of build: .../usr/bin/cc -E -x c -I.

Re: JDK 14 RFR of JDK-8214546: Start of release updates for JDK 14

Right; after several rounds of refinement, it is tedious but not difficult to make the current set of mechanical changes. Adding the --release information in the initial push is a new improvement in this iteration. The factor that bounds how fast this work can be done is the build + test cyc

Re: JDK 14 RFR of JDK-8214546: Start of release updates for JDK 14

Looks good! Still a bunch of mechanical changes, but it’s far from obvious that spending more time automating this will save any significant time. Cheers, Mikael > On Jun 5, 2019, at 2:40 PM, Joseph D. Darcy wrote: > > Hello, > > Please have an early review the start-of-release builds updat

Re: JDK 14 RFR of JDK-8214546: Start of release updates for JDK 14

+1 :) David On 6/06/2019 8:00 am, Erik Joelsson wrote: The build changes look good, and I'm happy to see that we are now down to just changing the version-numbers file. /Erik On 2019-06-05 14:40, Joseph D. Darcy wrote: Hello, Please have an early review the start-of-release builds updates

Re: JDK 14 RFR of JDK-8214546: Start of release updates for JDK 14

The build changes look good, and I'm happy to see that we are now down to just changing the version-numbers file. /Erik On 2019-06-05 14:40, Joseph D. Darcy wrote: Hello, Please have an early review the start-of-release builds updates for JDK 14 ahead of the upcoming fork:     http://cr.op

JDK 14 RFR of JDK-8214546: Start of release updates for JDK 14

Hello, Please have an early review the start-of-release builds updates for JDK 14 ahead of the upcoming fork: http://cr.openjdk.java.net/~darcy/jdk14-fork.2/ Unlike previous start-of-release changesets, this one also includes the "symbol" data used by javac --release. After the next JD

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

Here is a new webrev: http://cr.openjdk.java.net/~erikj/8217739/webrev.03 The change is in buildjdk-spec.gmk.in where CPP is now also overridden. /Erik On 2019-06-05 10:33, Erik Joelsson wrote: Never mind, I found the issue. The reason it worked for me was that we set SYSROOT_CFLAGS for both t

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

Never mind, I found the issue. The reason it worked for me was that we set SYSROOT_CFLAGS for both the target and the build compiler (from using devkits for them). The preprocessor for the target would then act correctly given the --sysroot parameter pointing to a sysroot for the build system.

Re: RFR XXS,docs JDK-8225346: Convert file to HTML5

Looks good. /Erik On 2019-06-05 08:21, Jonathan Gibbons wrote: Please review a trivial fix to change the doctype for a file from HTML 4 to HTML 5. This gets the file off the doccheck radar. No webrev; patch below. -- Jon JBS: https://bugs.openjdk.java.net/browse/JDK-8225346 $ hg diff -R op

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

Hello Ao Qi, In my testing, I tried building ppc64le (which I first identified as generating a UnixConstants.java that differed from an x64 build). With this patch, the buildjdk and target version of UnixConstants.java differ the same way. How did you configure your build? I'm suspecting somet

Re: RFR XXS,docs JDK-8225346: Convert file to HTML5

+1 > On Jun 5, 2019, at 11:21 AM, Jonathan Gibbons > wrote: > > Please review a trivial fix to change the doctype for a file from HTML 4 to > HTML 5. This gets the file off the doccheck radar. > > No webrev; patch below. > > -- Jon > > JBS: https://bugs.openjdk.java.net/browse/JDK-8225346 >

RFR XXS,docs JDK-8225346: Convert file to HTML5

Please review a trivial fix to change the doctype for a file from HTML 4 to HTML 5. This gets the file off the doccheck radar. No webrev; patch below. -- Jon JBS: https://bugs.openjdk.java.net/browse/JDK-8225346 $ hg diff -R open diff -r f4df9d4201cc make/data/docs-resources/index.html --- a/

Re: Failure buiilding OPEN JDK 11 on windows cygwin with VC 2017

On 5/06/2019 5:40 pm, Moshe Zuisman wrote: Hi David. 2 questions. 1. I as was told here - downloaded JDK sources from http://hg.openjdk.java.net/jdk-updates/jdk11u/  .  I can not perform "hg update -r jdk-11.0.2-ga", since I get: "

Re: Failure buiilding OPEN JDK 11 on windows cygwin with VC 2017

Hi David. 2 questions. 1. I as was told here - downloaded JDK sources from http://hg.openjdk.java.net/jdk-updates/jdk11u/ . I can not perform "hg update -r jdk-11.0.2-ga", since I get: " "abort: no repository found in '/cygdrive/c/