Re: RFR: JDK-8065704 Set LC_ALL=C for all relevant commands in the build system

2019-10-02 Thread Martin Buchholz
I recall years ago running into troubles with regex character ranges, e.g. https://unix.stackexchange.com/questions/15980/does-should-lc-collate-affect-character-ranges but my build script wrapper has been setting LC_ALL=C for a long time, and I set LC_COLLATE=C in my normal use shell environment

Re: RFR: JDK-8065704 Set LC_ALL=C for all relevant commands in the build system

2019-10-02 Thread Erik Joelsson
Hello Magnus, The change looks good, but should perhaps also include removal of the few scattered specific instances of LANG=C and LC_ALL=C in the makefiles: make/common/JavaCompilation.gmk:    export LC_ALL=C ; ( $(CAT) $$< && $(ECHO) "" ) \ make/autoconf/basics.m4: 

Re: RFR: JDK-8065704 Set LC_ALL=C for all relevant commands in the build system

2019-10-02 Thread naoto . sato
Hi Magnus, Looks good to me. Although I cannot provide any reproducible problematic instance, there have been instances where native tools, such as `date` command had produced localized date, and the build failed to parse it in US format. Anyways, it is a good preventive measure to me.

RFR: JDK-8065704 Set LC_ALL=C for all relevant commands in the build system

2019-10-02 Thread Magnus Ihse Bursie
From the bug report: We should prefix LC_ALL=C for most, maybe all, tools we use when building. This probably means we should run "export LC_ALL=C" early in the configure script as well. --- The fix itself is trivial. While I know we've had several issues regarding localization, I could not

Re: RFR: JDK-8231505: Bump required boot jdk version to 13

2019-10-02 Thread Magnus Ihse Bursie
On 2019-10-01 23:37, Erik Joelsson wrote: With the release of JDK 13 it is now time to update the required boot jdk version for JDK 14 (to 13). This patch changes the configure requirements as well as bumps the version used for Jib builds at Oracle. Bug: