Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Hi, Dmitry. I suggest to make this block more generic, and describe the "### Client UI - Tests". It would be useful to mention that the tests in this category use different key combinations, which might be registered as a system shortcuts, and it could cause a test failure. It is suggested to

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Got it! Then I'd just drop the quotes from the key names: - `“CTRL” + “F1”` + `Ctrl + F1` On 25/10/2019 16:52, Erik Joelsson wrote: The HTML is generated from the markup and should not be edited by hand. /Erik -- Regards, Alexey

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

On 2019-10-25 08:42, Alexey Ivanov wrote: Hi Dmitry, Apple uses macOS to refer to its operating system, so should we also use it instead of former OS X? For HTML version, I would suggest using the following markup Ctrl +F1 for the keyboard shortcut. [1] The HTML is generated from the mark

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Hi Dmitry, Apple uses macOS to refer to its operating system, so should we also use it instead of former OS X? For HTML version, I would suggest using the following markup Ctrl +F1 for the keyboard shortcut. [1] I think using elements for instructions on how to disable the shortcut is inc

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

No need for new webrev. /Erik On 2019-10-25 06:45, Dmitry Markov wrote: Thank you for the review, Erik! I will update the fix as you suggested before push if you do not mind. Thanks, Dmitry On 25 Oct 2019, at 14:00, Erik Joelsson wrote: Looks good. I would put in a "the" before "operating

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Thank you for the review, Erik! I will update the fix as you suggested before push if you do not mind. Thanks, Dmitry > On 25 Oct 2019, at 14:00, Erik Joelsson wrote: > > Looks good. I would put in a "the" before "operating system". > > /Erik > > On 2019-10-25 03:27, Dmitry Markov wrote: >> H

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Looks good. I would put in a "the" before "operating system". /Erik On 2019-10-25 03:27, Dmitry Markov wrote: Hello, Could you review the fix for jdk14, please? bug: https://bugs.openjdk.java.net/browse/JDK-8232880 webrev: ht

RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Hello, Could you review the fix for jdk14, please? bug: https://bugs.openjdk.java.net/browse/JDK-8232880 webrev: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.00/ So