Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

+1 On 11/1/19 7:41 am, Alexey Ivanov wrote: Thank you, Dmitry! The changes look good to me. On 01/11/2019 13:09, Dmitry Markov wrote: Hi Alexey, I have updated the fix. Please find the new version here: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.03/ Thanks, Dmitry On 31 Oct 2019,

Re: Building Project Loom

Hi Erik, Thanks for pointing that out to the right direction. I noticed that I have llvm package installed by homebrew. I uninstalled the package then built was successful. Thanks Rahman Erik Joelsson , 1 Kas 2019 Cum, 14:41 tarihinde şunu yazdı: > Hello Rahman, > > What version of Xcode are yo

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Thank you, Dmitry! The changes look good to me. On 01/11/2019 13:09, Dmitry Markov wrote: Hi Alexey, I have updated the fix. Please find the new version here: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.03/ Thanks, Dmitry On 31 Oct 2019, at 16:27, Alexey Ivanov

Re: 8233078 : fix minimal VM build on Linux ppc64(le)

Hi Matthias, your changes look good to me. Please note, however, that I'm not a Reviewer. One minor thing: do you really want to keep the old code (as comment) in sharedRuntime_ppc.cpp:2853? Thanks for putting this straight. Regards, Lutz On 29.10.19, 14:32, "hotspot-dev on behalf of Bae

Re: RFR: JDK-8233383 Various minor fixes

Looks good. /Erik On 2019-11-01 03:43, Magnus Ihse Bursie wrote: This is a collection of minor fixes, that I've been gathering whenever I detected something that I thought needed fixing, but that by itself seemed to small to be worth the effort of opening a JBS issue. Summary of changes: * U

Re: RFR: JDK-8233381 Update copyright year in build system files

Looks good. /Erik On 2019-11-01 03:33, Magnus Ihse Bursie wrote: I noticed that the copyright year was not properly updated to 2019 in multiple make files that was indeed modified in 2019. Bug: https://bugs.openjdk.java.net/browse/JDK-8233381 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8233

Re: Building Project Loom

Hello Rahman, What version of Xcode are you using? The compile command line looks strange to me: /usr/local/opt/llvm@4/bin/clang Is this your own build of clang? I'm not familiar with any special requirements needed for the loom project, but in general I would recommend establishing that yo

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Hi Alexey, I have updated the fix. Please find the new version here: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.03/ Thanks, Dmitry > On 31 Oct 2019, at 16:27, Alexey Ivanov wrote: > > Hi Dmitry, > > 437 …by the operating syste

Building Project Loom

Hi, I tried to build project loom with given instructions in Wiki page. However, the build exit with error. Here you find the logs https://gist.github.com/rahmanusta/db03a9e4a6963204e5688b6bae81a796, could you please help? (MacOS Catalina 10.15) Thank you -- Rahman USTA Istanbul JUG https://git

RFR: JDK-8233383 Various minor fixes

This is a collection of minor fixes, that I've been gathering whenever I detected something that I thought needed fixing, but that by itself seemed to small to be worth the effort of opening a JBS issue. Summary of changes: * Unify creation of html from markdown for all *.md files in doc. * Mov

RFR: JDK-8233381 Update copyright year in build system files

I noticed that the copyright year was not properly updated to 2019 in multiple make files that was indeed modified in 2019. Bug: https://bugs.openjdk.java.net/browse/JDK-8233381 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8233381-update-copyright-year-2019/webrev.01 /Magnus