RE: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

Hi Mikael, thank you for fixing this. Cheers Christoph From: Mikael Vidstedt Sent: Mittwoch, 11. Dezember 2019 20:31 To: Langer, Christoph Cc: build-dev Subject: Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports Christoph, Thanks for reporting! I filed htt

Re: RFR(XS): 8235789: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was expanded before it was required

Looks good. /Erik On 2019-12-11 13:38, Mikael Vidstedt wrote: Please review this change which addresses the warning produced when running configure, introduced by JDK-8234370. Bug: https://bugs.openjdk.java.net/browse/JDK-8235789 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8235789/web

RFR(XS): 8235789: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was expanded before it was required

Please review this change which addresses the warning produced when running configure, introduced by JDK-8234370. Bug: https://bugs.openjdk.java.net/browse/JDK-8235789 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8235789/webrev.00/open/webrev/ Cheers, Mikael

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

ok. all good. -phil On 12/11/19 12:14 PM, Alexey Semenyuk wrote: Yes, I did a test build. - Alexey On 12/11/2019 1:48 PM, Phil Race wrote: Looks OK. I presume you did a test build in our build system ? -phil On 12/11/19 10:46 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage b

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

Yes, I did a test build. - Alexey On 12/11/2019 1:48 PM, Phil Race wrote: Looks OK. I presume you did a test build in our build system ? -phil On 12/11/19 10:46 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. - adds $(X_CFLAGS) to compiler command line. Patch contrib

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

Christoph, Thanks for reporting! I filed https://bugs.openjdk.java.net/browse/JDK-8235789 and will send out an RFR shortly. Cheers, Mikael > On Dec 11, 2019, at 1:27 AM, Langer, Christoph > wrote: > > Hi Mikael (or build folks), > > afte

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

Looks good. /Erik On 2019-12-11 10:46, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. - adds $(X_CFLAGS) to compiler command line. Patch contributed by Arthur Eubanks ([email protected]). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8235728 [2] http://cr.open

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

Looks OK. I presume you did a test build in our build system ? -phil On 12/11/19 10:46 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. - adds $(X_CFLAGS) to compiler command line. Patch contributed by Arthur Eubanks ([email protected]). - Alexey [1] https://bugs.ope

RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

Please review fix [2] for jpackage bug [1]. - adds $(X_CFLAGS) to compiler command line. Patch contributed by Arthur Eubanks ([email protected]). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8235728 [2] http://cr.openjdk.java.net/~asemenyuk/8235728/webrev.00

Re: RFR: JDK-8233112: Exclude SVG files from build comparison

Erik: This patch fixes the COMPARE_BUILD baseline. The SVG files generated by GraphViz are non-deterministic, so adding a sed filter to compensate. There is also an issue since jpackage was added, where we now have executables as resources in lib/modules. Those need to be compared as executab

Re: RFR: JDK-8234284: [dmg] Change DMG background image to TIFF

Build change looks good. /Erik On 2019-12-11 06:54, Andy Herrick wrote: Fix looks fine to me. adding build-dev since even this simple a makefile change should be reviewed by build-dev On 12/10/2019 10:24 PM, Alexander Matveev wrote: Please review fix [2] for jpackage bug [1].  - Changed b

Re: RFR: JDK-8234284: [dmg] Change DMG background image to TIFF

Fix looks fine to me. adding build-dev since even this simple a makefile change should be reviewed by build-dev On 12/10/2019 10:24 PM, Alexander Matveev wrote: Please review fix [2] for jpackage bug [1].  - Changed background image for DMG to TIFF format, which can be used to embed 2x imag

Re: RFR(S): 8231612: 100% cpu on arm32 in Service Thread

Aleksei, Looks good to me. -Dmitry On 11.12.19 15:53, Aleksei Voitylov wrote: > Kim, > > You are right. Here is an updated webrev: > > http://cr.openjdk.java.net/~avoitylov/webrev.8231612.05/ > > -Aleksei > > On 11/12/2019 03:03, Kim Barrett wrote: >>> On Dec 10, 2019, at 9:05 AM, Aleksei V

Re: RFR(S): 8231612: 100% cpu on arm32 in Service Thread

> On Dec 11, 2019, at 7:53 AM, Aleksei Voitylov > wrote: > > Kim, > > You are right. Here is an updated webrev: > > http://cr.openjdk.java.net/~avoitylov/webrev.8231612.05/ Looks good.

Re: RFR(S): 8231612: 100% cpu on arm32 in Service Thread

Kim, You are right. Here is an updated webrev: http://cr.openjdk.java.net/~avoitylov/webrev.8231612.05/ -Aleksei On 11/12/2019 03:03, Kim Barrett wrote: >> On Dec 10, 2019, at 9:05 AM, Aleksei Voitylov >> wrote: >> >> Kim, >> >> thank you for the suggestions. Here is an updated webrev: >> >>

RE: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

Hi Mikael (or build folks), after 8234370 was submitted, I recognize the following output for configure: stdin:85: warning: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was expanded before it was required stdin:85: http://www.gnu.org/software/autoconf/manual/autoconf.html#Expanded-Before-Req