Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

2020-01-06 Thread Sergey Bylokhov
On 1/6/20 8:41 pm, Philip Race wrote: How is this useful given that we disable jtreg failure handlers for the headful tests ? It is disabled only in mach5 for headful nightly and CI builds, but it is enabled for other builds, also it is enabled if the headful tests are executed standalone vi

Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

2020-01-06 Thread Philip Race
That didn't answer all my questions, at least not in a way that I can understand. How is this useful given that we disable jtreg failure handlers for the headful tests ? -phil. On 12/30/19, 11:33 AM, Sergey Bylokhov wrote: On 12/23/19 9:15 pm, Phil Race wrote: I am not sure what the right

Re: JDK 15 RFR of JDK-8235532: Update --release 14 symbol information for JDK 14 b27

2020-01-06 Thread Jan Lahoda
Looks good to me. Jan On 03. 01. 20 3:46, Joe Darcy wrote: Reminder for the review; happy new year, -Joe On 12/14/2019 3:22 PM, Joe Darcy wrote: Hello, The latest promoted build of JDK 14 before the fork was b26; therefore, the 26 API was used to create the --release 14 symbol information