Re: RFR JDK-8237042: Switch to JCov build which supports byte code version 59

2020-01-13 Thread Erik Joelsson
Looks good. /Erik On 2020-01-13 10:48, Alexandre (Shura) Iline wrote: Hi. Can you please review this simple change: --- $ hg diff diff -r f7edb9ca045c make/conf/jib-profiles.js --- a/make/conf/jib-profiles.js Fri Jan 10 15:38:25 2020

RFR JDK-8237042: Switch to JCov build which supports byte code version 59

2020-01-13 Thread Alexandre (Shura) Iline
Hi. Can you please review this simple change: --- $ hg diff diff -r f7edb9ca045c make/conf/jib-profiles.js --- a/make/conf/jib-profiles.js Fri Jan 10 15:38:25 2020 +0100 +++ b/make/conf/jib-profiles.js Mon Jan 13 10:42:27 2020 -0800 @@ -1

Re: RFR: 8236921: Add build target to produce a JDK image suitable for a Graal/SVM build

2020-01-13 Thread Bob Vandette
> On Jan 13, 2020, at 3:42 AM, Severin Gehwolf wrote: > > On Fri, 2020-01-10 at 13:19 -0800, Erik Joelsson wrote: >> Hello Severin, >> >> Looks good. > > Thanks for the review, Erik! > >> /Erik >> >> On 2020-01-10 09:28, Bob Vandette wrote: >>> I like it! >>> >>> I have to manually copy t

Re: RFR: 8236921: Add build target to produce a JDK image suitable for a Graal/SVM build

2020-01-13 Thread Severin Gehwolf
On Fri, 2020-01-10 at 13:19 -0800, Erik Joelsson wrote: > Hello Severin, > > Looks good. Thanks for the review, Erik! > /Erik > > On 2020-01-10 09:28, Bob Vandette wrote: > > I like it! > > > > I have to manually copy the libs each time. > > > > BTW: I have a PR in our internal queue to upda