Hello, please review this very small change .
It removes file that are not present any more from the OPT_SPEED_SRC file list
in JvmFeatures.gmk .
( this is a list of files to be optimized for speed when we otherwise optimize
for size in the minimal-JVM build)
Bug/webrev :
https://bugs.ope
On 2020-01-16 10:48, Ioi Lam wrote:
On 1/16/20 9:09 AM, Erik Joelsson wrote:
I would lean towards changing the check from "if any of the variants
do not support CDS, disable it" to "if any of the variants support
CDS, enable it". The cds jvm feature is only added to the variants
that support
On 1/16/20 9:09 AM, Erik Joelsson wrote:
I would lean towards changing the check from "if any of the variants
do not support CDS, disable it" to "if any of the variants support
CDS, enable it". The cds jvm feature is only added to the variants
that support it anyway.
If you do this, you pr
I would lean towards changing the check from "if any of the variants do
not support CDS, disable it" to "if any of the variants support CDS,
enable it". The cds jvm feature is only added to the variants that
support it anyway.
If you do this, you probably need to figure out how to explicitly o
Hello, thanks for looking into it .
Should I do a check just looking into single JVM configs, something like
AC_DEFUN([HOTSPOT_IS_JVM_VARIANT],
[ [ [[ " $JVM_VARIANTS " == " $1 " ]] ] ])
if HOTSPOT_IS_JVM_VARIANT(zero) || HOTSPOT_IS_JVM_VARIANT(minimal) ||
HOTSPOT_IS_JVM_VARIANT(core); then
This does indeed look like a bug to me. At least at Oracle, we no longer
build any multi JVM configs regularly, so things like this falls through
the cracks.
/Erik
On 2020-01-16 02:18, Baesken, Matthias wrote:
Hello, I noticed the following strange "feature" (or is it a bug?) .
When buildin
Hello, I noticed the following strange "feature" (or is it a bug?) .
When building 2 VM variants in one build and using
--with-jvm-variants=minimal,server
For this, the build works nicely. But I notice that in the server VM, cds is
removed.
Instead of
checking if cds should be enabled..
Hi Matthias,
On 16/01/2020 6:10 pm, Baesken, Matthias wrote:
Hi David, sure we can introduce a way to switch this on/off.
Thanks.
There is already something similar for the link-time optimization (flto) , see
the feature
JvmFeatures.gmk
180 ifeq ($(call check-jvm-feature, link-time-opt), t
Hi David, sure we can introduce a way to switch this on/off.
There is already something similar for the link-time optimization (flto) , see
the feature
JvmFeatures.gmk
180 ifeq ($(call check-jvm-feature, link-time-opt), true)
190 ifeq ($(call check-jvm-feature, link-time-opt), false)
hotspot.m4
