On 30/12/2019 20:18, Volker Simonis wrote:
> Hi,
> I'd like to downport the support for Visual Studio Code project
> creation to 11u. I think we will have to support 11u for quite some
> years and it makes sense to have as good as possible tool support in
> 11u as well.
I just came across this
Looks good to me too.
David
On 19/02/2020 6:26 am, Kim Barrett wrote:
On Feb 18, 2020, at 11:24 AM, John Paul Adrian Glaubitz
wrote:
Hi Kim!
On 2/18/20 5:07 PM, John Paul Adrian Glaubitz wrote:
I forgot to use a reference type when I tried the definition within the class
which is why it fa
> On Feb 18, 2020, at 11:24 AM, John Paul Adrian Glaubitz
> wrote:
>
> Hi Kim!
>
> On 2/18/20 5:07 PM, John Paul Adrian Glaubitz wrote:
>> I forgot to use a reference type when I tried the definition within the class
>> which is why it failed for me. I will test the proper approach and post a
>
Looks good.
Thanks, Roger
On 2/18/20 2:05 PM, Erik Joelsson wrote:
Here is an updated webrev with the whole check removed:
http://cr.openjdk.java.net/~erikj/8239019/webrev.02
/Erik
On 2020-02-14 09:16, Roger Riggs wrote:
Hi Erik,
Agree it should run outside of any source code system.
Idea
Here is an updated webrev with the whole check removed:
http://cr.openjdk.java.net/~erikj/8239019/webrev.02
/Erik
On 2020-02-14 09:16, Roger Riggs wrote:
Hi Erik,
Agree it should run outside of any source code system.
Idea supports that with the empty string.
So even the warning can be remove
Thank you for review.
Leonid
On 2/18/20 8:42 AM, Erik Joelsson wrote:
Looks good.
/Erik
On 2020-02-13 17:44, Leonid Mesnik wrote:
Hi
Could you please review following fix which extend JibArtifactManager
to support download and installation of artifacts with layout
different from maven sty
Hello Christoph,
Thanks for hanging in there, this is now looking good to me. Nice to see
a more general solution to the java.pdb problem.
/Erik
On 2020-02-18 06:47, Langer, Christoph wrote:
Hi,
I had to update my change a little bit – I forgot to exclude
jimage.map, java.map and jpackage
Looks good.
/Erik
On 2020-02-14 05:51, Erik Helin wrote:
On 2/13/20 6:21 PM, Erik Joelsson wrote:
Hello Erik,
Looks good.
Thanks for reviewing!
On 2/13/20 6:21 PM, Erik Joelsson wrote:
Style wise I try to put closing braces for logical blocks on a new
line, aligned with the opening brace.
Looks good.
/Erik
On 2020-02-13 17:44, Leonid Mesnik wrote:
Hi
Could you please review following fix which extend JibArtifactManager to
support download and installation of artifacts with layout different from maven
style.
It is planned that user provide name and properties to resolve layout
Hi Kim!
On 2/18/20 5:07 PM, John Paul Adrian Glaubitz wrote:
> I forgot to use a reference type when I tried the definition within the class
> which is why it failed for me. I will test the proper approach and post a
> patch in a few minutes.
Here's the patch with the changes as you suggested [1]
On 2/18/20 4:55 PM, Kim Barrett wrote:
> Nope. That unnecessarily pollutes the global namespace with “dummy_regs”.
>
> The dummy declaration should be in the RegistersForDebugging class as I
> suggested earlier.
> But you say that “doesn’t work”. I thought perhaps that meant I’d made was a
> m
> On Feb 16, 2020, at 2:58 PM, John Paul Adrian Glaubitz
> wrote:
>
> Hi Kim!
>
> On 2/15/20 10:30 PM, Kim Barrett wrote:
>> I prefer the approach using a non-ODR-used dummy to the approach of
>> casting of some random number to an address. Non-ODR-used
>> declarations are well supported by th
Hi,
I had to update my change a little bit – I forgot to exclude jimage.map,
java.map and jpackage.map when copying the cmd debug symbols in Images.gmk.
Furthermore, I needed to modify tests jdk/tools/launcher/TestHelper.java and
jdk/tools/launcher/VersionCheck.java to cope with debug symbol fi
13 matches
Mail list logo
