Re: RFR: JDK-8239860 Add support for testing the configure script

2020-02-24 Thread Erik Joelsson
Looks good. /Erik On 2020-02-24 05:15, Magnus Ihse Bursie wrote: We've been sorely lacking a way to test the configure script, leading to just pre-checkin adhoc testing. Here is a simple framework for running unit tests of functions in our configure script. The initial tests included are mor

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-24 Thread Erik Joelsson
Looks good to me as long as everyone is happy with the descriptions. /Erik On 2020-02-24 00:53, Magnus Ihse Bursie wrote: On 2020-02-21 16:36, Magnus Ihse Bursie wrote: On 2020-02-21 16:15, Erik Gahlin wrote: jfr should be JDK Flight Recorder. Thanks, I should have checked and not guessed. :

RFR: JDK-8239860 Add support for testing the configure script

2020-02-24 Thread Magnus Ihse Bursie
We've been sorely lacking a way to test the configure script, leading to just pre-checkin adhoc testing. Here is a simple framework for running unit tests of functions in our configure script. The initial tests included are more to be considered placeholders. I put the assert function in uti

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-24 Thread Per Liden
You forgot to change "ZGC garbage collector" -> "Z garbage collector". /Per On 2/24/20 9:53 AM, Magnus Ihse Bursie wrote: On 2020-02-21 16:36, Magnus Ihse Bursie wrote: On 2020-02-21 16:15, Erik Gahlin wrote: jfr should be JDK Flight Recorder. Thanks, I should have checked and not guessed. :

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-24 Thread Magnus Ihse Bursie
On 2020-02-24 11:23, Per Liden wrote: Hi Magnus, On 2/21/20 5:35 PM, Magnus Ihse Bursie wrote: On 2020-02-21 17:26, Erik Joelsson wrote: Baring any component specific opinions on the suggested descriptions of each feature, the patch looks good to me. Ok, I'm sending a copy of this to hotspot-d

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-24 Thread Magnus Ihse Bursie
On 2020-02-21 16:36, Magnus Ihse Bursie wrote: On 2020-02-21 16:15, Erik Gahlin wrote: jfr should be JDK Flight Recorder. Thanks, I should have checked and not guessed. :) I updated the code but will not send out a new webrev. Actually, I am sending out a new webrev, just to make sure I do t