Looks good.
/Erik
On 2020-02-24 05:15, Magnus Ihse Bursie wrote:
We've been sorely lacking a way to test the configure script, leading
to just pre-checkin adhoc testing.
Here is a simple framework for running unit tests of functions in our
configure script. The initial tests included are mor
Looks good to me as long as everyone is happy with the descriptions.
/Erik
On 2020-02-24 00:53, Magnus Ihse Bursie wrote:
On 2020-02-21 16:36, Magnus Ihse Bursie wrote:
On 2020-02-21 16:15, Erik Gahlin wrote:
jfr should be JDK Flight Recorder.
Thanks, I should have checked and not guessed. :
We've been sorely lacking a way to test the configure script, leading to
just pre-checkin adhoc testing.
Here is a simple framework for running unit tests of functions in our
configure script. The initial tests included are more to be considered
placeholders.
I put the assert function in uti
You forgot to change "ZGC garbage collector" -> "Z garbage collector".
/Per
On 2/24/20 9:53 AM, Magnus Ihse Bursie wrote:
On 2020-02-21 16:36, Magnus Ihse Bursie wrote:
On 2020-02-21 16:15, Erik Gahlin wrote:
jfr should be JDK Flight Recorder.
Thanks, I should have checked and not guessed. :
On 2020-02-24 11:23, Per Liden wrote:
Hi Magnus,
On 2/21/20 5:35 PM, Magnus Ihse Bursie wrote:
On 2020-02-21 17:26, Erik Joelsson wrote:
Baring any component specific opinions on the suggested descriptions
of each feature, the patch looks good to me.
Ok, I'm sending a copy of this to hotspot-d
On 2020-02-21 16:36, Magnus Ihse Bursie wrote:
On 2020-02-21 16:15, Erik Gahlin wrote:
jfr should be JDK Flight Recorder.
Thanks, I should have checked and not guessed. :)
I updated the code but will not send out a new webrev.
Actually, I am sending out a new webrev, just to make sure I do t