On 2020-02-27 3:47 p.m., Andrew Hughes wrote:
On 27/02/2020 19:55, Simon Tooke wrote:
I have not heard back, and had put this on the back burner for a while.
Due to renewed interest expressed to me privately, I would like to
resubmit this RFR, updated to the latest JDK and macOS build envir
Hi Erik, Magnus,
Thank you for your feedback.
When we considered the user experience we determined that
it would be frustrating to see the build succeed but have the
output binary not signed, forcing the user to go back and check
the log for any warning message. In the end they have to either
si
On 27/02/2020 19:55, Simon Tooke wrote:
> I have not heard back, and had put this on the back burner for a while.
>
>
> Due to renewed interest expressed to me privately, I would like to
> resubmit this RFR, updated to the latest JDK and macOS build environment.
>
>
> Updated webrev:
> http:
I have not heard back, and had put this on the back burner for a while.
Due to renewed interest expressed to me privately, I would like to
resubmit this RFR, updated to the latest JDK and macOS build environment.
Updated webrev:
http://cr.openjdk.java.net/~stooke/webrevs/jdk-8226288-jdk8u/0
Looks good.
/Erik
On 2020-02-27 06:56, Magnus Ihse Bursie wrote:
The JVM feature rewrite changed spec.gmk so that JVM_FEATURE_
was only set for the variants actually being built. However, in
buildjdk-spec.gmk we override the selected variant with 'server' when
building the buildjdk, but we re
On 2020-02-27 06:16, Magnus Ihse Bursie wrote:
I don't think it should be a fatal error. If you have a codesign
binary on your path that does not support --option runtime, you should
still be able to build, but not sign. Change it to a warning, and let
the user continue without CODESIGN.
My i
> On Feb 27, 2020, at 9:59 AM, Magnus Ihse Bursie
> wrote:
>
> On 2020-02-27 15:52, Bob Vandette wrote:
>>
>>> On Feb 27, 2020, at 7:15 AM, Magnus Ihse Bursie
>>>
>>> wrote:
>>>
>>> On 2020-02-26 22:01, Bob Vandette wrote:
>>>
Here’s an updated webrev that implementes the suggestio
On 2020-02-27 15:52, Bob Vandette wrote:
On Feb 27, 2020, at 7:15 AM, Magnus Ihse Bursie
wrote:
On 2020-02-26 22:01, Bob Vandette wrote:
Here’s an updated webrev that implementes the suggestion that allows JNIEXPORT
in jni.h to be overridden
and the build limits visibility for static libra
> On Feb 27, 2020, at 7:15 AM, Magnus Ihse Bursie
> wrote:
>
> On 2020-02-26 22:01, Bob Vandette wrote:
>> Here’s an updated webrev that implementes the suggestion that allows
>> JNIEXPORT in jni.h to be overridden
>> and the build limits visibility for static libraries.
>>
>> If this webre
The JVM feature rewrite changed spec.gmk so that JVM_FEATURE_
was only set for the variants actually being built. However, in
buildjdk-spec.gmk we override the selected variant with 'server' when
building the buildjdk, but we relied on the set of features detected for
the target jdk. This worke
Hi Andrew,
On Thu, 2020-02-27 at 04:52 +, Andrew Hughes wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8232748
> Webrev: https://cr.openjdk.java.net/~andrew/openjdk11/8232748/webrev.01/
>
> This patch adds targets to the build so that static versions of the JDK
> native libraries can
On 2020-02-26 18:30, Junyuan Zheng wrote:
Hi all,
A recent change in OpenJDK tip
(https://hg.openjdk.java.net/jdk/jdk/rev/dcf88e5c8c07) contains a potential bug
when try to sign the macOS binary on older macOS.
The current macOS signing process will execute the following command in order:
1.
On 2020-02-26 22:01, Bob Vandette wrote:
Here’s an updated webrev that implementes the suggestion that allows
JNIEXPORT in jni.h to be overridden
and the build limits visibility for static libraries.
If this webrev is accepted, I’ll update the CSR solution to match this
implementation.
http:
On 2020-02-27 00:31, David Holmes wrote:
Hi Bob,
On 27/02/2020 7:01 am, Bob Vandette wrote:
Here’s an updated webrev that implementes the suggestion that allows
JNIEXPORT in jni.h to be overridden
and the build limits visibility for static libraries.
! #if (defined(__GNUC__) && ((__GNUC__
14 matches
Mail list logo
