Re: RFR 8240980: Backout JDK-8240261

2020-03-12 Thread David Holmes
Hi Max, Backout seems accurate. Thanks, David On 13/03/2020 2:12 pm, Weijun Wang wrote: Code change for JDK-8240261 uses $(TOPDIR)/make/templates/gpl-cp-header to generate source files but it is not available in all source bundles used for builds. Request to back out the change. The changes

RFR 8240980: Backout JDK-8240261

2020-03-12 Thread Weijun Wang
Code change for JDK-8240261 uses $(TOPDIR)/make/templates/gpl-cp-header to generate source files but it is not available in all source bundles used for builds. Request to back out the change. The changeset is a direct output of 'hg backout' command. You can see the webrev at https://cr.openj

Re: macOS build success but codesign fail on macOS 10.13.5 or older

2020-03-12 Thread Erik Joelsson
Done: https://bugs.openjdk.java.net/browse/JDK-8240972 /Erik On 2020-03-12 11:33, Junyuan Zheng wrote: Hi Erik, Yes, I do need a sponsor for pushing this. Do you mind sponsoring this? Thanks, Junyuan From: Erik Joelsson Sent: Wednesday, March 11,

Re: Re: macOS build success but codesign fail on macOS 10.13.5 or older

2020-03-12 Thread Junyuan Zheng
Hi Erik, Yes, I do need a sponsor for pushing this. Do you mind sponsoring this? Thanks, Junyuan From: Erik Joelsson Sent: Wednesday, March 11, 2020 5:51 AM To: Junyuan Zheng; Magnus Ihse Bursie; [email protected] Subject: Re: [EXTERNAL] Re: ma

Re: [RFR] [11u] JDK-8232748: "Build static versions of certain JDK libraries"

2020-03-12 Thread Andrew Hughes
On 12/03/2020 10:25, Severin Gehwolf wrote: > Hi Andrew, > > On Thu, 2020-02-27 at 15:43 +0100, Severin Gehwolf wrote: >> On Thu, 2020-02-27 at 04:52 +, Andrew Hughes wrote: >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8232748 >>> Webrev: https://cr.openjdk.java.net/~andrew/openjdk11/8

RE: [11u]: RFR 8235686: Add more custom hooks in Bundles.gmk

2020-03-12 Thread Lindenmaier, Goetz
Hi Christoph, The change looks good. Reviewed. I think Volker wants to bring the FindFiles/CacheFind change to 11, which is in the problematic contexts. But I think we should not wait for that, as this is a oracle parity change. It's trivial to resolve anyways. As Severin I think it's fine to

Re: RFR: JDK-8149110 Introduce DISABLED_WARNINGS for Java compilation

2020-03-12 Thread Erik Joelsson
Looks good. /Erik On 2020-03-12 03:21, Magnus Ihse Bursie wrote: For native code, we have a system to turn of individual warnings on a per-library basis. We should have a similar system for Java compilation. The suggestion is to introduce a DISABLED_WARNINGS argument to SetupJavaCompilation.

Re: RFR: JDK-8240950 Missing AC_SUBST after JDK-82408

2020-03-12 Thread Erik Joelsson
Looks good. /Erik On 2020-03-12 04:09, Magnus Ihse Bursie wrote: Unfortunately two babies went out with the bathwaters. This restores functionality for smartjavac and javac-server. Bug: https://bugs.openjdk.java.net/browse/JDK-8240950 Patch inline: diff --git a/make/autoconf/build-performance

Re: RFR: JDK-8240947 Change conflicting JVM features from warning to error

2020-03-12 Thread Erik Joelsson
Looks good. /Erik On 2020-03-12 02:36, Magnus Ihse Bursie wrote: If configure is given a conflicting configure line, e.g. --disable-jvm-feature-serialgc --with-jvm-features=serialgc , it will print a warning and let the disable override the enable. This turned out to be not enough to catch i

RFR: JDK-8240950 Missing AC_SUBST after JDK-82408

2020-03-12 Thread Magnus Ihse Bursie
Unfortunately two babies went out with the bathwaters. This restores functionality for smartjavac and javac-server. Bug: https://bugs.openjdk.java.net/browse/JDK-8240950 Patch inline: diff --git a/make/autoconf/build-performance.m4 b/make/autoconf/build-performance.m4 --- a/make/autoconf/build

RE: [11u] RFR: 8189861: Refactor CacheFind

2020-03-12 Thread Langer, Christoph
Thanks, Severin. I pushed it to jdk11u-dev now. Cheers Christoph > -Original Message- > From: Severin Gehwolf > Sent: Mittwoch, 11. März 2020 15:53 > To: Langer, Christoph ; Volker Simonis > ; Andrew Hughes ; > [email protected] > Cc: build-dev > Subject: Re: [11u] RFR:

[11u]: RFR 8235686: Add more custom hooks in Bundles.gmk

2020-03-12 Thread Langer, Christoph
Hi, please help to review this Oracle-11.0.7 parity backport for the build system. Bug: https://bugs.openjdk.java.net/browse/JDK-8235686 Original Change: https://hg.openjdk.java.net/jdk/jdk14/rev/91a3f092682f Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8235686.11u/ The patch needed some

RFR: JDK-8149110 Introduce DISABLED_WARNINGS for Java compilation

2020-03-12 Thread Magnus Ihse Bursie
For native code, we have a system to turn of individual warnings on a per-library basis. We should have a similar system for Java compilation. The suggestion is to introduce a DISABLED_WARNINGS argument to SetupJavaCompilation. We could then be able to express something like: jdk.xml.ws_DISAB

Re: [RFR] [11u] JDK-8232748: "Build static versions of certain JDK libraries"

2020-03-12 Thread Severin Gehwolf
Hi Andrew, On Thu, 2020-02-27 at 15:43 +0100, Severin Gehwolf wrote: > On Thu, 2020-02-27 at 04:52 +, Andrew Hughes wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8232748 > > Webrev: https://cr.openjdk.java.net/~andrew/openjdk11/8232748/webrev.01/ > > > > This patch adds targets to

RFR: JDK-8240947 Change conflicting JVM features from warning to error

2020-03-12 Thread Magnus Ihse Bursie
If configure is given a conflicting configure line, e.g. --disable-jvm-feature-serialgc --with-jvm-features=serialgc , it will print a warning and let the disable override the enable. This turned out to be not enough to catch incorrect configurations. Instead, configure should consider this an