Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

2020-03-18 Thread Erik Joelsson
Looks good. /Erik On 2020-03-18 14:24, Roger Riggs wrote: Hi, Some small updates to the source files to minimize the changes to javadoc of the _Stub classes. And fixes to the points Magnus raises below. http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-4/ Thanks, Roger On 3/

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

2020-03-18 Thread Roger Riggs
Hi, Some small updates to the source files to minimize the changes to javadoc of the _Stub classes. And fixes to the points Magnus raises below. http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-4/ Thanks, Roger On 3/18/20 9:01 AM, Magnus Ihse Bursie wrote: On 2020-03-17 23:

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

2020-03-18 Thread Magnus Ihse Bursie
On 2020-03-17 23:07, Roger Riggs wrote: Hi Magnus, Erik, Thanks for the pointers, I'm not familiar with those early build intricacies. Updated: http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-2/ Looking much better! Please remove the reference to "rmic" in Global.gmk as

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

2020-03-18 Thread Erik Joelsson
This looks good to me. Thanks for hanging in there! /Erik On 2020-03-17 15:07, Roger Riggs wrote: Hi Magnus, Erik, Thanks for the pointers, I'm not familiar with those early build intricacies. Updated: http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-2/ More cleanup: - cle