Hi Magnus,
I looked at i18n related changes:
make/CopyInterimTZDB.gmk
make/ToolsJdk.gmk
make/gendata/Gendata-java.base.gmk
make/gendata/GendataBreakIterator.gmk
make/gendata/GendataTZDB.gmk
make/gensrc/GensrcCharacterData.gmk
make/gensrc/GensrcEmojiData.gmk
They look ok to me.
The *.java chang
On 23/03/2020 19:03, Magnus Ihse Bursie wrote:
The build tools (small java tools that are run during the build to
generate source code, or data, needed in the JDK) have historically
been placed in the "make" directory. This maybe made sense long time
ago, but does not do so anymore.
Instea
On 3/23/20 1:15 PM, Magnus Ihse Bursie wrote:
On 2020-03-23 18:20, Jonathan Gibbons wrote:
On 3/23/20 7:32 AM, Erik Joelsson wrote:
On 2020-03-23 07:21, Jonathan Gibbons wrote:
On 3/23/20 6:06 AM, Erik Joelsson wrote:
The environment variable name JT_HOME is defined by Jtreg itself
so I
Hi Magnus,
Modularizing the build tools is a good move. This patch suggests to
place the build tools under
src/$MODULE/share/tools/$PACKAGE/*.java
I think the modular source location of the build tools needs more
discussion, including jigsaw-dev for this discussion.
The JDK source as
On 2020-03-23 18:20, Jonathan Gibbons wrote:
On 3/23/20 7:32 AM, Erik Joelsson wrote:
On 2020-03-23 07:21, Jonathan Gibbons wrote:
On 3/23/20 6:06 AM, Erik Joelsson wrote:
The environment variable name JT_HOME is defined by Jtreg itself so
I think it makes sense to use that. Configure is st
Looks good.
/Erik
On 2020-03-23 12:03, Magnus Ihse Bursie wrote:
The build tools (small java tools that are run during the build to
generate source code, or data, needed in the JDK) have historically
been placed in the "make" directory. This maybe made sense long time
ago, but does not do so
The build tools (small java tools that are run during the build to
generate source code, or data, needed in the JDK) have historically been
placed in the "make" directory. This maybe made sense long time ago, but
does not do so anymore.
Instead, the build tools source code should move the the
Looks good.
/Erik
On 2020-03-23 10:56, Andrew Dinn wrote:
Could I please have a review for this trivial fix to the module make
file which ensures that javadoc is generated for new module
jdk.nio.mapmode created as part of the implementation of JEP 352. The
original patch added the module to the
Could I please have a review for this trivial fix to the module make
file which ensures that javadoc is generated for new module
jdk.nio.mapmode created as part of the implementation of JEP 352. The
original patch added the module to the BOOT_MODULES list but was not to
the DOCS_MODULES list.
JIRA
On 3/23/20 7:32 AM, Erik Joelsson wrote:
On 2020-03-23 07:21, Jonathan Gibbons wrote:
On 3/23/20 6:06 AM, Erik Joelsson wrote:
The environment variable name JT_HOME is defined by Jtreg itself so
I think it makes sense to use that. Configure is still honoring it,
but run-test-prebuilt is not
On 2020-03-23 07:21, Jonathan Gibbons wrote:
On 3/23/20 6:06 AM, Erik Joelsson wrote:
The environment variable name JT_HOME is defined by Jtreg itself so I
think it makes sense to use that. Configure is still honoring it, but
run-test-prebuilt is not. We can of course use a different variabl
On 3/23/20 6:06 AM, Erik Joelsson wrote:
The environment variable name JT_HOME is defined by Jtreg itself so I
think it makes sense to use that. Configure is still honoring it, but
run-test-prebuilt is not. We can of course use a different variable
name internally, but I don't really see th
Hello Philipp,
On 2020-03-21 12:37, Philipp Kunz wrote:
Hi everyone,
When I started contributing I went through all the building and testing
instructions [1] and after I had bought a new computer recently, it
occurred to me that this could as well be simplified with docker.
What I found was no
Hello,
On 2020-03-23 02:21, Magnus Ihse Bursie wrote:
We're doing some odd things in the build system for jtreg, most of it
left-overs from the older build systems.
We have no need for JTREGEXE and it should be removed. We should also
use the standard naming pattern of JTREG_HOME.
The envir
Hi Philipp,
On 2020-03-21 20:37, Philipp Kunz wrote:
Hi everyone,
When I started contributing I went through all the building and testing
instructions [1] and after I had bought a new computer recently, it
occurred to me that this could as well be simplified with docker.
What I found was not a
We're doing some odd things in the build system for jtreg, most of it
left-overs from the older build systems.
We have no need for JTREGEXE and it should be removed. We should also
use the standard naming pattern of JTREG_HOME.
The test in BuildFailureHandler.gmk is a bit different -- it is s
Hotspot change looks good, and trivial.
/Jesper
> On 23 Mar 2020, at 09:45, Magnus Ihse Bursie
> wrote:
>
> On 2020-03-20 14:19, Stefan Karlsson wrote:
>> HotSpot changes look good.
>
> Can I have a second hotspot reviewer on this, or a confirmation that it's
> considered trivial?
>
> /Magnu
On 2020-03-20 14:19, Stefan Karlsson wrote:
HotSpot changes look good.
Can I have a second hotspot reviewer on this, or a confirmation that
it's considered trivial?
/Magnus
StefanK
On 2020-03-20 14:15, Magnus Ihse Bursie wrote:
Can I get some hotspot reviewers on this as well? And is this
18 matches
Mail list logo
