Re: RFR (S): 8241947: Minor comment fixes for system property handling

2020-04-01 Thread Mandy Chung
+1 Mandy On 3/31/20 11:57 AM, Langer, Christoph wrote: Hi Mandy, this is a good suggestion. The listing of system properties at the props field declaration seems somewhat redundant, given that it already exists more exactly and with API normativity in the doc of System::getProperties().

Re: RFR (S): 8241947: Minor comment fixes for system property handling

2020-04-01 Thread Roger Riggs
My mistake, I mistook it for the spec table. On 4/1/20 12:06 PM, Alan Bateman wrote: On 01/04/2020 17:03, Roger Riggs wrote: Hi, Does dropping the "The following properties are guaranteed to be defined:" would seem to be a spec change. It's a comment on a private field, there's no change

Re: RFR (S): 8241947: Minor comment fixes for system property handling

2020-04-01 Thread Alan Bateman
On 01/04/2020 17:03, Roger Riggs wrote: Hi, Does dropping the "The following properties are guaranteed to be defined:" would seem to be a spec change. It's a comment on a private field, there's no change to the getProperties spec. -Alan

Re: RFR (S): 8241947: Minor comment fixes for system property handling

2020-04-01 Thread Roger Riggs
Hi, Does dropping the "The following properties are guaranteed to be defined:" would seem to be a spec change. Just linking to the properties page makes no such guarantee. Roger On 4/1/20 10:45 AM, Alan Bateman wrote: On 31/03/2020 19:57, Langer, Christoph wrote: Hi Mandy, this is a good

RE: RFR (S): 8241947: Minor comment fixes for system property handling

2020-04-01 Thread Langer, Christoph
Thanks for the review, Alan. I'll push it then. Best regards Christoph > -Original Message- > From: Alan Bateman > Sent: Mittwoch, 1. April 2020 16:46 > To: Langer, Christoph ; Mandy Chung > ; core-libs-...@openjdk.java.net > Cc: build-dev > Subject: Re: RFR (S): 8241947: Minor

Re: RFR (S): 8241947: Minor comment fixes for system property handling

2020-04-01 Thread Alan Bateman
On 31/03/2020 19:57, Langer, Christoph wrote: Hi Mandy, this is a good suggestion. The listing of system properties at the props field declaration seems somewhat redundant, given that it already exists more exactly and with API normativity in the doc of System::getProperties(). So what do

Re: RFR: 8241996: on linux set full relro in the linker flags

2020-04-01 Thread Erik Joelsson
Hello Matthias, We are currently setting -z now for slowdebug builds. That should be removed if it's now set by default for all configs. /Erik On 2020-04-01 06:35, Baesken, Matthias wrote: Hello, please review this binary hardening related change. To improve binary hardening, we should

Re: RFR: 8241996: on linux set full relro in the linker flags

2020-04-01 Thread Claes Redestad
Hi, I took this for a spin on my setup, and see a ~500k increase in both instructions and cycles - I guess one of your runs saw more interference than the other. From a startup performance point of view the advertised cost seems more or less negligible. (For context we've optimized away 10M

RFR: 8241996: on linux set full relro in the linker flags

2020-04-01 Thread Baesken, Matthias
Hello, please review this binary hardening related change. To improve binary hardening, we should enable full relro in the OpenJDK builds. Currently our build settings enable only partial relro (they miss z,now). See