Hi Magnus,
Some minor mistakes below, but otherwise looks good. Also copyrights
need updating. I don't need to see another webrev.
thanks,
Chris
---
old/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/MethodHandlesAdapterBlob.java
2020-04-14 12:47:05.098156117 +0200
+++
new/src/j
Hi Magnus,
This looks okay to me unless there is a better solution.
Thanks,
Serguei
On 4/14/20 04:04, Magnus Ihse Bursie wrote:
As a first step towards fixing deprecation warnings in SA, all the
references (200+) to the deprecated java.util.Observer and Observable
needs to be fixed, otherwise
Looks good.
Cheers,
Mikael
> On Apr 9, 2020, at 9:56 AM, Erik Joelsson wrote:
>
> When building with VS2019, there is a new runtime library,
> vcruntime140_1.dll, that we need to bundle along with the others. This patch
> sets this up all through the build.
>
> Bug: https://bugs.openjdk.ja
On 2020-04-14 15:13, Erik Joelsson wrote:
The intention is that the new dll should only be required for
TOOLCHAIN_VERSION that define it, just like MSVP_DLL which was
introduced in VS2012.
I will verify again that this is actually true.
My worry is with this piece of code in toolchain_window
The intention is that the new dll should only be required for
TOOLCHAIN_VERSION that define it, just like MSVP_DLL which was
introduced in VS2012.
I will verify again that this is actually true.
/Erik
On 2020-04-14 05:59, Magnus Ihse Bursie wrote:
Maybe I'm missing something here, but will th
Hello Magnus,
I'll let someone else judge the validity of the approach, though I think
it seems ok.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/GenericGrowableArray.java:
Double imports.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java:
Triple i
Maybe I'm missing something here, but will this not break for VS
versions before 2019 that does not have vcruntime140_1.dll?
/Magnus
On 2020-04-09 18:56, Erik Joelsson wrote:
When building with VS2019, there is a new runtime library,
vcruntime140_1.dll, that we need to bundle along with the ot
Looks good.
/Erik
On 2020-04-14 03:31, Magnus Ihse Bursie wrote:
When building with some versions of the macOS SDK, you can get errors
like this:
Undefined symbols for architecture x86_64:
??"_objc_loadClassref", referenced from:
??__ARCLite__load() in libarclite_macosx.a(arclite.o)
ld: s
As a first step towards fixing deprecation warnings in SA, all the
references (200+) to the deprecated java.util.Observer and Observable
needs to be fixed, otherwise all other changes will drown in this one.
This solution is the result of the preceding discussions in
serviceability-dev. That m
When building with some versions of the macOS SDK, you can get errors
like this:
Undefined symbols for architecture x86_64:
??"_objc_loadClassref", referenced from:
??__ARCLite__load() in libarclite_macosx.a(arclite.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker comm
Hi,
Can I please get a review for this, simplified version of the patch?
This only contain trivial changes, like this:
- private Listobjects; // ArrayList
+ private List objects;
Basically all changes are to the container types List or Map (and a few
changes from Class to Class).
If
11 matches
Mail list logo
