Thank you for the review!
Whitespace issues will be fixed in the final patch.
- Alexey
On 4/23/2020 2:51 PM, Erik Joelsson wrote:
Thanks, that looks good!
Only two minor whitespace nits.
Line 32-33, 102-103: continuation indent 4 spaces
Line 101: extra space
No need for new webrev.
/Erik
Thanks, that looks good!
Only two minor whitespace nits.
Line 32-33, 102-103: continuation indent 4 spaces
Line 101: extra space
No need for new webrev.
/Erik
On 2020-04-23 11:38, Alexey Semenyuk wrote:
Erik,
Please review updated patch with the suggested improvements at [1].
The webrev i
Erik,
Please review updated patch with the suggested improvements at [1]. The
webrev includes only incremental changes to
Lib-jdk.incubator.jpackage.gmk for clarity.
[1]
http://cr.openjdk.java.net/~asemenyuk/8242302/webrev.01/webrev.01/index.html
- Alexey
On 4/20/2020 1:17 PM, Erik Joelss
On 2020-04-23 17:17, Igor Ignatyev wrote:
Hi Matthias,
jtharness 6.0-b10 and jtreg 5.0-b1.
jtreg 5.0-b1 "officially" depends on jt6.0-b08, and the bundle which
we use internally has jt6.0-b08 within it, and AFAICT jt6.0-b08 hasn't
deprecated c.s.j.H.Observer::finishedTesting yet. so as a
On 4/22/20 6:00 PM, Severin Gehwolf wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8243059
> webrev:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8243059/jdk11/01/webrev/
> original change: https://hg.openjdk.java.net/jdk/jdk/rev/dff3aabdc2f3
>
> Testing: Build fails before, passes
Hi Matthias,
> jtharness 6.0-b10 and jtreg 5.0-b1.
jtreg 5.0-b1 "officially" depends on jt6.0-b08, and the bundle which we use
internally has jt6.0-b08 within it, and AFAICT jt6.0-b08 hasn't deprecated
c.s.j.H.Observer::finishedTesting yet. so as a temp. solution to allow
configurations like y
On 4/23/20 4:05 PM, Magnus Ihse Bursie wrote:
>
>> 23 apr. 2020 kl. 15:50 skrev Igor Ignatyev :
>>
>>
>>
>>> On Apr 23, 2020, at 6:12 AM, Erik Joelsson wrote:
>>>
>>> Hello Matthias,
>>>
On 2020-04-23 05:51, Matthias Klose wrote:
jdk-15+20 fails to build with
* For target
>>>
> 23 apr. 2020 kl. 15:50 skrev Igor Ignatyev :
>
>
>
>> On Apr 23, 2020, at 6:12 AM, Erik Joelsson wrote:
>>
>> Hello Matthias,
>>
>>> On 2020-04-23 05:51, Matthias Klose wrote:
>>> jdk-15+20 fails to build with
>>>
>>> * For target
>>> support_test_failure_handler_classes__the.BUILD_FAIL
> On Apr 23, 2020, at 6:12 AM, Erik Joelsson wrote:
>
> Hello Matthias,
>
> On 2020-04-23 05:51, Matthias Klose wrote:
>> jdk-15+20 fails to build with
>>
>> * For target
>> support_test_failure_handler_classes__the.BUILD_FAILURE_HANDLER_batch:
>> /packages/openjdk/15/openjdk-15-15~20/test/
Hello Matthias,
On 2020-04-23 05:51, Matthias Klose wrote:
jdk-15+20 fails to build with
* For target
support_test_failure_handler_classes__the.BUILD_FAILURE_HANDLER_batch:
/packages/openjdk/15/openjdk-15-15~20/test/failure_handler/src/share/classes/jdk/test/failurehandler/jtreg/GatherDiagnost
Looks good.
/Erik
On 2020-04-23 04:32, Magnus Ihse Bursie wrote:
The check for the system freetype library should check the 64-bit
library first on 64-bit systems, before falling back to the generic
"lib" directory.
When fixing this, I noticed that lib-freetype.m4 needed a lot of love,
so I
jdk-15+20 fails to build with
* For target
support_test_failure_handler_classes__the.BUILD_FAILURE_HANDLER_batch:
/packages/openjdk/15/openjdk-15-15~20/test/failure_handler/src/share/classes/jdk/test/failurehandler/jtreg/GatherDiagnosticInfoObserver.java:136:
warning: [deprecation] finishedTestin
The check for the system freetype library should check the 64-bit
library first on 64-bit systems, before falling back to the generic
"lib" directory.
When fixing this, I noticed that lib-freetype.m4 needed a lot of love,
so I shaped it up a bit. Changes made to code quality:
* Indentation a
> On Apr 22, 2020, at 9:28 AM, Erik Joelsson wrote:
>
> Build change looks good.
Thanks.
>
> /Erik
>
> On 2020-04-22 06:23, Kim Barrett wrote:
>> Please review this change to undo the (small) portion of JDK-8238281
>> [1] related to the HotSpot offset_of macro for gcc/clang. That change
>> s
> On Apr 22, 2020, at 9:57 AM, Magnus Ihse Bursie
> wrote:
>
> On 2020-04-22 15:23, Kim Barrett wrote:
>> Please review this change to undo the (small) portion of JDK-8238281
>> [1] related to the HotSpot offset_of macro for gcc/clang. That change
>> should not have been made. See CR for detai
> On Apr 22, 2020, at 10:33 PM, David Holmes wrote:
>
> On 22/04/2020 11:23 pm, Kim Barrett wrote:
>> Please review this change to undo the (small) portion of JDK-8238281
>> [1] related to the HotSpot offset_of macro for gcc/clang. That change
>> should not have been made. See CR for details.
>
16 matches
Mail list logo
