Hi Erik and Magnus,
Thanks for your help.
Updated: http://cr.openjdk.java.net/~jiefu/8247396/webrev.02/
Also I've changed the JBS title to 'Exclude PCH for files in $(OPT_SPEED_SRC)
with clang after JDK-8246751'.
Please review it and give me some adviece.
Thanks a lot.
Best regards,
Jie
On 2
Hi Magnus,
Thanks for your review and valuable comments.
I've tested with clang and gcc on linux/x64.
gcc seems to be fine.
The bug can be reproduced only when clang was used.
Best regards,
Jie
On 2020/6/11, 9:42 PM, "Magnus Ihse Bursie"
wrote:
On 2020-06-11 14:34, Erik Joelsson wrote:
On 2020-06-11 06:41, Magnus Ihse Bursie wrote:
On 2020-06-11 14:34, Erik Joelsson wrote:
I agree with the assessment, but I think the disabling should happen
in configure. That way the configure log can accurately tell the user
why it was disabled. This can be done by just adding another elif i
On 2020-06-11 14:34, Erik Joelsson wrote:
I agree with the assessment, but I think the disabling should happen
in configure. That way the configure log can accurately tell the user
why it was disabled. This can be done by just adding another elif in
BPERF_SETUP_PRECOMPILED_HEADERS. To check for
Hello,
For this to work in the current set of elifs you need to either combine
the checks for clang and opt-size into one conditional, so the final
else is still reached if toolchain is clang but opt-size is not present,
or add another else to the nested if statement like in the block above
f
Hi Erik,
Thanks for your review and valuable comments.
Updated: http://cr.openjdk.java.net/~jiefu/8247396/webrev.01/
Please review it and give me some adviece.
Thanks a lot.
Best regards,
Jie
On 2020/6/11, 8:37 PM, "Erik Joelsson" wrote:
I agree with the assessment, but I think the disa
I agree with the assessment, but I think the disabling should happen in
configure. That way the configure log can accurately tell the user why
it was disabled. This can be done by just adding another elif in
BPERF_SETUP_PRECOMPILED_HEADERS. To check for a jvm feature in
configure, you can use J
Hi all,
JBS:https://bugs.openjdk.java.net/browse/JDK-8247396
Webrev: http://cr.openjdk.java.net/~jiefu/8247396/webrev.00/
-O3 is used for clang on MacOS after JDK-8246751.
But it breaks the builds of VMs with opt-size feature when PCH is enabled.
The reason is that the PCH was built with -Os
