Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-24 Thread Kim Barrett
> On Jun 24, 2020, at 7:01 AM, Magnus Ihse Bursie > wrote: > > On 2020-06-18 08:34, Kim Barrett wrote: >>> On Jun 15, 2020, at 7:41 AM, Kim Barrett wrote: >>> On Jun 14, 2020, at 12:45 AM, Philip Race wrote: Kim, Until it says in "the JDK" and not "in

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-24 Thread Magnus Ihse Bursie
On 2020-06-15 23:23, Erik Joelsson wrote: The makefile test documentation is in the repo, so you could link directly to it: https://hg.openjdk.java.net/jdk/jdk/raw-file/87828d2e32fe/doc/testing.html Which reminds me that Magnus should update that documentation with these new options. Ok,

Re: OpenJDK extension to AArch64 and Windows

2020-06-24 Thread Ludovic Henry
Hi Magnus, Happy to answer any question you have on the build system changes. A lot of the changes were due to the build system not supporting cross-compilation well when targetting the microsoft toolchain (it just never really had to support it). We had to go through a few hoops to remove as

Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-24 Thread coleen . phillimore
Hi Adrian, Thank you for replying and having a look.  I hope you like the patch, but if not, we'll fix it. Sorry for rushing the push.  I was sitting on too many changed files. Thanks, Coleen On 6/24/20 4:03 PM, John Paul Adrian Glaubitz wrote: Hi Coleen! On 6/24/20 8:42 PM,

Re: OpenJDK extension to AArch64 and Windows

2020-06-24 Thread Magnus Ihse Bursie
Hi Monica, All build system changes must be sent to build-dev for review by the build team, and you are doing quite a lot of build changes. (I'm cc:ing build-dev now.) I did a quick scan and found some changes that looked odd enough to draw my attention. I will need some time to fully

Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-24 Thread John Paul Adrian Glaubitz
Hi Coleen! On 6/24/20 8:42 PM, coleen.phillim...@oracle.com wrote: > Thank you for replying! > I was going to wait for Adrian but it's a big enough change that it would bit > rot if I > waited too long, and I didn't know how long it would be.  We can fix anything > that is > disagreeable with a

Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-24 Thread coleen . phillimore
Hi Chris, Thank you for replying! I was going to wait for Adrian but it's a big enough change that it would bit rot if I waited too long, and I didn't know how long it would be.  We can fix anything that is disagreeable with a future patch, I think.  So I pushed it today. Thanks, Coleen On

Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-24 Thread Chris Phillips
Hi Coleen, On 2020-06-23 16:35, coleen.phillim...@oracle.com wrote: > > Including build-dev. > > On 6/23/20 12:17 AM, David Holmes wrote: >> Hi Coleen, >> >> Cleanup is looking good but a few comments: >> >> - if the bytecodeInterpreter is also zero-only can we rename its files >> too? (I

Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-24 Thread coleen . phillimore
Thank you, David! Coleen On 6/24/20 12:13 AM, David Holmes wrote: I thoroughly applaud the introduction of interpreter/zero directory! Thank you. :) Updates look good to me. Thanks, David On 24/06/2020 6:35 am, coleen.phillim...@oracle.com wrote: Including build-dev. On 6/23/20 12:17 AM,

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-24 Thread Magnus Ihse Bursie
On 2020-06-18 08:34, Kim Barrett wrote: On Jun 15, 2020, at 7:41 AM, Kim Barrett wrote: On Jun 14, 2020, at 12:45 AM, Philip Race wrote: Kim, Until it says in "the JDK" and not "in HotSpot" you have not addressed my main point. Please rename the JEP. After some off-list discussions I

Re: RFR docs 8240777: Update all nroff manpages for JDK 15 release

2020-06-24 Thread David Holmes
Hi Pavel, On 24/06/2020 7:35 pm, Pavel Rappo wrote: David, I'm planning to review and push manpage changes that will have accumulate by Rampdown Phase Two, which is on 2020-07-16. Any updates after that date could be performed by the component owners themselves; I think this is reasonable,

Re: RFR docs 8240777: Update all nroff manpages for JDK 15 release

2020-06-24 Thread Pavel Rappo
David, I'm planning to review and push manpage changes that will have accumulate by Rampdown Phase Two, which is on 2020-07-16. Any updates after that date could be performed by the component owners themselves; I think this is reasonable, would you agree? -Pavel > On 11 Jun 2020, at 03:42,