Re: OpenJDK extension to AArch64 and Windows

2020-06-29 Thread Ludovic Henry
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- Hi Magnus, > I have now looked a bit more closely

Re: RFR: JDK-8248488 JDK-8246484 actually broke COMPARE_BUILD

2020-06-29 Thread Erik Joelsson
Looks ok. /Erik On 2020-06-29 08:50, Magnus Ihse Bursie wrote: Unfortunately JDK-8246484, which was supposed to make COMPARE_BUILD testing more robust, actually broke COMPARE_BUILD. :-( That patch tries to apply the patch with --dry-run at make startup, which was a good idea. Unfortunately,

RFR: JDK-8248488 JDK-8246484 actually broke COMPARE_BUILD

2020-06-29 Thread Magnus Ihse Bursie
Unfortunately JDK-8246484, which was supposed to make COMPARE_BUILD testing more robust, actually broke COMPARE_BUILD. :-( That patch tries to apply the patch with --dry-run at make startup, which was a good idea. Unfortunately, it tries to do so as well when running the second time in compare

Re: OpenJDK extension to AArch64 and Windows

2020-06-29 Thread Magnus Ihse Bursie
I have now looked a bit more closely at the code. This is what I have found so far that attracted my eye. Please note that this is not a complete review. When you have a JEP and a test plan for how to verify these changes and make sure you do not break existing platforms, you can post a new

Re: RFR [XS]: 8248429: Add --enable-preview as VM argument when running microbenchmarks

2020-06-29 Thread Erik Joelsson
Looks good. /Erik On 2020-06-26 15:14, Jorn Vernee wrote: Hi, https://bugs.openjdk.java.net/browse/JDK-8248135 added --enable-preview to the javac options when building micro benchmarks. We should also add it to the set of default VM arguments passed to the microbenchmark jar so it