Hi Magnus,
Dropping hotspot-runtime-dev.
As you posted the patch you mentioned before (see
https://mail.openjdk.java.net/pipermail/build-dev/2020-July/027872.html), I
want to share an updated patch for the build system rebased on top of your
patch. (I understand your patch still needs to go
Hi,
I tried out your changes locally, and with Yasumasa's change and the following
diff [1], I can confirm that this works on my setup (VS2019 devkit w/ Cygwin).
I'll give a spin with WSL1 and WSL2, as well as VS2017.
[1] Diff to fix support for VS2019
---
Hi,
I have found it very useful to be able to run benchmarks against multiple
versions of the JDK. Build the benchmark jar once and to compare results.
If all of the classes are built with --enable-preview, none of them will
run
against older JDKs. So an approach that only compiles those
On 30/06/2020 22:51, Erik Joelsson wrote:
On 2020-06-30 13:15, Claes Redestad wrote:
On 2020-06-30 22:12, Magnus Ihse Bursie wrote:
Second to that a solution in the build would be preferable - if we can
come up with something that has infinitesimal impact to build times.
Are we talking about
On 7/7/20 4:26 PM, Peter Levart wrote:
I suggest adding --enable-preview to JMH_JVM_ARGS in general now (it
doesn't hurt even if classes are not compiled with --enable-preview)
and then take time to devise an effective strategy for selectively
compiling micro benchmarks with or without
> On Jul 7, 2020, at 9:59 AM, Erik Joelsson wrote:
>
> Doc changes look good.
>
> /Erik
>
> On 2020-07-06 18:10, Kim Barrett wrote:
>> I just noticed that doc/building.{md,html} describes minimum toolchain
>> versions,
>> so also needs to be updated. Here’s the update, matching what’s now in
On Mon, Jul 6, 2020 at 10:50 PM Simon Tooke wrote:
> (Disclaimer: I am not a reviewer, so this is an opinion, not a review)
>
> I have tested this on Windows and it built without issue, although the
> submit repo should be the final gate. I'd also like to add my void to
> simply redefining
I suggest adding --enable-preview to JMH_JVM_ARGS in general now (it
doesn't hurt even if classes are not compiled with --enable-preview) and
then take time to devise an effective strategy for selectively compiling
micro benchmarks with or without --enable-preview. At least so the
benchmarks
Doc changes look good.
/Erik
On 2020-07-06 18:10, Kim Barrett wrote:
I just noticed that doc/building.{md,html} describes minimum toolchain versions,
so also needs to be updated. Here’s the update, matching what’s now in the JEP:
full: https://cr.openjdk.java.net/~kbarrett/8246032/open.05/
Yes, Chris, this is the same thing. I wasn't aware of it.
Peter
On 7/7/20 11:00 AM, Chris Hegarty wrote:
Peter,
8248429 [1] tracks this issue, right?
There was a recent thread on build-dev relating to this, in the form of an RFR
from Jorn :
Peter,
8248429 [1] tracks this issue, right?
There was a recent thread on build-dev relating to this, in the form of an RFR
from Jorn :
https://mail.openjdk.java.net/pipermail/build-dev/2020-June/thread.html#27804
Some great discussion was had, but I’m not sure that a conclusion was reached
The following patch seems to fix this problem:
===
--- make/RunTests.gmk (revision
60064:00a964b6ab716706f0deab6dd04b43f31b1939c0)
+++ make/RunTests.gmk (revision 60064+:00a964b6ab71+)
@@ -693,6 +693,9 @@
# Set library
A quick work-around for anyone wanting to run the microbenchmarks is to
pass --enable-preview explicitly. For example:
make test TEST="micro:java.util.stream.ops"
MICRO="JAVA_OPTIONS=--enable-preview"
Regards, Peter
On 7/7/20 10:23 AM, Peter Levart wrote:
On 7/7/20 10:13 AM, David
On 7/7/20 10:13 AM, David Holmes wrote:
Hi Peter,
cc Claes
On 7/07/2020 5:59 pm, Peter Levart wrote:
Hi,
Recently I proposed and pushed a change for [1] which adds
--enable-preview option to javac compilation of JMH microbenchmarks
in general to enable running a benchmark that uses
Hi Peter,
cc Claes
On 7/07/2020 5:59 pm, Peter Levart wrote:
Hi,
Recently I proposed and pushed a change for [1] which adds
--enable-preview option to javac compilation of JMH microbenchmarks in
general to enable running a benchmark that uses preview feature
(Records). This makes the
Hi,
Recently I proposed and pushed a change for [1] which adds
--enable-preview option to javac compilation of JMH microbenchmarks in
general to enable running a benchmark that uses preview feature
(Records). This makes the class files produced marked with version
60.65535. The benchmark
16 matches
Mail list logo
