Re: [15] RFR: JDK-8249255: Build fails if source code in cygwin home dir

2020-07-13 Thread Tim Bell
Erik: > The fix is to make sure WORKSPACE_ROOT in basics.m4 only gets values > that have been fixed using UTIL_FIXUP_PATH. Looks good. Tim This is a fix for the problem reported by Ty in this thread: https://mail.openjdk.java.net/pipermail/build-dev/2020-July/027917.html The problem is the

[15] RFR: JDK-8249255: Build fails if source code in cygwin home dir

2020-07-13 Thread Erik Joelsson
This is a fix for the problem reported by Ty in this thread: https://mail.openjdk.java.net/pipermail/build-dev/2020-July/027917.html The problem is the --disable-absolute-paths-in-output option, which is default set to disable on release builds. When not allowing absolute paths, we rewrite abs

Re: cannot find valid Visual Code Studio install

2020-07-13 Thread Erik Joelsson
Filed https://bugs.openjdk.java.net/browse/JDK-8249255 /Erik On 2020-07-13 11:04, Erik Joelsson wrote: There seems to be something with the absolute path elimination that doesn't work when the workspace is located inside the c:/cygwin64 dir. As a workaround, you can either try moving the sourc

Re: cannot find valid Visual Code Studio install

2020-07-13 Thread Erik Joelsson
There seems to be something with the absolute path elimination that doesn't work when the workspace is located inside the c:/cygwin64 dir. As a workaround, you can either try moving the source to a directory outside of c:/cygwin64 or run configure with --enable-absolute-paths-in-output. I'm s

Re: RFR [XS]: 8248429: Add --enable-preview as VM argument when running microbenchmarks

2020-07-13 Thread Jorn Vernee
Hey Peter, Thank you for looking into this. I planned on coming back to this later, as it wasn't as much of a quick-fix as I'd hoped, but got caught up working on other issues in the mean time. Jorn On 11/07/2020 12:00, Peter Levart wrote: On 7/11/20 9:31 AM, Peter Levart wrote: - compile

Re: RFR [XS]: 8248429: Add --enable-preview as VM argument when running microbenchmarks

2020-07-13 Thread Erik Joelsson
Hello Peter, On 2020-07-11 03:00, Peter Levart wrote: On 7/11/20 9:31 AM, Peter Levart wrote: - compile the two sets of benchmarks separately with separate output directories and create separate benchmarks.jar files for them Here's my attempt at a patch for separate benchmarks.jar files. T