Re: RFR: JDK-8249292: DependOnVariable macro fails on empty value

2020-07-14 Thread Tim Bell
Erik: The DependOnVariable macro fails if the variable is empty. The failure is rather non intuitive as it complains that the vardeps file doesn't exist and is needed for the target. This patch make the macro treat an empty variable value just like any other value. I'm also adding test cases

RFR: JDK-8249292: DependOnVariable macro fails on empty value

2020-07-14 Thread Erik Joelsson
The DependOnVariable macro fails if the variable is empty. The failure is rather non intuitive as it complains that the vardeps file doesn't exist and is needed for the target. This patch make the macro treat an empty variable value just like any other value. I'm also adding test cases to verif

Re: cannot find valid Visual Code Studio install

2020-07-14 Thread Erik Joelsson
On 2020-07-14 01:52, Ty Young wrote: Question: are Windows builds generally slower than Linux builds? It feels like building under cygwin is a bit slower, but I can't be sure. Yes, Windows builds are most definitely slower. Emulating a Unix like environment on top of Windows is inherently

Re: cannot find valid Visual Code Studio install

2020-07-14 Thread Ty Young
On 7/13/20 1:04 PM, Erik Joelsson wrote: There seems to be something with the absolute path elimination that doesn't work when the workspace is located inside the c:/cygwin64 dir. As a workaround, you can either try moving the source to a directory outside of c:/cygwin64 or run configure with