Hi,
I noticed the indent problems at 434 & 436 myself once I looked at it as
a webrev,
so I was already updating the fix with those but I've also fixed the
rest you pointed out.
I've uploaded a new webrev with all of these resolved :-
http://cr.openjdk.java.net/~prr/8249821.1
-phil
On 7/21/
Hello Phil,
This looks pretty good, only some style nits.
Awt2dLibraries.gmk
428 and 466: These comments aren't relevant anymore now that harfbuzz is
its own library.
434: Missed indent of 2
436: Too much indent (should be 2)
459-464: Too much indent
493-494: Too much indent
/Erik
On 20
Bug: https://bugs.openjdk.java.net/browse/JDK-8249821
Webrev: http://cr.openjdk.java.net/~prr/8249821/
This fix breaks out libharfbuzz from libfontmanager.
As well as building I've done extensive testing on all platforms.
I have tweaked the disabled warnings so we don't have un-needed duplicatio
+1
On 21.07.2020 12:24, Erik Joelsson wrote:
Here is a late fix for Macos Catalina. In JDK-8244951, I added a missing
entitlement to enable sound recording with the hardened runtime signing. It was
later discovered that this wasn't quite enough. To be able to record sound you
also need to spe
LGTM.
-phil
On 7/21/20, 12:24 PM, Erik Joelsson wrote:
Here is a late fix for Macos Catalina. In JDK-8244951, I added a
missing entitlement to enable sound recording with the hardened
runtime signing. It was later discovered that this wasn't quite
enough. To be able to record sound you also n
Here is a late fix for Macos Catalina. In JDK-8244951, I added a missing
entitlement to enable sound recording with the hardened runtime signing.
It was later discovered that this wasn't quite enough. To be able to
record sound you also need to specify a certain key in your Info.plist,
NSMicrop
> 20 juli 2020 kl. 15:32 skrev Erik Joelsson :
>
> Hello Jie,
>
> Your change looks fine if you really think this is a problem.
>
> However, in Autoconf all --enable-* options have a corresponding --disable-*
> (and every --with-* has a --without-*). Always explicitly listing both in all
> h
