Re: RFR: JDK-8252145: Unify Info.plist files with correct version strings

2020-08-26 Thread Sergey Bylokhov
+1 On 26.08.2020 08:01, Erik Joelsson wrote: I realized that for LTS releases, the logic adding a numeric only $OPT string will bail out as we (Oracle) are then adding LTS to the $OPT string. To fix this, I've added an explicit setting of the new configure parameter --with-macosx-bundle-build

Re: RFR: JDK-8252145: Unify Info.plist files with correct version strings

2020-08-26 Thread Erik Joelsson
I realized that for LTS releases, the logic adding a numeric only $OPT string will bail out as we (Oracle) are then adding LTS to the $OPT string. To fix this, I've added an explicit setting of the new configure parameter --with-macosx-bundle-build-version from the jib configuration for CI buil

Re: JDK14 cross-compile to arm64 fails to locate c++ header new

2020-08-26 Thread Erik Joelsson
I'm not familiar with this tool for creating sysroot, but perhaps you need to add the libstdc++ dev package to get access to C++ headers? /Erik On 2020-08-25 19:46, Choe, Jiwon wrote: Hi Adrian, Thanks for the quick reply. Yes, I do have build-essential installed on the host system. I have cr

Re: [ping] [11u] RFR 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

2020-08-26 Thread Christoph Göttschkes
Thank you for the quick review, Severin. -- Christoph On 2020-08-26 12:10, Severin Gehwolf wrote: On Wed, 2020-08-26 at 11:29 +0200, Christoph Göttschkes wrote: Webrev: https://cr.openjdk.java.net/~cgo/8234535/webrev-11u.00/ This looks fine to me. Thanks, Severin

Re: [ping] [11u] RFR 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

2020-08-26 Thread Severin Gehwolf
On Wed, 2020-08-26 at 11:29 +0200, Christoph Göttschkes wrote: > > Webrev: https://cr.openjdk.java.net/~cgo/8234535/webrev-11u.00/ This looks fine to me. Thanks, Severin

[ping] [11u] RFR 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

2020-08-26 Thread Christoph Göttschkes
Hi, the webrev below still applies cleanly to jdk11u-dev. Could someone please review this downport? Thanks, Christoph On 2020-07-20 15:48, Christoph Göttschkes wrote: Hi, please review this downport of JDK-8234535 to jdk11u-dev. The changeset does not apply cleanly because of unrelated di