On 27.08.2020 12:55, Philip Race wrote:
SAP or IBM can look at it if they want as a separate fix.
ok, +1
-phil.
On 8/27/20, 12:45 PM, Sergey Bylokhov wrote:
Hi, Phil.
Probably we could enable WARNINGS_AS_ERRORS_xlc as well? I guess we will need a
confirmation from the SAP gurus.
On 27.
On 2020-08-28 14:50, Erik Joelsson wrote:
On 2020-08-28 00:51, Magnus Ihse Bursie wrote:
On 2020-08-27 23:26, Erik Joelsson wrote:
Hello Andrew,
We certainly appreciate contributions, but this patch as it
currently looks does not fit well with our current build system
model. I'm however not
Hi Erik,
Thank you for taking a look at this, what you say makes perfect sense, and
provides exactly what we're after.
I've taken a look at your patch, and have tested it on my Ubuntu VM and it
works a treat. I've also run it at Adopt on Windows & Mac, and produced
debug symbol images fine:
https
On 2020-08-28 00:51, Magnus Ihse Bursie wrote:
On 2020-08-27 23:26, Erik Joelsson wrote:
Hello Andrew,
We certainly appreciate contributions, but this patch as it currently
looks does not fit well with our current build system model. I'm
however not against adding a target for your usecase.
On 2020-08-24 19:21, Ludovic Henry wrote:
Hi Magnus,
I want to follow up on this work of yours, as we've particular interest in it
for the Windows-AArch64 port.
Let me know how I could assist you in this effort.
The big blockers for this fix is basically these two issues:
I have also tempor
On 2020-08-27 21:39, Philip Race wrote:
Bug : https://bugs.openjdk.java.net/browse/JDK-8074844
Webrev : http://cr.openjdk.java.net/~prr/8074844/index.html
Looks good to me.
Thank you Phil for cleaning this up!
/Magnus
This resolves the disabled compiler warnings in what is now quite a
sm
On 2020-08-27 23:26, Erik Joelsson wrote:
Hello Andrew,
We certainly appreciate contributions, but this patch as it currently
looks does not fit well with our current build system model. I'm
however not against adding a target for your usecase.
On a high level, just as Severin pointed out, t
Hi Severin,
So yes I guess maybe "debugsymbols-image" is more precise, we call it
"debugimage" at Adopt, see artifacts:
https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk15u/job/jdk15u-linux-x64-openj9/
that's less of a mouthful and I think we're used to that name, but if the
communi
On 2020-08-26 17:01, Erik Joelsson wrote:
I realized that for LTS releases, the logic adding a numeric only $OPT
string will bail out as we (Oracle) are then adding LTS to the $OPT
string. To fix this, I've added an explicit setting of the new
configure parameter --with-macosx-bundle-build-vers