Re: RFR: 8254311: Incorrect statements in createWindowsDevkit2017.sh

2020-10-12 Thread Tobias Hartmann
On Fri, 9 Oct 2020 15:39:18 GMT, Ludovic Henry wrote: > We made a typo in https://github.com/openjdk/jdk/pull/212 when updating > make/devkit/createWindowsDevkit2017.sh. Looks good to me. - Marked as reviewed by thartmann (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/581

Integrated: 8252407: Build failure with gcc-8+ and asan

2020-10-12 Thread eric . 1iu
On Mon, 12 Oct 2020 11:36:17 GMT, eric.1iu wrote: > Summary: Fix stringop-truncation warnings casused by gcc. > > The newer gcc(gcc-8 or higher) would warn for calls to bounded string > manipulation functions such as 'strncpy' that may either truncate the > copied string or leave the

Re: RFR: 8252407: Build failure with gcc-8+ and asan.

2020-10-12 Thread eric . 1iu
On Mon, 12 Oct 2020 13:49:52 GMT, Kim Barrett wrote: >> Summary: Fix stringop-truncation warnings casused by gcc. >> >> The newer gcc(gcc-8 or higher) would warn for calls to bounded string >> manipulation functions such as 'strncpy' that may either truncate the >> copied string or leave the

Re: RFR: 8223347: Integration of Vector API (Incubator) [v2]

2020-10-12 Thread Paul Sandoz
> This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in the > title): >

Re: RFR: 8254311: Incorrect statements in createWindowsDevkit2017.sh

2020-10-12 Thread Ludovic Henry
On Fri, 9 Oct 2020 16:09:27 GMT, Erik Joelsson wrote: >> We made a typo in https://github.com/openjdk/jdk/pull/212 when updating >> make/devkit/createWindowsDevkit2017.sh. > > Marked as reviewed by erikj (Reviewer). @TobiHartmann as you reported

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v8]

2020-10-12 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation > (see JEP 393 [1]). This iteration focus on improving the usability of the API > in 3 main ways: > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v6]

2020-10-12 Thread Maurizio Cimadamore
On Mon, 12 Oct 2020 11:42:04 GMT, Magnus Ihse Bursie wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Tweak referenced to MemoryAddressProxy in Utils.java > > Build changes look good. I've just uploaded a

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v7]

2020-10-12 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation > (see JEP 393 [1]). This iteration focus on improving the usability of the API > in 3 main ways: > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b

2020-10-12 Thread Naoto Sato
On Mon, 12 Oct 2020 09:32:38 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the patch for tzdata2020b integration into JDK. > > Release details can be found here: > > https://mm.icann.org/pipermail/tz-announce/2020-October/59.html > > Bug:

Re: RFR: 8252407: Build failure with gcc-8+ and asan.

2020-10-12 Thread Kim Barrett
On Mon, 12 Oct 2020 11:36:17 GMT, eric.1iu wrote: > Summary: Fix stringop-truncation warnings casused by gcc. > > The newer gcc(gcc-8 or higher) would warn for calls to bounded string > manipulation functions such as 'strncpy' that may either truncate the > copied string or leave the

Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b

2020-10-12 Thread Erik Joelsson
On Mon, 12 Oct 2020 09:32:38 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the patch for tzdata2020b integration into JDK. > > Release details can be found here: > > https://mm.icann.org/pipermail/tz-announce/2020-October/59.html > > Bug:

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-10-12 Thread Erik Joelsson
On Fri, 25 Sep 2020 20:14:29 GMT, Paul Sandoz wrote: > This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in

Re: RFR: 8252407: Build failure with gcc-8+ and asan.

2020-10-12 Thread Magnus Ihse Bursie
On Mon, 12 Oct 2020 11:36:17 GMT, eric.1iu wrote: > Summary: Fix stringop-truncation warnings casused by gcc. > > The newer gcc(gcc-8 or higher) would warn for calls to bounded string > manipulation functions such as 'strncpy' that may either truncate the > copied string or leave the

Re: RFR: 8252407: Build failure with gcc-8+ and asan.

2020-10-12 Thread eric . 1iu
On Mon, 12 Oct 2020 11:36:17 GMT, eric.1iu wrote: > Summary: Fix stringop-truncation warnings casused by gcc. > > The newer gcc(gcc-8 or higher) would warn for calls to bounded string > manipulation functions such as 'strncpy' that may either truncate the > copied string or leave the

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v6]

2020-10-12 Thread Magnus Ihse Bursie
On Mon, 12 Oct 2020 10:50:48 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the third incubation round >> of the foreign memory access API incubation >> (see JEP 393 [1]). This iteration focus on improving the usability of the >> API in 3 main ways: >> *

RFR: 8252407: Build failure with gcc-8+ and asan.

2020-10-12 Thread eric . 1iu
Summary: Fix stringop-truncation warnings casused by gcc. The newer gcc(gcc-8 or higher) would warn for calls to bounded string manipulation functions such as 'strncpy' that may either truncate the copied string or leave the destination unchanged. The reason is that -fsanitize=address might

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v6]

2020-10-12 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation > (see JEP 393 [1]). This iteration focus on improving the usability of the API > in 3 main ways: > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v2]

2020-10-12 Thread Magnus Ihse Bursie
On Thu, 8 Oct 2020 20:28:33 GMT, Bernhard Urban-Forster wrote: >> I organized this PR so that each commit contains the warning emitted by MSVC >> as commit message and its relevant fix. >> >> Verified on >> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures. >> * Windows+ARM64:

Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b

2020-10-12 Thread Kiran Sidhartha Ravikumar
On Mon, 12 Oct 2020 09:32:38 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the patch for tzdata2020b integration into JDK. > > Release details can be found here: > > https://mm.icann.org/pipermail/tz-announce/2020-October/59.html > > Bug:

RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b

2020-10-12 Thread Kiran Sidhartha Ravikumar
Hi Guys, Please review the patch for tzdata2020b integration into JDK. Release details can be found here: https://mm.icann.org/pipermail/tz-announce/2020-October/59.html Bug: https://bugs.openjdk.java.net/browse/JDK-8254177 I had the pacificnew, systemv files removed from JDK repo and so