Re: RFR: 8254862: lldb in devkit doesn't work

2020-10-16 Thread Mikael Vidstedt
On Fri, 16 Oct 2020 20:34:15 GMT, Erik Joelsson wrote: > This patch adds the lldb framework to the macosx devkit to make it possible > to run the lldb debugger. Marked as reviewed by mikael (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/711

Re: RFR: 8254862: lldb in devkit doesn't work

2020-10-16 Thread Leonid Mesnik
On Fri, 16 Oct 2020 20:34:15 GMT, Erik Joelsson wrote: > This patch adds the lldb framework to the macosx devkit to make it possible > to run the lldb debugger. Marked as reviewed by lmesnik (Committer). - PR: https://git.openjdk.java.net/jdk/pull/711

Re: RFR: 8254178: Remove .hgignore

2020-10-16 Thread Azeem Jiva
On Wed, 7 Oct 2020 18:19:40 GMT, Aleksey Shipilev wrote: > After migration to Git, this serves no purpose. The file is not updated, does > not seem to be used. We can easily remove > it. > There is also .hgtags, but that might have some value for verification, so > let's keep it around until Me

RFR: 8254862: lldb in devkit doesn't work

2020-10-16 Thread Erik Joelsson
This patch adds the lldb framework to the macosx devkit to make it possible to run the lldb debugger. - Commit messages: - Add lldb to macosx devkit Changes: https://git.openjdk.java.net/jdk/pull/711/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=711&range=00 Issue:

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12

2020-10-16 Thread Jonathan Gibbons
On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote: > This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc > behavior to more closely adhere to JEP 12. > The notable changes are: > > * adding support for Preview APIs (javac un

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12

2020-10-16 Thread Erik Joelsson
On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote: > This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc > behavior to more closely adhere to JEP 12. > The notable changes are: > > * adding support for Preview APIs (javac un

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12

2020-10-16 Thread Maurizio Cimadamore
On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote: > This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc > behavior to more closely adhere to JEP 12. > The notable changes are: > > * adding support for Preview APIs (javac un

RFR: JDK-8250768: javac should be adapted to changes in JEP 12

2020-10-16 Thread Jan Lahoda
This is an update to javac and javadoc, to introduce support for Preview APIs, and generally improve javac and javadoc behavior to more closely adhere to JEP 12. The notable changes are: * adding support for Preview APIs (javac until now supported primarily only preview language features, and

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]

2020-10-16 Thread Jorn Vernee
On Thu, 15 Oct 2020 22:42:49 GMT, Coleen Phillimore wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Re-add file erroneously deleted (detected as rename) > > src/hotspot/cpu/x86/foreign_globals_x86.cpp line 5

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]

2020-10-16 Thread Jorn Vernee
On Thu, 15 Oct 2020 22:52:14 GMT, Coleen Phillimore wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Re-add file erroneously deleted (detected as rename) > > src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp line

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]

2020-10-16 Thread Jorn Vernee
On Thu, 15 Oct 2020 22:44:54 GMT, Coleen Phillimore wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Re-add file erroneously deleted (detected as rename) > > src/hotspot/cpu/x86/foreign_globals_x86.hpp line 3

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v12]

2020-10-16 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation > (see JEP 393 [1]). This iteration focus on improving the usability of the API > in 3 main ways: > * first, by providing a way to obtain truly *shared* segments, which can b

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]

2020-10-16 Thread Jorn Vernee
On Thu, 15 Oct 2020 22:39:50 GMT, Coleen Phillimore wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Re-add file erroneously deleted (detected as rename) > > src/hotspot/cpu/x86/foreign_globals_x86.cpp line 2