Re: RFR: 8254282: Add Linux x86_32 builds to submit workflow [v2]

2020-10-19 Thread Aleksey Shipilev
> Building x86_32 usually exposes 32/64 cleanliness problems early. Since > 32-bit builds break often, it might make sense > to add them to submit workflow. The x86_32 might not be widely deployed by > itself, but 32/64 bit cleanliness detects > bugs that manifest on ARM32 early. Aleksey

Re: JDK14 cross-compile to arm64 fails with linking error

2020-10-19 Thread David Holmes
Hi, On 19/10/2020 12:53 pm, Choe, Jiwon wrote: Hello all, I'm trying to cross-compile JDK 14 to target aarch64-linux-gnu, from a 64-bit x86 Linux (Ubuntu 18.04). I followed the steps described in the documentation (

Integrated: 8255020: Minor updates to docs jdk.incubator.vector

2020-10-19 Thread Paul Sandoz
On Mon, 19 Oct 2020 18:41:31 GMT, Paul Sandoz wrote: > Minor updates, with no specification changes, to the documentation of Vector > API. > > The compilation of the Vector module was updated to turn on doclint errors > for >= protected documentation. This pull request has now been

Re: RFR: 8255020: Minor updates to docs jdk.incubator.vector

2020-10-19 Thread Joe Darcy
On Mon, 19 Oct 2020 18:41:31 GMT, Paul Sandoz wrote: > Minor updates, with no specification changes, to the documentation of Vector > API. > > The compilation of the Vector module was updated to turn on doclint errors > for >= protected documentation. Marked as reviewed by darcy (Reviewer).

Re: RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c

2020-10-19 Thread Naoto Sato
On Mon, 19 Oct 2020 18:44:28 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the integration of tzdata2020c to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-October/60.html > Bug:

Re: RFR: 8255020: Minor updates to docs jdk.incubator.vector

2020-10-19 Thread Erik Joelsson
On Mon, 19 Oct 2020 18:41:31 GMT, Paul Sandoz wrote: > Minor updates, with no specification changes, to the documentation of Vector > API. > > The compilation of the Vector module was updated to turn on doclint errors > for >= protected documentation. Build change looks ok. -

Re: RFR: 8206311: Add docs-javase, docs-reference to CI build

2020-10-19 Thread Magnus Ihse Bursie
On Wed, 9 Sep 2020 22:50:52 GMT, Erik Joelsson wrote: > Reposting this review as PR. > > In order to regularly build the javase and reference docs images, I have made > the following changes: > > 1. Introduced bundle targets for the javase and reference docs images. > 2. To run this in CI

Re: RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c

2020-10-19 Thread Erik Joelsson
On Mon, 19 Oct 2020 18:44:28 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the integration of tzdata2020c to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-October/60.html > Bug:

RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c

2020-10-19 Thread Kiran Sidhartha Ravikumar
Hi Guys, Please review the integration of tzdata2020c to JDK. Details regarding the change can be viewed at - https://mm.icann.org/pipermail/tz-announce/2020-October/60.html Bug: https://bugs.openjdk.java.net/browse/JDK-8254982 Along with it, there is a test fix for

RFR: 8255020: Minor updates to docs jdk.incubator.vector

2020-10-19 Thread Paul Sandoz
Minor updates, with no specification changes, to the documentation of Vector API. The compilation of the Vector module was updated to turn on doclint errors for >= protected documentation. - Commit messages: - 8255020:Minor updates to docs jdk.incubator.vector Changes:

Integrated: 8253660: Need better error report when artifact resolution fails in AotCompiler.java

2020-10-19 Thread Erik Joelsson
On Fri, 25 Sep 2020 20:35:32 GMT, Erik Joelsson wrote: > In AotCompiler.java, if artifact resolution fails, we have no way of > diagnosing the error. This patch improves the > default toString() of ArtifactResolverException to automatically include the > toString() method of the root cause. It

Integrated: 8254862: lldb in devkit doesn't work

2020-10-19 Thread Erik Joelsson
On Fri, 16 Oct 2020 20:34:15 GMT, Erik Joelsson wrote: > This patch adds the lldb framework to the macosx devkit to make it possible > to run the lldb debugger. This pull request has now been integrated. Changeset: 52cb3292 Author:Erik Joelsson URL:

Re: RFR: 8206311: Add docs-javase, docs-reference to CI build

2020-10-19 Thread Erik Joelsson
On Mon, 19 Oct 2020 07:00:29 GMT, Magnus Ihse Bursie wrote: >> Reposting this review as PR. >> >> In order to regularly build the javase and reference docs images, I have >> made the following changes: >> >> 1. Introduced bundle targets for the javase and reference docs images. >> 2. To run

Re: JDK14 cross-compile to arm64 fails with linking error

2020-10-19 Thread Erik Joelsson
Hello, I don't recognize the error and can't be much help there, but I would recommend you use the latest sources for the JDK release you want to build to maximize your chances at success. For 14, that would be: http://hg.openjdk.java.net/jdk-updates/jdk14u/ Note though that nobody is

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v6]

2020-10-19 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and > associated pull request [3]). > The main goal of this API

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12

2020-10-19 Thread Jan Lahoda
On Mon, 19 Oct 2020 14:22:17 GMT, Hannes Wallnöfer wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java >> line 2238: >> >>> 2236: if (previewTree != null) { >>> 2237: previewDiv.add(new >>>

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12

2020-10-19 Thread Hannes Wallnöfer
On Mon, 19 Oct 2020 14:09:51 GMT, Hannes Wallnöfer wrote: >> This is an update to javac and javadoc, to introduce support for Preview >> APIs, and generally improve javac and javadoc >> behavior to more closely adhere to JEP 12. >> The notable changes are: >> >> * adding support for Preview

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12

2020-10-19 Thread Hannes Wallnöfer
On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote: > This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc > behavior to more closely adhere to JEP 12. > The notable changes are: > > * adding support for Preview APIs (javac

Re: RFR: 8254282: Add Linux x86_32 builds to submit workflow

2020-10-19 Thread Robin Westberg
On Mon, 12 Oct 2020 12:46:57 GMT, Aleksey Shipilev wrote: > Building x86_32 usually exposes 32/64 cleanliness problems early. Since > 32-bit builds break often, it might make sense > to add them to submit workflow. The x86_32 might not be widely deployed by > itself, but 32/64 bit cleanliness

Re: RFR: 8254282: Add Linux x86_32 builds to submit workflow

2020-10-19 Thread Erik Joelsson
On Mon, 12 Oct 2020 12:46:57 GMT, Aleksey Shipilev wrote: > Building x86_32 usually exposes 32/64 cleanliness problems early. Since > 32-bit builds break often, it might make sense > to add them to submit workflow. The x86_32 might not be widely deployed by > itself, but 32/64 bit cleanliness

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]

2020-10-19 Thread Jorn Vernee
On Fri, 16 Oct 2020 11:12:01 GMT, Jorn Vernee wrote: >> src/hotspot/cpu/x86/foreign_globals_x86.cpp line 56: >> >>> 54: } >>> 55: >>> 56: const ABIDescriptor parseABIDescriptor(JNIEnv* env, jobject jabi) { >> >> I don't know if you care about performance but of these env->calls >> transition

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]

2020-10-19 Thread Jorn Vernee
On Thu, 15 Oct 2020 23:15:07 GMT, Coleen Phillimore wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Re-add file erroneously deleted (detected as rename) > > I looked through some Hotspot runtime code and

Re: RFR: 8254827: JVMCI: Enable it for Windows+AArch64

2020-10-19 Thread Magnus Ihse Bursie
On Thu, 15 Oct 2020 15:00:47 GMT, Bernhard Urban-Forster wrote: > Use r18 as allocatable register on Linux only. > > A bootstrap works now (it has been crashing before due to r18 being > allocated): > $ > ./windows-aarch64-server-fastdebug/bin/java.exe > -XX:+UnlockExperimentalVMOptions

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v6]

2020-10-19 Thread Maurizio Cimadamore
On Mon, 12 Oct 2020 18:06:55 GMT, Maurizio Cimadamore wrote: >> Build changes look good. > > I've just uploaded a biggie update to the foreign memory access support. > While doing performance evaluation, we have > realized that mixing a multi-level hierarchy (`MappedMemorySegment extends >

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v13]

2020-10-19 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation > (see JEP 393 [1]). This iteration focus on improving the usability of the API > in 3 main ways: > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8206311: Add docs-javase, docs-reference to CI build

2020-10-19 Thread Magnus Ihse Bursie
On Wed, 9 Sep 2020 22:50:52 GMT, Erik Joelsson wrote: > Reposting this review as PR. > > In order to regularly build the javase and reference docs images, I have made > the following changes: > > 1. Introduced bundle targets for the javase and reference docs images. > 2. To run this in CI

Re: RFR: 8253660: Need better error report when artifact resolution fails in AotCompiler.java

2020-10-19 Thread Magnus Ihse Bursie
On Fri, 25 Sep 2020 20:35:32 GMT, Erik Joelsson wrote: > In AotCompiler.java, if artifact resolution fails, we have no way of > diagnosing the error. This patch improves the > default toString() of ArtifactResolverException to automatically include the > toString() method of the root cause. It

Re: RFR: 8254862: lldb in devkit doesn't work

2020-10-19 Thread Magnus Ihse Bursie
On Fri, 16 Oct 2020 20:34:15 GMT, Erik Joelsson wrote: > This patch adds the lldb framework to the macosx devkit to make it possible > to run the lldb debugger. Looks good to me - Marked as reviewed by ihse (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/711

Integrated: 8254178: Remove .hgignore

2020-10-19 Thread Aleksey Shipilev
On Wed, 7 Oct 2020 18:19:40 GMT, Aleksey Shipilev wrote: > After migration to Git, this serves no purpose. The file is not updated, does > not seem to be used. We can easily remove > it. > There is also .hgtags, but that might have some value for verification, so > let's keep it around until