Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v6]

2020-10-20 Thread David Holmes
On Wed, 21 Oct 2020 02:28:30 GMT, Kim Barrett wrote: >> Finally returning to this review that was started in April 2020. I've >> recast it as a github PR. I think the security concern raised by Gil >> has been adequately answered. >>

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v6]

2020-10-20 Thread Kim Barrett
> Finally returning to this review that was started in April 2020. I've > recast it as a github PR. I think the security concern raised by Gil > has been adequately answered. > https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2020-April/029203.html >

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v5]

2020-10-20 Thread Kim Barrett
On Tue, 20 Oct 2020 16:35:02 GMT, Mandy Chung wrote: >>> @kimbarrett your reworded text is okay. I think "if it initially had some >>> other referent value" can be dropped. >>> >>> For a `Reference` constructed with a `null` referent, we can clarify in the >>> spec that such reference object

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

2020-10-20 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and > associated pull request [3]). > The main goal of this API

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v5]

2020-10-20 Thread Mandy Chung
On Tue, 20 Oct 2020 05:22:57 GMT, Kim Barrett wrote: >> @kimbarrett your reworded text is okay. I think "if it initially had some >> other referent value" can be dropped. >> >> For a `Reference` constructed with a `null` referent, we can clarify in the >> spec that such reference object

Re: RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c [v2]

2020-10-20 Thread Naoto Sato
On Tue, 20 Oct 2020 11:39:36 GMT, Kiran Sidhartha Ravikumar wrote: >> Hi Guys, >> >> Please review the integration of tzdata2020c to JDK. >> >> Details regarding the change can be viewed at - >> https://mm.icann.org/pipermail/tz-announce/2020-October/60.html >> Bug:

Re: RFR: 8254827: JVMCI: Enable it for Windows+AArch64 [v3]

2020-10-20 Thread Bernhard Urban-Forster
> Use r18 as allocatable register on Linux only. > > A bootstrap works now (it has been crashing before due to r18 being > allocated): > $ > ./windows-aarch64-server-fastdebug/bin/java.exe > -XX:+UnlockExperimentalVMOptions -XX:+UseJVMCICompiler -XX:+BootstrapJVMCI > -version > Bootstrapping

Re: RFR: 8254827: JVMCI: Enable it for Windows+AArch64 [v2]

2020-10-20 Thread Bernhard Urban-Forster
On Mon, 19 Oct 2020 11:03:46 GMT, Magnus Ihse Bursie wrote: >> Bernhard Urban-Forster has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - rename argument to canUsePlatformRegister >> - comment for platformRegister > > Build changes look

Re: RFR: 8254827: JVMCI: Enable it for Windows+AArch64 [v2]

2020-10-20 Thread Bernhard Urban-Forster
> Use r18 as allocatable register on Linux only. > > A bootstrap works now (it has been crashing before due to r18 being > allocated): > $ > ./windows-aarch64-server-fastdebug/bin/java.exe > -XX:+UnlockExperimentalVMOptions -XX:+UseJVMCICompiler -XX:+BootstrapJVMCI > -version > Bootstrapping

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v2]

2020-10-20 Thread Maurizio Cimadamore
On Tue, 20 Oct 2020 12:15:23 GMT, Jan Lahoda wrote: >> This is an update to javac and javadoc, to introduce support for Preview >> APIs, and generally improve javac and javadoc >> behavior to more closely adhere to JEP 12. >> The notable changes are: >> >> * adding support for Preview APIs

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v2]

2020-10-20 Thread Jan Lahoda
On Fri, 16 Oct 2020 16:47:25 GMT, Erik Joelsson wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now >> contains 35 commits: >> - Merge branch 'JDK-8250768-dev' of https://github.com/lahodaj/jdk into >> JDK-8250768 >> -

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v2]

2020-10-20 Thread Jan Lahoda
> This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc > behavior to more closely adhere to JEP 12. > The notable changes are: > > * adding support for Preview APIs (javac until now supported primarily only > preview language

Re: RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c [v2]

2020-10-20 Thread Kiran Sidhartha Ravikumar
> Hi Guys, > > Please review the integration of tzdata2020c to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-October/60.html > Bug: https://bugs.openjdk.java.net/browse/JDK-8254982 > > Along with it, there is a test fix for >

Re: RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c [v2]

2020-10-20 Thread Kiran Sidhartha Ravikumar
On Mon, 19 Oct 2020 19:38:57 GMT, Naoto Sato wrote: >> Kiran Sidhartha Ravikumar has updated the pull request with a new target >> base due to a merge or a rebase. The >> incremental webrev excludes the unrelated changes brought in by the >> merge/rebase. The pull request contains three >>

Re: RFR: 8254827: JVMCI: Enable it for Windows+AArch64

2020-10-20 Thread Doug Simon
On Thu, 15 Oct 2020 15:00:47 GMT, Bernhard Urban-Forster wrote: > Use r18 as allocatable register on Linux only. > > A bootstrap works now (it has been crashing before due to r18 being > allocated): > $ > ./windows-aarch64-server-fastdebug/bin/java.exe > -XX:+UnlockExperimentalVMOptions

Re: JDK14 cross-compile to arm64 fails with linking error

2020-10-20 Thread Andrew Haley
Hi, On 19/10/2020 03:53, Choe, Jiwon wrote: > I'm trying to cross-compile JDK 14 to target aarch64-linux-gnu, from a > 64-bit x86 Linux (Ubuntu 18.04). > > I followed the steps described in the documentation ( >

Integrated: 8254282: Add Linux x86_32 builds to submit workflow

2020-10-20 Thread Aleksey Shipilev
On Mon, 12 Oct 2020 12:46:57 GMT, Aleksey Shipilev wrote: > Building x86_32 usually exposes 32/64 cleanliness problems early. Since > 32-bit builds break often, it might make sense > to add them to submit workflow. The x86_32 might not be widely deployed by > itself, but 32/64 bit cleanliness